t-sql cursor with loop problem

[mrdude]

i am working on a web analysis project. i am having difficulty with counting hits and visits (a group of hits without a 30 minute break between hits). i decided to build a cursor in order to calculate visits. however, i have no experience with coding cursors and very little experience with both loops and t-sql.

in the cursor, it gets the data from a table that contains the IIS log (used logparser to transfer the logs to sql server). it will then calculate the hits and visits and insert this data into another table that will store a record of total hits and visits for each day.

the problem i am having is that there is no output from this current code. i can't seem to get it to loop back through the if statements and calculate.

any help?

set nocount on
 
declare @datetime datetime, @username varchar(30), @holddate datetime, @holdusername varchar(30), @hits int, @visits int, @counter int, @inshits int, @insvisits int
 
set @counter = 0
declare visitcalculator cursor
for select datetime, cs_username from testmetrics.dbo.alldata1 order by cs_username, datetime
 
begin
open visitcalculator
 
 
fetch next from visitcalculator
into @datetime, @username
 
while @@fetch_status = 0
begin 
if @username = @holdusername --compares username to previous row.  
    begin
    set @hits = @hits + 1 --count hits
    set @holdusername = @username
    set @holddate = @datetime
    fetch next from visitcalculator into @datetime, @username
    end
 
  if @username = @holdusername and datediff(minute, @holddate, @datetime) > 30  --find a break of 30 or more minutes
    begin
   set @visits = @visits + 1 --count visits
 set @holdusername = @username
    set @holddate = @datetime
    fetch next from visitcalculator into @datetime, @username
    end
 
 if @username != @holdusername
begin 
set @holdusername = @username
set @holddate = @datetime
fetch next from visitcalculator into @datetime, @username  --grab next row. 
set @visits = @insvisits --transfer visits to insert
set @hits = @inshits --transfer hits to insert
set @visits = 0 --reset visits
set @hits = 0 --reset hits
set @counter = @counter + 1 --add to counter
end 
 
if @counter > 1 --write data for each user into table
begin
insert into testmetrics.dbo.userinfo (username, date, hits, visits) values (@holdusername, @holddate, @inshits, @insvisits)
end 
 
end 
end
close visitcalculator
deallocate visitcalculator

[BalochDude]

A simple example of how to write sql cursors. You may want to download the zip file (which contains the sql file in it.)

http://www.chapterzero.co.uk/article...r-cursors.aspx

Cheers!