problems with my login

[twodelay]

Hi, i don't know if anyone can help me. I'm really a novice to be honest. I have a site I'm working on and using some code I made with the help of a friend i set up a login system. It worked on the server we were using. But when i tried to adapt it to a different server for a website I needed this functionality for it doesn't seem to work.

Somewhere in the transition something has either been lost or not added. I'm sure I've cover all the bases. I know there will be more info from me but if anyone can think of any obvious reasons that would be great I can then start to tick them off the list!

I look forward to hearing from anyone!

[Atli]

Hi. Welcome to TSDN!

There are so many reasons why that could be happening I barely know where to start. It would help if you could post your code here, so we could see if we spot anything specific.

The first things I'd look for is any code that relies on register_global s or something that loads resources from or links to an absolute path ("http://localhost/page.php" rather than "/page.php").

But as I say, it's impossible to say unless we can have a look at your code.

[twodelay]

Ok bit of a mess but here is the login code. its in a separate document called account.php. I have then used an include_once within the page i want it to appear. if that makes sense. anyway see below:

<?
 
if ($_SESSION["userid"]) {
    ?>
<link href="../../css/rollovers.css" rel="stylesheet" type="text/css" />
<link href="../../css/styles.css" rel="stylesheet" type="text/css" />
<link href="../../css/stylestext.css" rel="stylesheet" type="text/css" />
 
    <div id="signup"><div id="blogspacer"></div>
        <p class="bodyboldblue">Logged in</p>
        <?=$loginerror?>
        <p class="loginbody">You are currently logged in as <strong>
        <?=$member["member_name"]?>
        </strong></p>    
        <p><a class="loginbody" href='<?=$_SERVER['PHP_SELF']?>?logout=true<?=($_GET["id"]) ? "&id=".$_GET["id"] : "";?>'>Click here to log out</a></p>
    </div>
    <div id="blogspacer"></div>
    <?
}
else {
    ?>
    <div id="signup"><div id="blogspacer"></div>
    <form action='<?=$_SERVER['PHP_SELF']?><?=($_GET["id"]) ? "?id=".$_GET["id"] : "";?>' method='POST'/>
    <p class="bodyboldblue">Blog Login</p>
    <p class="loginbody">Username <br /><input name='un' type='text' class="loginbody" size='20'/>
      </p><p class="loginbody">Password <br /><input name='pw' type='password' class="loginbody" size='20'/>
      </p><p><input type='submit' class="loginbody" value='Login'/></p>
    </div>
    <div id="blogspacer"></div>
    <?
}
 
?>
 

[Atli]

Ahh ok.

Before you change anything, change the short-tags into real PHP tags.
Short-tags are disabled by default in PHP and you should avoid using them at all times. They are a little shorter, but honestly, their nothing but trouble.

That is:

# Change these tags:
<? .. ?>
<?=$var?>
 
# Into these tags:
<?php ... ?>
<?php echo $var; ?>
 

[twodelay]

Ahh ok.

Before you change anything, change the short-tags into real PHP tags.
Short-tags are disabled by default in PHP and you should avoid using them at all times. They are a little shorter, but honestly, their nothing but trouble.

That is:

# Change these tags:
<? .. ?>
<?=$var?>
 
# Into these tags:
<?php ... ?>
<?php echo $var; ?>
 

Cool, i will sort this and let you know when its done. Thanks for your help so far.... and thanks in anticipation of your help to come!

[twodelay]

<?php if ($_SESSION["userid"]) {?>
<link href="../../css/rollovers.css" rel="stylesheet" type="text/css" />
<link href="../../css/styles.css" rel="stylesheet" type="text/css" />
<link href="../../css/stylestext.css" rel="stylesheet" type="text/css" />
 
    <div id="signup"><div id="blogspacer"></div>
        <p class="bodyboldblue">Logged in</p>
        <?php echo $loginerror?>
        <p class="loginbody">You are currently logged in as <strong>
        <?php echo $member["member_name"]?>
        </strong></p>    
        <p><a class="loginbody" href='<?php echo $_SERVER['PHP_SELF']?>?logout=true<?php echo ($_GET["id"]) ? "&id=".$_GET["id"] : "";?>'>Click here to log out</a></p>
    </div>
    <div id="blogspacer"></div>
    <?php
}
else {
    ?>
    <div id="signup"><div id="blogspacer"></div>
    <form action='<?php echo $_SERVER['PHP_SELF']?><?=($_GET["id"]) ? "?id=".$_GET["id"] : "";?>' method='POST'/>
    <p class="bodyboldblue">Blog Login</p>
    <p class="loginbody">Username <br /><input name='un' type='text' class="loginbody" size='20'/>
      </p><p class="loginbody">Password <br /><input name='pw' type='password' class="loginbody" size='20'/>
      </p><p><input type='submit' class="loginbody" value='Login'/></p>
    </div>
    <div id="blogspacer"></div>
    <?php
}
 
?>
 

Ok so i have changed the short tags. It still does nothing when i try to log in. What do you think the next step is?

[Atli]

I can't see anything wrong with that particular code, except that you missed one short-tag in line 20.

There doesn't seem to be any code there to process the form data that is posted if the Session variable in line 1 is false, which I would guess is the code that actually logs the user in. Could the problem be there?

[twodelay]

I can't see anything wrong with that particular code, except that you missed one short-tag in line 20.

There doesn't seem to be any code there to process the form data that is posted if the Session variable in line 1 is false, which I would guess is the code that actually logs the user in. Could the problem be there?

Well from what you said in my limited knowledge I would have thought that that might be a problem, however, it is the same code as as i used before, which worked. Grr this is complicated. The thing that bugs me is that it seems as if its not even processing anything. When you submit illegal characters or incorrect login it doesnt come up with the error message that has been set up.

I will cross reference this with my old files and see if i can see anything in the code.

[twodelay]

Ok i have racked my brains and cant see or find anything that is different to the other version i did (that worked) other than stylesheets etc.

You mentioned:

There doesn't seem to be any code there to process the form data that is posted if the Session variable in line 1 is false, which I would guess is the code that actually logs the user in. Could the problem be there?

Could you suggest what changes i could make to correct this... so sorry as you can tell I'm very, very poor at this! thanks for your help.

[Atli]

I could probably see if there are problems with the code, if I could see it :)
Just the part where you fetch the POST values and where you log the user in.

My first guess would be it has something to do with the register_global s directive, but there is really no way to tell unless I see the code.

Just out of curiosity, which version of PHP did this code work on? And which version are you trying to use it on now?

Could you create a new .php file with the following content, run it and find the value of the 'short_open_tag ' directive and the 'register_globa ls' directive?

<?php echo phpinfo(); ?>