Issue with moving a common method to base class

[Curious]

I have too similar methods in two classes:

-----------------------DistributionFoo---------------------
class DistributionFoo : FooBase
{
private SortableBinding List<Distributi onRowStatusmSel ected;

private void DoSomething()
{

for (int i = 0; i < mSelected.Count ; i++)
{

DistributionRow Status lInstance = mSelected[i];

lInstance.Execu te();

ReportProgress( i / mSelected.Count , i);

if (mSelected.Coun t 1)
{
UpdateControls( );
}
}
}
}

-----------------------ReportFoo---------------------
class ReportFoo : FooBase
{
private SortableBinding List<ReportRowS tatusmSelected;

private void DoSomething()
{

for (int i = 0; i < mSelected.Count ; i++)
{

ReportRowStatus lInstance = mSelected[i];

lInstance.Execu te();

ReportProgress( i / mSelected.Count , i);

if (mSelected.Coun t 1)
{
UpdateControls( );
}
}
}
}

Since the methods, "DoSomethin g", in both classes, are identical
except for the lists that they operate on. mSelected in
"DistributionFo o" is a collection of "DistributionRo wStatus" type of
objects, while it is a collection of "ReportRowStatu s" type of ojects
in "ReportFoo" .

I want to move "DoSomethin g" method to the base class from child
classes so that both "DistributionFo o" and "ReportFoo" can share it.
However, I don't know how to handle "mSelected" .

I have code like below. I'm sure this doesn't work. Would welcome any
advice on how to make it work!

-----------------------FooBase---------------------
class FooBase
{
protected SortableBinding List<objectmSel ected;

protected void DoSomething()
{

for (int i = 0; i < mSelected.Count ; i++)
{

object lInstance = mSelected[i];

lInstance.Execu te();

ReportProgress( i / mSelected.Count , i);

if (mSelected.Coun t 1)
{
UpdateControls( );
}
}
}
}
-----------------------DistributionFoo---------------------
class DistributionFoo : FooBase
{
private SortableBinding List<Distributi onRowStatusmSel ected;

}

-----------------------ReportFoo---------------------
class ReportFoo : FooBase
{
private SortableBinding List<ReportRowS tatusmSelected;

}

[amdrit]

I haven't tried this, but how about creating a common interface that each
type works against?

internal interface IBaseElement
{
void Execute();
}

internal abstract class baseclass<Twher e T : IBaseElement
{
protected List<TmSelected ;

protected baseclass()
{
mSelected = new List<T>();
}

protected abstract Type GetElementType( );
protected abstract void ReportProgress( decimal percentComplete , int
position);
protected abstract void UpdateControls( );
protected void DoSomething()
{

for (int i = 0; i < mSelected.Count ; i++)
{

IBaseElement tempElement = (IBaseElement)m Selected[i];

tempElement.Exe cute();

ReportProgress( i / mSelected.Count , i);

if (mSelected.Coun t 1)
{
UpdateControls( );
}
}
}
}

internal class DistributionRow Status : IBaseElement
{

#region IBaseElement Members

public void Execute()
{
//
}

#endregion
}

internal class ReportRowStatus : IBaseElement
{

#region IBaseElement Members

public void Execute()
{
//
}

#endregion
}

internal class Class1 : baseclass<Distr ibutionRowStatu s>
{
public Class1():base()
{
//
}

protected override Type GetElementType( )
{
return System.Type.Get Type("Distribut ionRowStatus");
}

protected override void ReportProgress( decimal percentComplete , int
position)
{
//Do custom work here
}

protected override void UpdateControls( )
{
//Do custom work here
}
}

internal class Class2 : baseclass<Repor tRowStatus>
{
public Class2(): base()
{
//
}

protected override Type GetElementType( )
{
return System.Type.Get Type("ReportRow Status");
}

protected override void ReportProgress( decimal percentComplete , int
position)
{
//Do custom work here
}

protected override void UpdateControls( )
{
//Do custom work here
}
}

"Curious" <fi********@yah oo.comwrote in message
news:2c******** *************** ***********@l16 g2000hsf.google groups.com...

>I have too similar methods in two classes:

-----------------------DistributionFoo---------------------
class DistributionFoo : FooBase
{
private SortableBinding List<Distributi onRowStatusmSel ected;

private void DoSomething()
{

for (int i = 0; i < mSelected.Count ; i++)
{

DistributionRow Status lInstance = mSelected[i];

lInstance.Execu te();

ReportProgress( i / mSelected.Count , i);

if (mSelected.Coun t 1)
{
UpdateControls( );
}
}
}
}

-----------------------ReportFoo---------------------
class ReportFoo : FooBase
{
private SortableBinding List<ReportRowS tatusmSelected;

private void DoSomething()
{

for (int i = 0; i < mSelected.Count ; i++)
{

ReportRowStatus lInstance = mSelected[i];

lInstance.Execu te();

ReportProgress( i / mSelected.Count , i);

if (mSelected.Coun t 1)
{
UpdateControls( );
}
}
}
}

Since the methods, "DoSomethin g", in both classes, are identical
except for the lists that they operate on. mSelected in
"DistributionFo o" is a collection of "DistributionRo wStatus" type of
objects, while it is a collection of "ReportRowStatu s" type of ojects
in "ReportFoo" .

I want to move "DoSomethin g" method to the base class from child
classes so that both "DistributionFo o" and "ReportFoo" can share it.
However, I don't know how to handle "mSelected" .

I have code like below. I'm sure this doesn't work. Would welcome any
advice on how to make it work!

-----------------------FooBase---------------------
class FooBase
{
protected SortableBinding List<objectmSel ected;

protected void DoSomething()
{

for (int i = 0; i < mSelected.Count ; i++)
{

object lInstance = mSelected[i];

lInstance.Execu te();

ReportProgress( i / mSelected.Count , i);

if (mSelected.Coun t 1)
{
UpdateControls( );
}
}
}
}
-----------------------DistributionFoo---------------------
class DistributionFoo : FooBase
{
private SortableBinding List<Distributi onRowStatusmSel ected;

}

-----------------------ReportFoo---------------------
class ReportFoo : FooBase
{
private SortableBinding List<ReportRowS tatusmSelected;

}

[Curious]

Hi Amdrit,

Thanks for the advice! Are you suggesting using generics? I'll try it
out.

[Curious]

Hi Amdrit,

I don't know how your code works. Would you answer my questions below:

1) mSelected is passed to each child class. Is there a need to define
construction of baseclass in baseclass?

2) Since you've defined "GetElementType ", where do you use it in the
base class?

3) What are "class1" and "class2"? Are they redundent with
"DistributionRo wStatus" and "ReportRowStatu s"?

Thanks,