JS onclick multiple functions

[lewnussi]

I am trying to call more than one function starting with onclick in a form to work in all browsers.

In the form, this calls only function_1:

<input type="submit" value="thevalue" name="goodname" onclick="return function_1(this.form);function_2(this.form);" />
 

So I tried only function_1 for the onclick, and put this in a .js file, but it also does not call function_2:

function function_1(health)
{
if(health.phone.value=="")
{
alert("Please enter your home telephone number.\n");
return false;
}
return true;
function_2();
}
 
function function_2(health)
{
 
if(health.first_name.value.length<2)
{
    alert("Please enter your first name.\n");
    return false;
}        
return true;
}
 

In both cases, the first function works, but not the second, and the Firefox Error Console does not return an error.

So I tried this in the form, but it produces the error "health has no properties":

<input type="submit" value="thevalue" name="goodname" onclick="return callThem(this.form);" />
 

with this in the .js file:

function callThem()
{
function_1();
function_2();
}
 
function function_1(health)
{
if(health.phone.value=="")
{
alert("Please enter your home telephone number.\n");
return false;
}
return true;
}
 
function function_2(health)
{
 
if(health.first_name.value.length<2)
{
    alert("Please enter your first name.\n");
    return false;
}        
return true;
}
 

How do I call function_2?

[gits]

just write a 'wrapper'-function func_3 like this:

function func_3(health) {
    var val = true;
 
    val = function_1(health);
 
    // in case function_1 returns true we call function_2
    if (val) {
        val = function_2(health);
    }
 
    return val;
}

now just call func_3 in your onclick :)

kind regards

[lewnussi]

I tried that but now when the alert window for function_1 is clicked, the form goes to the "action=" without any entry needing to be made in the form.

function func_3(health)
{
var val = true;
val = function_1(health);
//in case function_1 returns true, we call function_2
if(val)
{
val = function_2(health);
}
return val;
}
 
function function_1(health)
{
if(health.phone.value=="")
{
alert("Please enter your home telephone number.\n");
return false;
}
return true;
}
 
function function_2(health)
{       
if(health.first_name.value.length<2)
{
    alert("Please enter your first name.\n");
    return false;
}        
return true;
}
 

There is currently no other code in this .js file.

Still puzzled.

[gits]

how do you call it?

kind regards