What am I doing wrong?

killermookie

I'm not a javascripter so this is slightly unfamiliar to me. What I'm
trying to do is that if someone clicks the radio button for Other, then
the text input for other will become enabled.

What is wrong with this? Thank you!

<html>
<head>
<script language="JavaS cript">

</script>
</head>

<body>

<form name="shipForm" >
<input type="text" name="number" size="5">
<input type="radio" name="package"
onClick=Package (shipForm)>Pall et</span>
<input type="radio" name="package" onClick=Package (shipForm)>Box</span>
<input type="radio" name="package"
onClick=Package (shipForm)>Enve lope</span>
<input type="radio" name="package"
onClick=Package (shipForm)>Othe r</span>
<input type="text" name="otherPack age" disabled>
</form>

</body>
</html>

Dec 29 '05 #1

Subscribe Reply

1500

killermookie

I figured it out. :) No need for a reply.

Dec 29 '05 #2

McKirahan

<ki**********@g mail.com> wrote in message
news:11******** *************@g 44g2000cwa.goog legroups.com...

I'm not a javascripter so this is slightly unfamiliar to me. What I'm
trying to do is that if someone clicks the radio button for Other, then
the text input for other will become enabled.

What is wrong with this? Thank you!

<html>
<head>
<script language="JavaS cript">

</script>
</head>

<body>

<form name="shipForm" >
<input type="text" name="number" size="5">
<input type="radio" name="package"
onClick=Package (shipForm)>Pall et</span>
<input type="radio" name="package" onClick=Package (shipForm)>Box</span>
<input type="radio" name="package"
onClick=Package (shipForm)>Enve lope</span>
<input type="radio" name="package"
onClick=Package (shipForm)>Othe r</span>
<input type="text" name="otherPack age" disabled>
</form>

</body>
</html>

Try this instead.

<html>
<head>
<title>Package. htm</title>
<script type="text/javascript">
function Package(thisfor m) {
if (thisform.packa ge[3].checked) {
thisform.otherP ackage.style.ba ckgroundColor = "#FFFFFF";
thisform.otherP ackage.disabled = false;
thisform.otherP ackage.focus();
} else {
thisform.otherP ackage.value = "";
thisform.otherP ackage.style.ba ckgroundColor = "#DDDDDD";
thisform.otherP ackage.disabled = true;
}
}
</script>
</head>
<body>
<form name="shipForm" >
<input type="text" name="number" size="5">
<input type="radio" name="package"
onClick="Packag e(shipForm)">Pa llet
<input type="radio" name="package"
onClick="Packag e(shipForm)">Bo x
<input type="radio" name="package"
onClick="Packag e(shipForm)">En velope
<input type="radio" name="package"
onClick="Packag e(shipForm)">Ot her
<input type="text" name="otherPack age"
disabled style="backgrou nd-color: #DDDDDD">
</form>
</body>
</html>

Dec 29 '05 #3

killermookie

Thanks McKirahan. This is something I can learn from. :)

Dec 29 '05 #4

Thomas 'PointedEars' Lahn

McKirahan wrote:

<html>
<head>
<title>Package. htm</title>
Not Valid. <URL:http://validator.w3.or g/>
<script type="text/javascript">
function Package(thisfor m) {
Identifiers of methods not intended to be used as constructors should not
start with a capital letter, not even to work around a reserved word issue.

function _package(inp)
{
if (thisform.packa ge[3].checked) {
Should be

if (thisform.form. elements['package'][3].checked)

aso. `thisform' is a reference to the HTMLFormElement , but that should
not be passed with `shipForm' (it's IE-proprietary); instead, `this' should
be passed and the `form' property of the referenced event target object
should be used. Form controls should be referenced through the `elements'
collection when possible (as here).
thisform.otherP ackage.style.ba ckgroundColor = "#FFFFFF";
<URL:http://www.w3.org/QA/Tips/color>
thisform.otherP ackage.disabled = false;
thisform.otherP ackage.focus();
<URL:http://pointedears.de/scripts/test/whatami#inferen ce>
} else {
thisform.otherP ackage.value = "";
thisform.otherP ackage.style.ba ckgroundColor = "#DDDDDD";
thisform.otherP ackage.disabled = true;
Since `thisform.other Package' is used very often, it is prudent to assign
the reference to a variable and use the latter in place once it has been
established that it stores a valid reference:

var o = thisform.otherP ackage;
if (o)
{
o.... = ...
}

or, if the recommendation above is followed:

var f, o;
if (inp
&& (f = inp.form)
&& (o = f.elements)
&& (o = o['otherPackage']))
{
var b = f.elements['package'][3].checked;
if (!b)
{
o.value = "";
}

o.style.backgro undColor = b ? '#fff' : '#ccc';
o.style.color = b ? '#000' : '#333';
o.disabled = b;

if (b && isMethodType(ty peof o.focus))
{
o.focus();
}
}
}
}
</script>
</head>
<body>
<form name="shipForm" >
Not Valid, the `action' attribute is missing.
<input type="text" name="number" size="5">
type="text" is the default for `input' elements and can be safely omitted.
<input type="radio" name="package"
onClick="Packag e(shipForm)">Pa llet
<input type="radio" name="package"
onClick="Packag e(shipForm)">Bo x
<input type="radio" name="package"
onClick="Packag e(shipForm)">En velope
<input type="radio" name="package"
onClick="Packag e(shipForm)">Ot her
But then the `click' event bubbles by default and so could be better handled
at the parent `form' element:

function _package(f)
{
var o;
if (o = f.elements
&& (o = o['otherPackage']))
{
var b = f.elements['package'][3].checked;
if (!b)
{
o.value = "";
}

o.style.backgro undColor = b ? '#fff' : '#ccc';
o.style.color = b ? '#000' : '#333';
o.disabled = b;

if (b && isMethodType(ty peof o.focus))
{
o.focus();
}
}
}

<form ... onclick="_packa ge(this);">
<input type="radio" name="package" id="pkg_pallet " value="pallet"<label for="pkg_pallet ">Pallet</label><br> <input type="radio" name="package" id="pkg_box" value="box"<label for="pkg_box">B ox</label><br> <input type="radio" name="package" id="pkg_envelop e" value="envelope "<label for="pkg_envelo pe">Envelope</label><br> <input type="radio" name="package" id="pkg_other" value="other"<label for="pkg_other" >Other</label><br> ...
</form>
<input type="text" name="otherPack age"
disabled style="backgrou nd-color: #DDDDDD">

That color is not Truly Web-Safe[tm], and the foreground color should
be declared, too. See above.

Furthermore, the element should not be disabled by default but in the
`onload' event handler, because otherwise it becomes useless to users
without client-side script support:

<body onload="documen t.forms['shipForm'].elements['otherPackage'].disabled
= true;">
...
<form action="..." name="shipForm" >
...
<input name="otherPack age" style="backgrou nd-color:#ccc; color:#666">
...
</form>
...
</body>
PointedEars

Dec 30 '05 #5

Randy Webb

Thomas 'PointedEars' Lahn said the following on 12/30/2005 2:46 AM:

McKirahan wrote:

<html>
<head>
<title>Packag e.htm</title>

Not Valid. <URL:http://validator.w3.or g/>

Irrelevant to the thread.

<script type="text/javascript">
function Package(thisfor m) {

Identifiers of methods not intended to be used as constructors should not
start with a capital letter, not even to work around a reserved word issue.

Irrelevant to the thread.
function _package(inp)
{

if (thisform.packa ge[3].checked) {

Should be

if (thisform.form. elements['package'][3].checked)

If thisform is a reference to the form itself then the reference back to
its form is redundant as you are already at the form level.
aso. `thisform' is a reference to the HTMLFormElement , but that should
not be passed with `shipForm' (it's IE-proprietary); instead, `this' should
be passed and the `form' property of the referenced event target object
should be used. Form controls should be referenced through the `elements'
collection when possible (as here).

thisform.otherP ackage.style.ba ckgroundColor = "#FFFFFF";

<URL:http://www.w3.org/QA/Tips/color>

Irrelevant to the thread.

thisform.otherP ackage.disabled = false;
thisform.otherP ackage.focus();

<URL:http://pointedears.de/scripts/test/whatami#inferen ce>

Irrelevant to the thread.

} else {
thisform.otherP ackage.value = "";
thisform.otherP ackage.style.ba ckgroundColor = "#DDDDDD";
thisform.otherP ackage.disabled = true;

Since `thisform.other Package' is used very often, it is prudent to assign
the reference to a variable and use the latter in place once it has been
established that it stores a valid reference:

Irrelevant to the thread.
var o = thisform.otherP ackage;
if (o)
{
o.... = ...
}

or, if the recommendation above is followed:

var f, o;
if (inp
&& (f = inp.form)
&& (o = f.elements)
&& (o = o['otherPackage']))
{
var b = f.elements['package'][3].checked;
if (!b)
{
o.value = "";
}

o.style.backgro undColor = b ? '#fff' : '#ccc';
o.style.color = b ? '#000' : '#333';
o.disabled = b;

if (b && isMethodType(ty peof o.focus))
{
o.focus();
}
}

}
}
</script>
</head>
<body>
<form name="shipForm" >

Not Valid, the `action' attribute is missing.

Irrelevant to the thread.

<input type="text" name="number" size="5">

type="text" is the default for `input' elements and can be safely omitted.

Irrelevant to the thread.

<input type="radio" name="package"
onClick="Packag e(shipForm)">Pa llet
<input type="radio" name="package"
onClick="Packag e(shipForm)">Bo x
<input type="radio" name="package"
onClick="Packag e(shipForm)">En velope
<input type="radio" name="package"
onClick="Packag e(shipForm)">Ot her

But then the `click' event bubbles by default and so could be better handled
at the parent `form' element:

Irrelevant to the thread.
function _package(f)
{
var o;
if (o = f.elements
&& (o = o['otherPackage']))
{
var b = f.elements['package'][3].checked;
if (!b)
{
o.value = "";
}

o.style.backgro undColor = b ? '#fff' : '#ccc';
o.style.color = b ? '#000' : '#333';
o.disabled = b;

if (b && isMethodType(ty peof o.focus))
{
o.focus();
}
}
}

<form ... onclick="_packa ge(this);">
<input type="radio" name="package" id="pkg_pallet " value="pallet"
><label for="pkg_pallet ">Pallet</label><br> <input type="radio" name="package" id="pkg_box" value="box"
><label for="pkg_box">B ox</label><br>

<input type="radio" name="package" id="pkg_envelop e" value="envelope "
><label for="pkg_envelo pe">Envelope</label><br>

<input type="radio" name="package" id="pkg_other" value="other"
><label for="pkg_other" >Other</label><br>

...
</form>
<input type="text" name="otherPack age"
disabled style="backgrou nd-color: #DDDDDD">

That color is not Truly Web-Safe[tm], and the foreground color should
be declared, too. See above.

Irrelevant to the thread.
Furthermore, the element should not be disabled by default but in the
`onload' event handler, because otherwise it becomes useless to users
without client-side script support:

<body onload="documen t.forms['shipForm'].elements['otherPackage'].disabled
= true;">
use window.onload, not <body onload
...
<form action="..." name="shipForm" >
...
<input name="otherPack age" style="backgrou nd-color:#ccc; color:#666">
...
</form>
...
</body>
PointedEars

--
Randy
comp.lang.javas cript FAQ - http://jibbering.com/faq & newsgroup weekly
Javascript Best Practices - http://www.JavascriptToolbox.com/bestpractices/
Answer:It destroys the order of the conversation

Dec 30 '05 #6

Michael Winter

On 30/12/2005 12:44, Randy Webb wrote:

[snip]

Irrelevant to the thread.
And you've never posted something irrelevant to a thread? What about
others that have? I know you don't like Thomas, but come on, play nice.
-- [...] Answer:It destroys the order of the conversation

Didn't you forget the question?

Mike

--
Michael Winter
Prefix subject with [News] before replying by e-mail.

Dec 30 '05 #7

Patient Guy

Thomas 'PointedEars' Lahn <Po*********@we b.de> wrote in
news:46******** ********@Pointe dEars.de:

McKirahan wrote:
<html>
<head>
<title>Package. htm</title>
Not Valid. <URL:http://validator.w3.or g/>

Really?

The content for the TITLE element is parsed character data (#PCDATA), and
apparently can even include character references (character entity and
numeric character references). The HTML 4.01 specification refers the
reader to the ISO 8879 standard for a definitive reading of #PCDATA.

Cutting and pasting this HTML into the W3C validator and setting Doctype
for 4.01 Transitional, there was only one error making it invalid, which
was the missing 'action' attribute for the form element.

You must have caught the validator when it had a fever that day. ;-)
[excised rest of message]

PointedEars

Dec 30 '05 #8

Thomas 'PointedEars' Lahn

Patient Guy wrote:

Thomas 'PointedEars' Lahn <Po*********@we b.de> wrote [...]:
McKirahan wrote:
<html>
<head>
<title>Package. htm</title> Not Valid. <URL:http://validator.w3.or g/>

Really?

Really.
The content for the TITLE element is parsed character data (#PCDATA), and
apparently can even include character references (character entity and
numeric character references). [...]
I was not referring to the `title' element, but to all of the quoted code up
to this line which lacks the DOCTYPE declaration and lacks the character
set declaration for non-HTTP service. The snippet claims to be a HTML
document; it is not.
Cutting and pasting this HTML into the W3C validator and setting Doctype ^^^^^^^^^^^^^^^ for 4.01 Transitional, ^^^^^^^^^^^^^^^ ^^^^^^
See?
there was only one error making it invalid, which was the missing 'action'
attribute for the form element.

You have not validated the document through file upload which would have
revealed the missing character set declaration, too.
PointedEars

Dec 30 '05 #9

Randy Webb

Michael Winter said the following on 12/30/2005 10:34 AM:

On 30/12/2005 12:44, Randy Webb wrote:

[snip]
Irrelevant to the thread.

And you've never posted something irrelevant to a thread? What about
others that have? I know you don't like Thomas, but come on, play nice.

Yes sir :)

--

[...]
Answer:It destroys the order of the conversation

Didn't you forget the question?

Or forgot to snip it all :)

--
Randy
comp.lang.javas cript FAQ - http://jibbering.com/faq & newsgroup weekly
Javascript Best Practices - http://www.JavascriptToolbox.com/bestpractices/

Dec 30 '05 #10

Similar topics

125

14689

What so special about PostgreSQL and other RDBMS?

by: Sarah Tanembaum | last post by:

Beside its an opensource and supported by community, what's the fundamental differences between PostgreSQL and those high-price commercial database (and some are bloated such as Oracle) from software giant such as Microsoft SQL Server, Oracle, and Sybase? Is PostgreSQL reliable enough to be used for high-end commercial application? Thanks

Microsoft SQL Server

121

10011

What IDE are you using?

by: typingcat | last post by:

First of all, I'm an Asian and I need to input Japanese, Korean and so on. I've tried many PHP IDEs today, but almost non of them supported Unicode (UTF-8) file. I've found that the only Unicode support IDEs are DreamWeaver 8 and Zend PHP Studio. DreamWeaver provides full support for Unicode. However, DreamWeaver is a web editor rather than a PHP IDE. It only supports basic IntelliSense (or code completion) and doesn't have anything...

PHP

2031

What's wrong with this code ? (struct serialization to raw byte str

by: Alfonso Morra | last post by:

Hi, I am at the end of my tether now - after spending several days trying to figure how to do this. I have finally written a simple "proof of concept" program to test serializing a structure containing pointers into a "flattened" bit stream. Here is my code (it dosen't work). I would be grateful for any feedback that helps fix this. My intention

C / C++

4192

What C# Needs

by: Keith K | last post by:

Having developed with VB since 1992, I am now VERY interested in C#. I've written several applications with C# and I do enjoy the language. What C# Needs: There are a few things that I do believe MSFT should do to improve C#, however. I know that in the "Whidbey" release of VS.NET currently

C# / C Sharp

5032

What does it mean?

by: Jason Huang | last post by:

Hi, Would someone explain the following coding more detail for me? What's the ( ) for? CurrentText = (TextBox)e.Item.Cells.Controls; Thanks. Jason

C# / C Sharp

2704

Adding to a Bound DataGrid: What the @#$!% am I doing wrong!

by: Aaron Ackerman | last post by:

I cannot a row to this bound DataGrid to SAVE MY LIFE! I have tried everything and I am at a loss. The using goes into add mode with the add button adds his data then updates with the update button, seems simple. I am using ALL visual controls (supposedly to simplify things. If I was not using the visual controls and calling an ExecuteNonQuery no prob. Please look at my code and tell me what I am doing wrong. Also, what are the advatages...

ASP.NET

1979

what all a class has by default

by: Ajay | last post by:

Hi all, i want to know when i create a class.what all it contains.I know the following things are there by default if i do not declare them by myself.Please tell the other things that are left. 1. constructor 2.Destructor 3.Copy constructor 4. Assignment operator