Trouble calculating percentage in C++ dice program

[d0ugg]

I'm writing a program that will have to roll the dice A and dice B one million times, and calculate the percentage of times that the dies will be equal.

I'm having trouble to figure out how the percentage will work.

Here is my code:

 
#include <ctime>
#include <iostream>
using namespace std;
 
const double roll = 1000000;
 
int rolldie() //statement will give u 6
{
return (rand()%6+1);
}
 
void Randomize() 
{
srand( (unsigned)time( NULL ) ) ;
}
 
int main()
{
    int diceA;
    int diceB;
    int totals;
    int i;
    cout << "Rolling dices one million times\n";
    Randomize();
 
    for(i=0;i<roll;i++)
    {    
        diceA = rolldie();
        diceB = rolldie();
        int    totals = diceA + diceB;
        totals++;
    }
 
    if(diceA==diceB)
    {
        cout << "Doubles occurred" << totals / 1000000 << "percent of the time.";
    }
 
    return 0;
}
 

Thanks in advance,

Doug

[d0ugg]

Thanks for all the support guys, I just got home now and I going to work some more tonight on the code..

So basically I already understood what I have to do.. Here is my way..

First declare Dice A and also Dice B, than I want to roll Dice A and also Dice B one million times. After that I will see how many times Dice A equals to Dice B, but unfortunately I don't know how to do that in the for loop yet, I tried a couple things but still get some errors..

Thanks,

~doug

[Ganon11]

Thanks for all the support guys, I just got home now and I going to work some more tonight on the code..

So basically I already understood what I have to do.. Here is my way..

First declare Dice A and also Dice B, than I want to roll Dice A and also Dice B one million times. After that I will see how many times Dice A equals to Dice B, but unfortunately I don't know how to do that in the for loop yet, I tried a couple things but still get some errors..

Thanks,

~doug

You're on the right track. But you have the order wrong. Once you have rolled DiceA and DiceB 1,000,000 times, how are you going to check if they were ever equal? Once you re-roll a die, you've lost its previous number. You need to check if DiceA and DiceB are equal right after they've been rolled - inside the loop with their rolls.

[d0ugg]

Good point, thank you for the quick answer..
So right now my loop code is just like that

for(i=0;i<roll;i++)
          {   
              diceA = rolldie();
                      cout << "DiceA is\n" << diceA;   //added debug line
              diceB = rolldie();
                      cout <<"DiceB is\n" << diceB;   //added debug line
              //diceA == diceB;
                     // cout <<"totals is when dice are added together" << totals;
              //totals++;
              //       cout <<"totals is after increment" << totals;
          }
 

*Where I put // its because I don't know the syntax, I'm not sure yet how I will check diceA == DiceB.

*
I just had an idea, I decided to create a check function that will see if diceA and diceB is equal..

So now, I have also this in my code:

int check()
{
    while(diceA==diceB)
    return 0;
}
 

Does that loop work for this kind of situation?


Thanks,

~doug

[Studlyami]

Your close. Rather than doing while DiceA==DiceB use an if statment during the for loop. You don't want to use while (DiceA==DiceB) because while is a loop and the loop will stop when the conditions are not met (I.E. DiceA is not equal to DiceB). We are not interested in how many time in a row DiceA == DiceB. We just want how many times out of a million rolls were they equal.

Below is the basic flow your looking for.

for(int i = 0; i< TotalNumberOfRolls; i++)
{
   DiceA = Roll; //value 1-6
   DiceB = Roll; //value 1-6
    if(DiceA==DiceB)
   {
        //The Two dice are the same so incriment counter
   }
}
 
cout<<"The dice were equal" << counter<<" Times";
 

[kreagan]

Good point, thank you for the quick answer..
So right now my loop code is just like that

So now, I have also this in my code:

int check()
{
    while(diceA==diceB)
    return 0;
}
 

Does that loop work for this kind of situation?


Thanks,

~doug

Great idea on creating the function. As for what is in the function, the loop won't work What is happening is, the while loop checks if the statement is true. If it is true, a zero will be returned. If it isn't true, nothing will be return (that's bad). Because of the return statement, you only run the while loop once. But if you remove the return statement, the program run the while loop forever or never. (Try placing the return 0 with cout << "I'm in the while loop" and you will see what I mean.) But there is another tool you can use that will only check it once. People have been hinting towards it. An IF statement.

When looking at an if statement, read it as

if ( something is true ) {
do X
}
else if ( something else is true ) { // if above statement is not true
do Y
}
else // if nothing above is true
do Z
}

where X, Y, and Z are just different procedures. For example returning 0 or rolling a dice. Whatever you want to put into it.

[d0ugg]

Hello Everyone,

Thanks for all the support one more time..
So right now my loop looks like this:

for(int i=0; i<roll; i++)
{
    diceA = rolldie(); //value 1-6
    diceB = rolldie(); //value 1-6
        if(diceA==diceB)
        {    
            i++;
        }
}
        cout<<"The dice were equal " << i <<" Times\n";
        return 0;
 

- The compiler does not reject my code, but it is a little bit weird because out of one million random rolls, it does not find any time that the Dice A = Dice B..

~doug

[Studlyami]

a couple of problems there.
1.) depending on your compiler when you do the cout<<"the dice... <<i<<
'i' was created in the for loop and on some compliers might lose i at the end of the loop (VS 2005 won't even let it compile).

2.) even if 'i' retained its value you are going to have i = 1,000,000 because the loop will stop when i >= 1,000,000. At the end of every loop you increase it by one. You also increase 'i' if the dice rolls are the same. You need 2 seperate counters. one to count the rolls the other to count the doubles.

fix those and it works like a charm.

[d0ugg]

Okay..


Finally I got one step done..
I got the loop working correctly..
Here is the code

for(int total=1; total<=1000000; total++)
{
    diceA = rolldie(); //value 1-6
    diceB = rolldie(); //value 1-6
        if(diceA==diceB)
        {    
            cout << setw(7) << "The dice were equal: " << total << endl;
        }
}
 

I just realize that i don't need to increment anything, because it will already run one million times and see when they are equal..
But now my problem is..

Calculate the percentage of times that they are equal..

[JosAH]

I just realize that i don't need to increment anything, because it will already run one million times and see when they are equal..
But now my problem is..

Calculate the percentage of times that they are equal..

Well, you've realized it wrong then ;-) Instead of telling the world everytime the
dice were equal you should increment a counter; that counter indicates the number
of equal rolls when the loop has finished; now you have two numbers:

1) 'roll' the number of rolls in total (here: 1,000,000)
2) 'counter' the number of rolls that were equal.

Now you do the simple math.

kind regards,

Jos

[d0ugg]

I started the code again..

Here is my code now

#include <iostream>
#include <ctime>
 
using namespace std;
 
void randomize();
int verify_1();
void calculate_1();
int rolldie();
 
void randomize(int *diceA, int *diceB)
{
srand((unsigned)+time(NULL));
*diceA = rand() %6+1;
srand((unsigned)+time(NULL));
*diceB = rand() %6+1;
}
 
int verify_1(int diceA, int diceB)
{
int roll;
if(diceA==diceB)
roll++;
return roll;
}
 
 
void calculate_1(float *doubles)
{
*doubles = *doubles/1000000;
}
 
 
int main()
{
int diceA;
int diceB;
float roll;
float doubles=0;
 
cout << "One million dice rolls";
for (roll=0; roll<1000000; roll++)
{
randomize(&diceA, &diceB);
doubles=verify_1(diceA, diceB);
calculate_1(&doubles);
cout << doubles;
return 0;
 
}
}
 
 

However when I run it shows me the percentage 0.. I don't know where I add something wrong..

The compiler does not give me any error, but gives me 2 warnings..

1 warning '=' : conversion from 'int' to 'float', possible loss of data
2 warning = uninitialized local variable 'roll' used



Thanks,

~doug