Trouble calculating percentage in C++ dice program

[d0ugg]

I'm writing a program that will have to roll the dice A and dice B one million times, and calculate the percentage of times that the dies will be equal.

I'm having trouble to figure out how the percentage will work.

Here is my code:

 
#include <ctime>
#include <iostream>
using namespace std;
 
const double roll = 1000000;
 
int rolldie() //statement will give u 6
{
return (rand()%6+1);
}
 
void Randomize() 
{
srand( (unsigned)time( NULL ) ) ;
}
 
int main()
{
    int diceA;
    int diceB;
    int totals;
    int i;
    cout << "Rolling dices one million times\n";
    Randomize();
 
    for(i=0;i<roll;i++)
    {    
        diceA = rolldie();
        diceB = rolldie();
        int    totals = diceA + diceB;
        totals++;
    }
 
    if(diceA==diceB)
    {
        cout << "Doubles occurred" << totals / 1000000 << "percent of the time.";
    }
 
    return 0;
}
 

Thanks in advance,

Doug

[sicarie]

 
    for(i=0;i<roll;i++)
    {    
        diceA = rolldie();
        diceB = rolldie();
        int    totals = diceA + diceB;
        totals++;
    }
 
 

Okay, let's walk through this for two arbitrary dice rolls.

for (i = 0; 0 < 1000000; 0++)
diceA = 3 //made this up
diceB = 4 // made this up too
totals = 3 + 4 // so totals = 7
totals++ // so totals = 8

for (i =1; 1< 1000000; 1++)
diceA = 1
diceB = 5
totals = 1+5 // totals = 6
totals++ // totals = 7

Do you see the issue here? Not only does totals get wiped out every iteration through the loop, but you also don't get the right total amount because of the increment.

I think you want it to be

totals += diceA + diceB

and no totals++. ::Edit:: and you might want to move the 'int totals' out of the loop. It will probably be seen as a re-declaration of the variable each time, in which case you'll get undefined behavior, and who knows what you will get.

I also changed the title to be a bit more descriptive - draw a few more people in, if they have something to comment on.

[JosAH]

    for(i=0;i<roll;i++)
    {    
        diceA = rolldie();
        diceB = rolldie();
        int    totals = diceA + diceB;
        totals++;
    }
 

Shouldn't you check *inside* that loop whether or not diceA equals diceB?
If they're equal you should increment a counter ('totals' mayhap?)

When the loop is finished you have rolled the dice 'roll' times and 'totals'
times they were equal.

kind regards,

Jos

[d0ugg]

Thank you so much,
That was very fast,

I will try that right now and let you guys know what happened.

Doug

[sicarie]

Shouldn't you check *inside* that loop whether or not diceA equals diceB?
If they're equal you should increment a counter ('totals' mayhap?)

When the loop is finished you have rolled the dice 'roll' times and 'totals'
times they were equal.

kind regards,

Jos

Does the OP even need the check to see if they are the same? Why does the OP care if they are the same? They should be dealt with the same way, right?

[kreagan]

Does the OP even need the check to see if they are the same? Why does the OP care if they are the same? They should be dealt with the same way, right?

The object of the assignment was to find the probability of doubles thrown. Your suggestion is for the average number thrown.

[sicarie]

The object of the assignment was to find the probability of doubles thrown. Your suggestion is for the average number thrown.

Ah, good catch.

[JosAH]

Ah, good catch.

You should try a different brand of coffee ;-)

kind regards,

Jos (<--- Italian 'Illy' espresso)

[sicarie]

You should try a different brand of coffee ;-)

kind regards,

Jos (<--- Italian 'Illy' espresso)

Yeah, I'm used to my wife's coffee. She's a nurse, and when people like that work 12 hour shifts, they tend to make it very very strong. Then I come to work and I'm drinking 3 cups and just starting to feel awake... (Hence the attempt at cutting back)

[d0ugg]

So,
I did what you told me

for(i=0;i<roll;i++)
    {    
        diceA = rolldie();
        diceB = rolldie();
        totals += diceA + diceB;
    }
 

But not it seems that is running, but it's not printing anything.
And I also put the int totals out of the loop..

Any ideas why is not printing the percentage?

Thank you so much for the help,

Doug