Dynamic arrays

[Rick]

Hi,

I'm trying to use a dynamic array but for some reason it won't work. This is
my code :

int *test;
int numElements = 2;

test = (int *) malloc (numElements * sizeof(int));
if (test= NULL) printf("Can't allocate\n"); // Nothing happens here
so it's ok I guess
test[0] = 10; // <- CRASH!
printf( "test= %d\n",test[0] );

I copied it from the internet and it seems that they all do it this way?
Then why won't this work? My computer sure has enough for 2 integers...

Greetings,
Rick

[Jirka Klaue]

Rick wrote:

I'm trying to use a dynamic array but for some reason it won't work. This is
my code :

int *test;
int numElements = 2;

test = (int *) malloc (numElements * sizeof(int));
if (test= NULL) printf("Can't allocate\n"); // Nothing happens here

^
Hur, hur!

You want ==.

Jirka

[Irrwahn Grausewitz]

"Rick" <as******@hotma il.com> wrote:

Hi,

I'm trying to use a dynamic array but for some reason it won't work. This is
my code :
It's certainly not, it won't even compile.

#include <stdio.h>
#include <stdlib.h>

int main(void)
{ int *test;
int numElements = 2;

test = (int *) malloc (numElements * sizeof(int)); ^ spurious cast, you'd better write:

test = malloc ( numElements * sizeof *test );
if (test= NULL) printf("Can't allocate\n"); // Nothing happens here ^ you assign NULL to test here
so it's ok I guess No, you want:

if ( test == NULL )
{
printf("Can't allocate\n");
return EXIT_FAILURE;
}
test[0] = 10; // <- CRASH!
It's not surprising for NULL[0] = 10; to crash. You invoked undefined
behaviour.
printf( "test= %d\n",test[0] );
return EXIT_SUCCESS;
}
I copied it from the internet and it seems that they all do it this way? No, fortunately not.
Then why won't this work? My computer sure has enough for 2 integers...

See above.

HTH
Regards
--
Irrwahn
(ir*******@free net.de)

[sellountos euripides]

Jirka Klaue wrote:

Rick wrote:

I'm trying to use a dynamic array but for some reason it won't work.
This is
my code :

int *test;
int numElements = 2;

test = (int *) malloc (numElements * sizeof(int));
if (test= NULL) printf("Can't allocate\n"); // Nothing happens here

^
Hur, hur!

You want ==.

To OP.
That's why many programmers prefer to write:
if (NULL==test) {
/* ... */
}
To catch the error at compile time.

e.j.s.

--
The white zone is for loading and unloading only.
(Frank Zappa)

[Rick]

Ok, ok, I quickly typed it over. ( s = NULL ) is stupid indeed but in the
real code there are really 2 == :) And no, although there's a bug it does
compile. But look, an exact copy now :

int *da;
int numElements = 2;

da = (int *) malloc (numElements * sizeof(int));
if (da== NULL) printf("damn\n" );
da[0] = 10; // The same problem
printf( "test= %d\n",da[0] );

Also tried without the == null line, just for sure, but it doesn't work
neither. I also tried it without (int *)but it keeps crashing.

Greetings,
Rick

[Al Bowers]

Rick wrote:

Ok, ok, I quickly typed it over. ( s = NULL ) is stupid indeed but in the
real code there are really 2 == :) And no, although there's a bug it does
compile. But look, an exact copy now :

int *da;
int numElements = 2;

da = (int *) malloc (numElements * sizeof(int));
if (da== NULL) printf("damn\n" );
da[0] = 10; // The same problem
printf( "test= %d\n",da[0] );

Also tried without the == null line, just for sure, but it doesn't work
neither. I also tried it without (int *)but it keeps crashing.

You have a flaw. You should not simply print a message
if the allocation failed and then continue on as if it was
successful. You need and if-else or an exit.

Try this and see if this crashes:

#include <stdio.h>
#include <stdlib.h>

int main(void)
{
int *da;
int numElements = 2;

da = malloc(numEleme nts * sizeof(int));
if (da == NULL) printf("damn\n" );
else
{
da[0] = 10;
printf( "test= %d\n",da[0] );
free(da);
}
return 0;
}

--
Al Bowers
Tampa, Fl USA
mailto: xa******@myrapi dsys.com (remove the x to send email)
http://www.geocities.com/abowers822/

[Rick]

Very True, but it doesn't solve the problem...

Greetings,
Rick

[Alex]

"sellountos euripides" <se********@mec h.upatras.gr> wrote in message
news:bn******** **@nic.grnet.gr ...

if (test= NULL) printf("Can't allocate\n");

^
Hur, hur!

You want ==.

To OP.
That's why many programmers prefer to write:
if (NULL==test) {
/* ... */
}
To catch the error at compile time.

I prefer to increase the warning level from my compiler, which also sets off
an alarm bell in this type of situation:

int i, j;
/* ... */
if (i = /* whoops! */ j) { /* ... */ }

Alex

[Rick]

Ow, Al, I tried you code (thanks for that) in the main but it still crashes.
What the heck is going on? Even my drunken brain can store 2 integers. It's
just a normal pc. Maybe it are some settings in the old Borland C++??

Greetings,
Rick

[Rick]

Wait! I talk too fast. It does work now, after including #include <stdlib.h>
as well. Are their more versions of malloc or something? The compiler didn't
say anything.

Thanks!
Rick