can't open file in constructor

[nickyeng]

i have main program, which user key in the filename in command line argument.
i pass the argument to another class constructor to handle it.
I have the filename correct, but it still give me "can't open terrain file" message.
here is my code:

                        Constructor(char* filename =""){
                ifstream terrainfile;
 
                terrainfile.open(filename, ios::in);
 
                if(terrainfile.is_open()){
                    if(!terrainfile.eof()){
 
                        // bla bla bla 
                    }
                }else{
                    cout << "Can't open terrain file." << endl;
                    exit(1);
                    terrainfile.close();
                }
                       }
 

[nickyeng]

i called the class like this and pass the argument:

Constructor co(argv[1]);      // argv[1] is command line argument 
 

[horace1]

i called the class like this and pass the argument:

Constructor co(argv[1]);      // argv[1] is command line argument 
 

code looks OK - print value of filename in constructor to check it is OK
are you sure you got the absolute or relative path to the file correct

[nickyeng]

code looks OK - print value of filename in constructor to check it is OK
are you sure you got the absolute or relative path to the file correct

the path to the file is correct.

If i move away the ELSE part, it will print the content of the file.
But i have to put the else part because i want when user type the wrong filename it will give a error message.

Once i put the else part, it will cout the error message,
Once i move away else part, it cout the content of that file well.

so weird...

Thanks for helping.
Nick

[nickyeng]

Now i try it this way:
i coded the command line argument comparison first in main program, if it command line argument is equal to "terrain.tx t", then error message, else it will continue the next coding line and then go to class constructor by taking command line argument. In post 1, it shown.
here is the code:

int main(int argc, char* argv[]){
 
        switch(argc){
            case 1:
                cout << "Usage: game terrain file" << endl;
                exit(1);
                break;
            case 2:
                if(argv[1] != "terrain.txt"){
                    cout << "Can't open terrain file" << endl;
                    exit(1);
                }
                break;
        }
                  //.....
                 //....Constructor cons(argv[1]);
                 //....
}