String.Replace not working???

[BBM]

This is so bizarre I hesitate to post it, but I need to get this working.

My code looks like this...

Private Const cmdTestResource sSel = "SELECT * FROM TResources" & _
" WHERE Scenario =
@Scenario"
Dim cmdstr as String

cmdstr = cmdTestResource sSel
If history Then
cmdstr.Replace( "TResources ", "TResourcesHist ory")
End If
Dim cmdS As SqlCommand = New SqlCommand(cmds tr, cnTest)

History is true. Coming out of the "if" statement, cmdstr is unchanged.
CommandText of the SQLCommand contains "TResources " not "TResourcesHist ory"
This same code template works in the same program in about a dozen other
places. No exceptions thrown. I can do the replace on cmdstr in the
command window while debugging the app and it works fine.

What's up with this???

Thanks for your help.

BBM

[Jay B. Harlow [MVP - Outlook]]

BBM,
StringBuilder!

StringBuilder is an example where it would be problematic.

All the methods on StringBuilder return "me" so as you can chain calls to
the methods, such as:

Dim sb As New System.Text.Str ingBuilder("ABA ABBAA")

sb.Replace("A", "0").Replace("B ", "1")

Or most people simply use:

sb.Replace("A", "0")
sb.Replace("B", "1")

If there was a warning or error, all the StringBuilder methods would have a
problem.

I can see "builders" returning "me" from all the methods so that you can
chain them as above.

Hope this helps
Jay

"BBM" <bb*@bbmcompany .com> wrote in message
news:7C******** *************** ***********@mic rosoft.com...
| You're right. I was in a hurry and missed the fact that string.replace is
a
| function.
|
| However, I've never understood why VB.Net allows you to do this (use a
| function without requiring you assign it to something). In 1986 Turbo
Pascal
| could catch this. There's no reason for something to be a function unless
| the return value is useful.
|
| I was lucky enough to catch my error in test. I'll bet there's about a
| billion occurences of errors similar to mine in production code.
|
| Thanks again for your help and prompt response.
|
| BBM
|
| "Marina" wrote:
|
| > Replace does not modify the original string. It returns a new one with
the
| > replacements.
| >
| > Meaning, you have to assign the return of Replace to a variable. This is
| > well documented.
| >
| > "BBM" <bb*@bbmcompany .com> wrote in message
| > news:35******** *************** ***********@mic rosoft.com...
| > > This is so bizarre I hesitate to post it, but I need to get this
working.
| > >
| > > My code looks like this...
| > >
| > > Private Const cmdTestResource sSel = "SELECT * FROM TResources" & _
| > > " WHERE Scenario =
| > > @Scenario"
| > > Dim cmdstr as String
| > >
| > > cmdstr = cmdTestResource sSel
| > > If history Then
| > > cmdstr.Replace( "TResources ", "TResourcesHist ory")
| > > End If
| > > Dim cmdS As SqlCommand = New SqlCommand(cmds tr, cnTest)
| > >
| > > History is true. Coming out of the "if" statement, cmdstr is
unchanged.
| > > CommandText of the SQLCommand contains "TResources " not
| > > "TResourcesHist ory"
| > > This same code template works in the same program in about a dozen
other
| > > places. No exceptions thrown. I can do the replace on cmdstr in the
| > > command window while debugging the app and it works fine.
| > >
| > > What's up with this???
| > >
| > > Thanks for your help.
| > >
| > > BBM
| >
| >
| >

[Cor Ligthert [MVP]]

Jay,

In my opinion is stringbuilder not a value however an object.

That should be at least a distinct.

Cor

[Tym]

It is rumoured that on Thu, 4 Aug 2005 10:26:15 -0500, "Jay B. Harlow
[MVP - Outlook]" <Ja************ @msn.com> spake word of wisdom thus:

BBM,
StringBuilde r!

--8<----8<----8<----8<----8<----8<----8<----8<--

Ew!!!! Top posting!! :-P
---
Tym

Please do not adjust your brain, there is a fault with reality

Email - Domain is valid - user is not - I'm sure you can work it out though!

However, there is an agressive spam trap here, so you'll get blacklisted until I
white list you. If you've emailed and asked for a reply and not got one - please
post a message in here and I'll re-check the black hole!

A plague of Jonathan Ross a thousand fold on the spammers!!

[Jay B. Harlow [MVP - Outlook]]

Cor,
String is also an object by virtue String is a Reference Type.

How are you defining "value" verses defining "object"?

Based on most ways I would define value & object, I'm not seeing why being a
value verses being an object would make a real difference here!

Double.TryParse for example, returns False if it was not able to convert the
number, according to the documentation it also sets the result to Zero if it
was not able to convert the number. Simply having the result set to Zero may
be sufficient for my algorithm to work without worrying that TryParse
returned True or False...

For example, I might call it this way:

Dim result As Double
Double.TryParse ("x", ..., result)

As my requirements allow setting result = 0 for invalid input as acceptable,
although I would expect Double.Nan would be a more logical default for
invalid input.

Interesting, it appears that Double.TryParse in .NET 1.1 does not set the
result to zero if it failed, it appears leave the value as is, in which case
I could code it as:

Dim result As Double = Double.Nan
Double.TryParse ("x", ..., result)

Hope this helps
Jay

"Cor Ligthert [MVP]" <no************ @planet.nl> wrote in message
news:%2******** ********@TK2MSF TNGP09.phx.gbl. ..
| Jay,
|
| In my opinion is stringbuilder not a value however an object.
|
| That should be at least a distinct.
|
| Cor
|
|

[Cor Ligthert [MVP]]

Jay,

String is also an object by virtue String is a Reference Type.

I was almost imidiatly making a message when I had sent it.

Because I was expecting this answer from you

:-)

However I decided to wait to make it easier to reply.

The string has so much special ways it is handled in VBNet and is handled
that way, that I in my opinion it is worth to handle it special in the IDE
in this.

Only alone the many problems we have seen in this in this newsgroup would
justify that. It is not changing the behaviour it is adding a warning.

Cor

[BBM]

Add me to the list. Functions exist to return values. Having the language
allow cmdstr.replace( "X", "Y") is the equivalent of allowing "+=2" as a valid
line (maybe this works? I haven't tried).

Thanks again

"Cor Ligthert [MVP]" wrote:

BBM,

This newsgroup is full of complaints that this is possible expressly by
Herfried.

Cor

[Jay B. Harlow [MVP - Outlook]]

Cor,
| The string has so much special ways it is handled in VBNet and is handled
| that way, that I in my opinion it is worth to handle it special in the IDE
| in this.
Special case errors based on a variable being a String, IMHO is too special
case.

What happens when the next BBM calls function X on his class & nothing
happens, as function X on his class returns a new instance rather then
modifying the target object?

A more generalized approach (such as an Attribute) that would indicate that
the return value of a Function is "important" and should be dealt with (such
as String.Replace) or the return value of a Function is "informatio nal" and
can be safely ignored (such as StringBuilder.R eplace).

By "important" I mean that ignoring the return value may result in loss of
"data", as in the String.Replace case.

Of course then how do you categorize functions such as DataAdapter.Fil l that
returns the number of rows effected. The above attribute might need to have
some form of Level such as None, Warn, Error...

Where StringBuilder.R eplace would be set to None as it would be safe to
ignore the return value.

DataAdapter.Fil l would be set to Warn, as the value can be important, but
not that important.

String.Replace would be set to Error, as the value is required & ignoring it
would result in "data loss".

I would probably treat no attribute as None.

Jay

Hope this helps
Jay

"Cor Ligthert [MVP]" <no************ @planet.nl> wrote in message
news:Ot******** ******@TK2MSFTN GP09.phx.gbl...
| Jay,
|
| > String is also an object by virtue String is a Reference Type.
| >
|
| I was almost imidiatly making a message when I had sent it.
|
| Because I was expecting this answer from you
|
| :-)
|
| However I decided to wait to make it easier to reply.
|
| The string has so much special ways it is handled in VBNet and is handled
| that way, that I in my opinion it is worth to handle it special in the IDE
| in this.
|
| Only alone the many problems we have seen in this in this newsgroup would
| justify that. It is not changing the behaviour it is adding a warning.
|
| Cor
|
|
|