PHP Form Mailer Problems

[Michael117]

Hey guys,

I'm pretty new here and I need some help. What I want to do is very easy. I have a webpage (<Link removed>) that has a form on it and I want the information that is submitted on the form to be sent to my email and I want the user that clicked submit to be taken to a thankyou page (<Link removed>)

I have the form already created I just need you guys to double check these two certain parts of it. (the whole form is located on <Link removed>)

<form action="feedback.php" method="post">
 
<input value="Submit" name="B1" type="submit">
 

Here is the feedback.php file that I am using that apparantly has some flaws in it. (Sorry it is kinda squished)

<?
///////////////////////////////////////////////////////////////////
// PERFECT                                                       //
// -------                                                       //
// PHP E-mail Receive Form Electronic Content Text               //
// File: feedback.php                                            //
// Version: 1.6 (April 2, 2005)                                  //
// Description: Processes a web form to read the user input and  //
//    then send the data to a predefined recipient.  You are     //
//    free to use and modify this script as you like.            //
// Instructions:  Go to "<Link removed>".          //
//                                                               //
// Center Key Software  *  <Link removed>  *  Dem Pilafian    //
///////////////////////////////////////////////////////////////////
 
// Configuration Settings
$SendFrom =    "Michael Alexander <<Email removed>>";
$SendTo =      "<Email removed>";
$SubjectLine = "Feedback Submission";
$ThanksURL =   "<Link removed>";  //confirmation page
$Divider =     "~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~";
 
// Build Message Body from Web Form Input
$MsgBody = @gethostbyaddr($_SERVER["REMOTE_ADDR"]) . "\n$Divider\n";
foreach ($_POST as $Field=>$Value)
   $MsgBody .= "$Field: $Value\n";
$MsgBody .= "$Divider\n" . $_SERVER["HTTP_USER_AGENT"] . "\n";
$MsgBody = htmlspecialchars($MsgBody);  //make content safe
 
// Send E-Mail and Direct Browser to Confirmation Page
mail($SendTo, $SubjectLine, $MsgBody, "From: $SendFrom");
header("Location: <Link removed>");
?>
 

I'm sure it is a quick and easy fix and that I'll be embarrased when it's all said and done with but thanks in advance for the help.

[Atli]

Hi Michael. Welcome to The Scripts!

I'm not sure what the problem with your code is?
Could you explain exactly what is wrong in your code?
Are you getting any errors?

P.S.
I have removed several links and emails from your post.

Posting links to a site that is in competition with TSDN, that contains advertisement or any other inappropriate content is a violation of the Postin Guidelines, specifically the part about Things that are generally unacceptable.

We do not allow posting of emails (yours or others) in the public forums. This is mainly for your security, as it will most likely be picked up by spammers if you leave it laying around a public forum.

Lastly, please enclose your posted code in [code] tags (See How to Ask a Question).

Moderator

[Michael117]

Hey Atli,

Thanks for the quick reply and for editing my post, I should have been more careful when posting.
Alright so basically my problem is that whenever I fill out the information for the form on my webpage and click submit it doesn’t do anything, it doesn’t even send me to an error 404 page or anything. It doesn't send me an email with the form information or send you to the thankyou page.
What I think I did wrong was filling in the field values for the php file
(ex: $SendFrom). Here is the code for the php file.

1.    <?
2.    ///////////////////////////////////////////////////////////////////
3.    // PERFECT                                                       //
4.    // -------                                                       //
5.    // PHP E-mail Receive Form Electronic Content Text               //
6.    // File: feedback.php                                            //
7.    // Version: 1.6 (April 2, 2005)                                  //
8.    // Description: Processes a web form to read the user input and  //
9.    //    then send the data to a predefined recipient.  You are     //
10.    //    free to use and modify this script as you like.            //
11.    // Instructions:  Go to "<Link removed>".          //
12.    //                                                               //
13.    // Center Key Software  *  <Link removed>  *  Dem Pilafian    //
14.    ///////////////////////////////////////////////////////////////////
15.     
16.    // Configuration Settings
17.    $SendFrom =    "Michael Alexander <[e-mail]>";
18.    $SendTo =      "<[e-mail]>";
19.    $SubjectLine = "Feedback Submission";
20.    $ThanksURL =   "<http://www.mydomain/thankyou.html>";  //confirmation page
21.    $Divider =     "~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~";
22.     
23.    // Build Message Body from Web Form Input
24.    $MsgBody = @gethostbyaddr($_SERVER["REMOTE_ADDR"]) . "\n$Divider\n";
25.    foreach ($_POST as $Field=>$Value)
26.       $MsgBody .= "$Field: $Value\n";
27.    $MsgBody .= "$Divider\n" . $_SERVER["HTTP_USER_AGENT"] . "\n";
28.    $MsgBody = htmlspecialchars($MsgBody);  //make content safe
29.     
30.    // Send E-Mail and Direct Browser to Confirmation Page
31.    mail($SendTo, $SubjectLine, $MsgBody, "From: $SendFrom");
32.    header("Location: <http://www.mydomain.com/thankyou.html>");
33.    ?>
 

I could have also put the wrong information into this code as well. This is just two code snipets from my form. I espescially don't know if the "B1" part is right.

<form action="feedback.php" method="post">
<input value="Submit" name="B1" type="submit">
 

I have both the php file and the form file saved in the same folder and uploaded to a host that supports php4.1.

[Atli]

The form looks all right, except that you are missing the </form> closing tag, but I suspect thats because you are only showing us a part of the form.

You should be redirected to the feedback.php page when you click the button. If that isn't happening there is something else going on in the submission page.

If you are getting redirected, but shown noting, make sure the debug messages are tuned on. Also, try changing <?... ?> to <?php ... ?>. The former only works on servers that have been specially configured to work that way. I'd recommend against using the short tag version, it can cause problems in the future.

Also, if there is anything added to the response before you call the header() function, it will not work. Even if it is only a whitespace before the <?php tag.

[Michael117]

“You should be redirected to the feedback.php page when you click the button. If that isn't happening there is something else going on in the submission page.”

I didn’t quite understand what you meant by this. Are you saying whenever I fill out the form and click submit because I thought that the php file’s whole purpose was to tell the form what to do.

I changed the <?...?> to <?php...?>

I tried the debug message thing and it didn’t change anything, whenever I click on the submit button it still doesn’t take me anywhere or send any email. I am pretty sure I entered this part of it wrong though so that could be it.

mysql_query($query, $link_id) or die('<hr />MySQL Error: ' .mysql_error(). '<hr />');
 

Here is where I entered that debug code

<?php
error_reporting(E_ALL); 
ini_set('display_errors', True);
 
mysql_query($query, $link_id) or die('<hr />MySQL Error: ' .mysql_error(). '<hr />');
 
 
///////////////////////////////////////////////////////////////////
// PERFECT                                                       //
// -------                                                       //
// PHP E-mail Receive Form Electronic Content Text               //
// File: feedback.php                                            //
// Version: 1.6 (April 2, 2005)                                  //
// Description: Processes a web form to read the user input and  //
//    then send the data to a predefined recipient.  You are     //
//    free to use and modify this script as you like.            //
// Instructions:  Go to "http://www.centerkey.com/php".          //
//                                                               //
// Center Key Software  *  www.centerkey.com  *  Dem Pilafian    //
///////////////////////////////////////////////////////////////////
 
// Configuration Settings
$SendFrom =    "Michael Alexander <[e-mail]>";
$SendTo =      "[e-mail]";
$SubjectLine = "Feedback Submission";
$ThanksURL =   "http://www.mydomain.com/thankyou.html";  //confirmation page
$Divider =     "~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~";
 
// Build Message Body from Web Form Input
$MsgBody = @gethostbyaddr($_SERVER["REMOTE_ADDR"]) . "\n$Divider\n";
foreach ($_POST as $Field=>$Value)
   $MsgBody .= "$Field: $Value\n";
$MsgBody .= "$Divider\n" . $_SERVER["HTTP_USER_AGENT"] . "\n";
$MsgBody = htmlspecialchars($MsgBody);  //make content safe
 
// Send E-Mail and Direct Browser to Confirmation Page
mail($SendTo, $SubjectLine, $MsgBody, "From: Michael Alexander <[e-mail]>");
header("Location: http://www.mydomain.com/thankyou.html/");
?>
 

[Atli]

I didn’t quite understand what you meant by this. Are you saying whenever I fill out the form and click submit because I thought that the php file’s whole purpose was to tell the form what to do.

Not exactly, but I can see where your coming from.

When you submit a form, your browser, along with the form data, is redirected over to the page you define in the action property of the <form> element. In your case feedback.php. There your PHP code is executed and is able to read the form data.
No matter how the feedback.php code is working, you should be redirected to that page.

If you are still on the submission page after hitting the 'submit' button, your form is not working the way it should be, which would indicate a problem with the submission page rather than the feedback page.

So maybe we should take a closer look at the submission page.

[Michael117]

Ok gotcha,

Well here is the url for my submission page, <Link removed>

I don't know if this helps or not but I typed in <Link removed>, and I went to a page that had this.

Notice: Undefined variable: query in /home/content/m/i/c/michael117/html/feedback.php on line 5

Notice: Undefined variable: link_id in /home/content/m/i/c/michael117/html/feedback.php on line 5

Warning: mysql_query(): supplied argument is not a valid MySQL-Link resource in /home/content/m/i/c/michael117/html/feedback.php on line 5

--------------------------------------------------------------------------------
MySQL Error:


And here is the full source code for the form on my submission page

 <table>
 
        <tbody>
 
          <tr>
 
            <td colspan="2">
        <form action="feedback.php" method="post">              
        <center></center>
 
            </form>
 
            </td>
 
          </tr>
 
          <tr>
 
            <td>Name:</td>
 
            <td><input name="name"></td>
 
          </tr>
 
          <tr>
 
            <td>Email:</td>
 
            <td><input name="from"></td>
 
          </tr>
 
          <tr>
 
            <td>Phone:</td>
 
            <td><input name="custom Phone"></td>
 
          </tr>
 
          <tr>
 
            <td>Company:</td>
 
            <td><input name="custom Company"></td>
 
          </tr>
 
          <tr>
 
            <td>Advertising Type:</td>
 
            <td>
            <select name="custom Advertising Type">
            <option value="Select One" selected="selected">Select
One</option>
            <option value="Banner">Banner</option>
            <option value="Text Ad">Text Ad</option>
            </select>
 
            </td>
 
          </tr>
 
          <tr>
 
            <td>Period:</td>
 
            <td>
            <select name="custom Period">
            <option value="Select One" selected="selected">Select
One</option>
            <option value="One Week">One Week</option>
            <option value="Two Weeks">Two Weeks</option>
            <option value="One Month">One Month</option>
            <option value="Three Months">Three Months</option>
            <option value="Six Months">Six Months</option>
            <option value="One Year">One Year</option>
            </select>
 
            </td>
 
          </tr>
 
          <tr>
 
            <td valign="top">Comments:</td>
 
            <td><textarea name="custom Comments" rows="10" cols="30"></textarea></td>
 
          </tr>
 
          <tr>
 
        <td colspan="2" align="center"><input value="Submit" name="B1" type="submit"></td>
 
        </tr>
 
        </tbody>
      </table>
 

ps - Thanks for being helpful so far I really appreciate it.

[helraizer1]

With any variables on the php page, have you assigned/defined them?

For example:

<?php
$example = $HTTP_POST_VARS['example'];
$seewhatImean = $HTTP_POST_VARS['see']
?>
 

etc... At the moment the php file doesn't seem to be using anything from the Submission's page, unless you have made the variables with different names that we can't see..

The warning messages say the error is in the code you entered to debug the SQL, but since you don't have and MySQL in your php the variables in the debugger are undefined. If you get rid of the MySQL debugger those messages will go away.

[Atli]

Yep, there is the problem.

Take a look at the <form> elements. This is how they are in your code:

<form action="feedback.php" method="post">             
        <center></center>
 
            </form>
 

You are closing the form before you add any <input> elements into it. The <input> elements should be inside the <form>.. </form> tags.

As it is, the submit button does not belong to a <form>, so naturally it will do nothing when you click it.

P.S. The links still violate the posting guidelines so I removed them :)

With any variables on the php page, have you assigned/defined them?

For example:

<?php
$example = $HTTP_POST_VARS['example'];
$seewhatImean = $HTTP_POST_VARS['see']
?>
 

etc... At the moment the php file doesn't seem to be using anything from the Submission's page, unless you have made the variables with different names that we can't see..

The warning messages say the error is in the code you entered to debug the SQL, but since you don't have and MySQL in your php the variables in the debugger are undefined. If you get rid of the MySQL debugger those messages will go away.

He does use it:

foreach ($_POST as $Field=>$Value)
   $MsgBody .= "$Field: $Value\n";
 

The $HTTP_POST_VARS array is a relic used before PHP4. It has been kept around this long only to assure backwards compatibility. If I am not mistaken, support for this will be removed in PHP6 (correct me if I'm wrong tho).
Use $_POST instead.

[Michael117]

YES!

It works now!

I knew it would some simple little fix and it was (the <form>...</form> tag was the problem. I put it down after the submit button script and now everything works.


Thank you for all your help guys and have a great day.

[Atli]

I'm glad you got it working! :)
Don't hesitate to post again if you have any more questions or problems we can help with.