PHP script

[matheussousuke]

May someone help me correct this script? there a few ' and " and ; in the wrong places:

<?php
include "./comm.inc"; 
connectdb(); 
$sql = "SELECT imgid,imgtype FROM tblimage ORDER BY imgid";  
 
$result = @mysql_query($sql) or die(mysql_error());  
 
echo '<table border=1>n';  
echo '<tr><th>imgid</th><th>imgtype</th><th>imgdata</th></tr>n';  
while ($rs=mysql_fetch_array($result)) {  
  echo '<tr><td>.$rs[0].</td>';  
  echo '<td>.$rs[1].</td>';  
  echo '<td><img src="post.php?imgid=.$rs[0]."" width=100 height=100></td></tr>n';  
echo '</table>n';  
 
?>
 
 
 
 
 
 

[matheussousuke]

I'll post here the other two codes:

post.php -->

<?  
if (!isset($submit)) {  
?>  
<form method="POST" action="" enctype=multipart/form-data>  
<table>  
<tr><td>Type</td><td><select name="imgtype"><option value="image/gif">GIF</option><option  
value="image/jpeg">JPEG</option></select></td></tr>  
<tr><td>File</td><td><input type="file" name="imgfile"></td></tr>  
<tr><td></td><td><input type="submit" name="submit" value="upload"><input type="reset" value="reset"></td></tr>  
</table>  
</form>  
<?  
} else {  
        include "./comm.inc"; 
        connectdb(); 
        $hndl=fopen($imgfile,"rb");  
        $imgdata=''; 
        while(!feof($hndl)){ 
                $imgdata.=fread($hndl,2048);  
        } 
 
{
        $imgdata=addslashes($imgdata);  
 
        $sql = 'INSERT INTO tblimage VALUES(NULL,". $imgtype .",". $imgdata .")';  
 
        @mysql_query($sql) or die(mysql_error());  
 
        fclose($hndl);  
 
        echo '<a href="view.php">view image</a>';  
}  
?> 
 
 

And




upload.php -->

<?php
if (!isset($submit)) {
?>
<form method="POST" action="" enctype=multipart/form-data>
<table>
<tr><td>Tipo</td><td><select name="imgtype"><option value="image/gif">GIF</option><option
value="image/jpeg">JPEG</option></select></td></tr>
<tr><td>File</td><td><input type="file" name="imgfile"></td></tr>
<tr><td></td><td><input type="submit" name="submit" value="upload"><input type="reset" value="reset"></td></tr>
</table>
</form>
<?
} else {
        include "./comm.inc";
        connectdb();
        $hndl=fopen($imgfile,"rb");
        $imgdata='';
        while(!feof($hndl)){
                $imgdata.=fread($hndl,2048);
        }
 
        $imgdata=addslashes($imgdata);
 
        $sql = 'INSERT INTO tblimage VALUES(NULL,", $imgtype .",". $imgdata .")';
 
        @mysql_query($sql) or die(mysql_error());
 
        fclose($hndl);
        echo '<a href="view.php">view image</a>';
}
?>

[code green]

This is a rather tiresome task you have set.
Do you think it is fair to expect people to trail through your code looking for syntax errors.
If you put some debugging in your code you might help yourself to find the problem

[matheussousuke]

sorry, I just though....

[matheussousuke]

whell, I fexed a little things in view.php, and upload.php is correct, maybe the trouble is just in post, and dont get any error using the scripts, that's the problem but the image doesnt appear when I open view.php

[matheussousuke]

I'll post a photo here

[matheussousuke]

This is how it appears on the browser:

And this is how I left view.php:

<?php
include "./comm.inc"; 
connectdb(); 
$sql = "SELECT imgid,imgtype FROM tblimage ORDER BY imgid";  
 
$result = @mysql_query($sql) or die(mysql_error());  
{
echo '<table border=1>n';  
echo '<tr><th>imgid</th><th>imgtype</th><th>imgdata</th></tr>n';  
while ($rs=mysql_fetch_array($result))
 
  echo '<tr><td>".$rs[0]."</td>';  
  echo '<td>".$rs[1]."</td>';  
  echo '<td><img src="post.php?imgid=.$rs[0]." width=100 height=100></td></tr>n';  
echo '</table>n';
 
 
}
 
?>

[matheussousuke]

True is I'm not getting any bug anymore, but, it just doesn't appears.

[Markus]

Variables are not parsed within single quoted strings. You'll have to concatenate the string or use double quotes:

$name = "Mark";
// Works
echo "My name is $name";
// Also works
echo 'My name is ' . $name;
// Doesn't work: prints "My name is $name"
echo 'My name is $name';
 

Also, in future please provide all error details. Simply asking us to 'look at' something and deduce what is wrong with it simply isn't the proper way to ask a question to a bunch of volunteers.

Mark.

[matheussousuke]

@Markus


Do I have to do that to view.php, post.php, upload.php, or both?