why doesnt my email send?

[luke noob]

This is my script.....

<?php
 
    $to = "[e-mail]";
    $subject = "subject";
 
    //minimum characters allowed in the message box
    $msg_min_chars = "10";
 
    //maximum characters allowed in the message box
    $msg_max_chars = "250";
 
    function validate_form_items()
    {
       global $msg_min_chars, $msg_max_chars;
       $msg_chars = "{".$msg_min_chars.",".$msg_max_chars."}";
 
       $form_items = array(
 
           "name"  => array(
                           "regex" => "/^([a-zA-Z '-]+)$/",
                           "error" => "Name appears to be in inproper format",
                           ),
            "email" => array(
                           "regex" =>
                            "/^[A-Za-z0-9](([_\.\-]?[a-zA-Z0-9]+)*)@([A-Za-z0-9]+)(([\.\-]?[a-zA-Z0-9]+)*)\.([A-Za-z]{2,})$/",
                           "error" => "Please enter a valid email address",
                           ),
           "message" => array(
                           "regex" => "/^.{$msg_chars}$/",
                           "error" => "Your message is either too short or exceeds $msg_max_chars characters",
                           ),
       );
 
       $errors = array();
 
       foreach($form_items as $item_name => $item_props)
       {
           if (!preg_match($item_props["regex"], trim($_POST[$item_name])))
           {
                   $errors[] = $item_props["error"];
           }
       }
 
       return $errors;
    }
 
    function email($from, $to, $subject, $message)
    {
        $headers = "From: ".$from."\r\n";
        $headers .= "Reply-To: ".$from."\r\n";
        $headers .= "Return-Path: ".$from."\r\n";
 
        if (mail($to,$subject,$message,$headers) ) {
            echo "Thank you for your inquiry, Your message has been received. <br>We will get back to you as soon as we can.";
        } else {
            echo "Your message could not be sent at this time. Please try again.";
        }
    }
 
    function print_error($errors)
    {
        foreach($errors as $error)
        {
            echo $error."<br>";
        }
    }
 
    function form_process()
    {    
        global $to, $subject;
 
        $errors = validate_form_items();
 
        if(count($errors) == 0)
        {
            $errors [] = email(trim($_POST["email"]), $to, $subject, $_POST["message"]);
        }
 
        print_error($errors);
    }
 
    form_process();
 
?>
 

My form......

<form id="test" method="post" onsubmit="return false;">
        <table border="0">
               <tr>
                   <td colspan="2">
 
                       <div id="errors">
                               &nbsp;
                       </div>
 
                   </td>
               </tr>
 
               <tr>
                   <td colspan="2">
 
                      <font size="+2"><b>Email Us</b></font>
 
                   </td>
               </tr>
 
               <tr>
                   <td>
                        <b>Name:</b>
 
                        <input type="text" name="name" id="name" size="25" maxlength="20" />
                   </td>
               </tr>
 
               <tr>
                   <td>
                        <b>Email:</b>
 
                        <input type="text" name="email" id="email" size="25" maxlength="35" />
                   </td>
               </tr>
 
               <tr>
                   <td>
                        <b>&nbsp;Message:</b> 
                   </td>
                   <td>
                        <i>(max 250 characters allowed)</i>
                   </td>
               </tr>
               <tr>
                   <td colspan="2">
                        <textarea name="message" id="message" cols="36" rows="10"></textarea>
                   </td>
               </tr>
               <tr>
                   <td colspan="2" align="right">
                        <input type="submit" value="submit" name="submit" onclick="javascript: sendRequest();" />
                   </td>
               </tr>
        </table>
        </form>
 
 

please help

[labmonkey111]

Many things could cause the email not to send, or appear not to send. Are you getting any errors? Does it say its send its but you don't get the email? In anything in the error logs?

A few problems I had when first using the mail() function was that php.ini needed to use the full path to sendmail, the message text needs each line to be less than 70 characters long, and of course, my spam filter kicked it every time. Giving more detail should help us figure out your problem.

I just noticed this line

<form id="test" method="post" onsubmit="return false;">

Why are you doing a "return false"? That will cause the form not to submit at all, which could be your whole problem right there.

[gopan]

Dear labmonkey111 ,
luke noob is using a javascript to send the form...
And php mail( ) does not require the path to send mail. i think you thought of perl mail( ).

Dear luke noob,
First of all your sendRequest( ) function is not given in the code... I'm assuming its having a basic validation and submit code (line#52 in form code)

In your mail function php code try the code below at line#53

        $sent = @mail($to,$subject,$message,$headers);
 
        if ($sent ) {
            echo "Thank you for your inquiry, Your message has been received. <br>We will get back to you as soon as we can.";
        } else {
            echo "Your message could not be sent at this time. Please try again.";
        }
 

coz I encounter not sending mail if my code mail() in a if condition.. dunno the reason why.

You may also check if the mail function fails for real thru

      mail($to,$subject,$message,$headers) or die("Mail function failed");
 

Try this...

[luke noob]

Thanks for the reply, i have used a bit of ajax that is not shown here it is

<style>
        #errors
        {
 
            font-size:14px;
            font-weight:normal;
            margin:0px;
            padding:0px;
        }
    </style>
 
    <script type="text/javascript" src="js/prototype.js"></script>
    <script type="text/javascript">
 
    function sendRequest() {
 
        new Ajax.Request("email_form_process.php", {
               method: 'post',
               postBody: "name="+$F("name")+"&email="+$F("email")+"&message="+$F("message"),
               onComplete: showResponse
 
        });
    }
 
 
    function showResponse(req)
    {
       $('errors').style.borderStyle= "solid";
 
       var res=/message was received/;
 
       if(req.responseText.match(res))
       {
        $('errors').style.borderColor= "green";
        $('errors').style.color="green";
       }else{
        $('errors').style.borderColor= "red";
        $('errors').style.color="red";
       }
 
       $('errors').style.borderSize= "1px";
       $('errors').innerHTML=  req.responseText;
    }
 
    </script>
 

i tryed again today and it works. For some reason it didnt yesterday,

i have another problem though, i have an input feild for the name to be enterd, but when i post it to my email address the name does not show there, i have tryed to edit this to work but its not working still, could you give me some advice please. my input for the name, is "name" but im not sure where to edit my script.

[gopan]

ooh...
check your first code php script line#49

$headers = "From: ".$from."\r\n";
 

to

$headers = "From: ".$name." <".$from.">\r\n";
 

then you will get name of the sender...
Hope this will help...

[luke noob]

Perfect thank you, I last thing...

Is it possible to sent to two different email addresses at the same time, by changing line 3, somehow

 
$to = "[e-mail]";
 

itz not a serious thing but it would make life a bit easier.

[Dheeraj Joshi]

I think you can have $to as an array...

Regards
Dheeraj Joshi

[gopan]

@dheerajjoshim
No dear... php mail function can mail to multiple recipients by giving all the addresses as a coma seperated string... thats all...

    $to = "[e-mail], [e-mail], [e-mail]";
 

[luke noob]

Thank you this helps alot.

[Dheeraj Joshi]

Thanks for the info Gopan..

I did not know that..


Regards
Dheeraj Joshi