Assigning variables in if's

[jodleren]

Hi!

In while (false !== ($file = readdir($handle )))

what happens?
The $file gets assigned, and the value of that is compared with false?
The assignment is being compared with false

Say, I want to return true or an error code. Can I do;

if($err = somefunc())
echo "ok"
else
echo "error: $err";

WBR
Sonnich

[taps128]

Jerry Stuckle wrote:

taps128 wrote:

>Toby A Inkster wrote:

>>jodleren wrote:

$err = somefunc();
if($err===tr ue)
echo "ok"
else
echo "error: $err";

echo (true === ($err = somefunc())) ? 'ok' : "error: $err";

:-)

or more readable(to me) IMHO
$err=foo();
switch($err) {
case true: echo 'ok';break;
case false: echo 'error: '.$err;
}

But of course thats just a matter of style.

More than a matter of style. If the function returns '1', your way will
print 'ok', while Toby's function will return the more correct 'error: 1'.

You right, i missed those '==='

[Michael]

Gordon wrote:

On Nov 29, 1:22 pm, Toby A Inkster <usenet200...@t obyinkster.co.u k>
wrote:

>taps128 wrote:

>>or more readable(to me)

Readable perhaps, but boring. echo (true === ($err = somefunc())) ? 'ok' :
"error: $err"; is fun. It invites the reader to explore its mysteries; to
embark in a journey of discovery, a quest filled with a sense of awe and
wonder. And in a sense it helps the reader to uncover new things about
*themselves* and unfold the secrets of their very souls.

Plus it saves almost 30 bytes.

--
Toby A Inkster BSc (Hons) ARCS
[Geek of HTML/SQL/Perl/PHP/Python/Apache/Linux]
[OS: Linux 2.6.17.14-mm-desktop-9mdvsmp, up 4 days, 20:07.]
[Now Playing: Keane - On a Day like Today]

Sharing Music with Apple iTunes
http://tobyinkster.co.uk/blog/2007/1...tunes-sharing/

And is completely contrary to the principles of writing maintainable
code. :) What code does should be self-evident, or at least self-
explanatory and well commented, because the poor sod who has to look
at the code in 18 months time to figure out why it's not behaving as
intended might be you.

The ternary operator should not be 'confusing' to any competent PHP
programmer. Don't just leave out the parts that "Aren't your style".
Because you will come unstuck one day, when you don't understand
something that is normal and quite common.

besides,
echo(true===$e= somefunc())?'ok ':"error: $e";

saves even more bytes ;)

- Michael

[Tim Roberts]

Toby A Inkster <us**********@t obyinkster.co.u kwrote:

>
Readable perhaps, but boring. echo (true === ($err = somefunc())) ? 'ok' :
"error: $err"; is fun. It invites the reader to explore its mysteries; to
embark in a journey of discovery, a quest filled with a sense of awe and
wonder. And in a sense it helps the reader to uncover new things about
*themselves* and unfold the secrets of their very souls.

+1 QOTW

I have to write that down. That has to be both the best and the worst
justification for obfuscated code that I've ever read.
--
Tim Roberts, ti**@probo.com
Providenza & Boekelheide, Inc.