A problem with '"'

[NurAzije]

I have written a code and can't figure what is wrong, the code will
read a content of a file and cut all the emails from it,then echo them,
but I have a problem with '"' charecter I think..
Take a look:
*************** *************
<?php
$url="http://www.bihstudenti .com/kontakt.php";
$lines = file_get_conten ts($url);
$done=explode(" @",$lines);
for($i=0;$i<cou nt($done)+1;$i+ +)
{
$j=$i+1;
$a=strrpos($don e[$i],":");
$b=strrpos($don e[$i],">");
$c=strpos($done[$j],chr(34));
$d=strpos($done[$j],"<");
$front=$done[$i];
$back=$done[$j];
if($a>$b){
if($c<$d){
echo "Line $i
".substr($front ,strrpos($front ,":")+1)."@".su bstr($back,0,st rpos($back,chr( 34)))."<br>";
}else{
echo "Line $i
".substr($front ,strrpos($front ,":")+1)."@".su bstr($back,0,st rpos($back,"<") )."<br>";
}
}else{
if($c<$d){
echo "Line $i
".substr($front ,strrpos($front ,">")+1)."@".su bstr($back,0,st rpos($back,chr( 34)))."<br>";
}else{
echo "Line $i
".substr($front ,strrpos($front ,">")+1)."@".su bstr($back,0,st rpos($back,"<") )."<br>";
}
}
}
?>
*************** *************
I am looking at www.bihstudenti.com/kontakt.php content..
Please help, do any one have a clue what is wrong..

[Ewoud Dronkert]

NurAzije wrote:

read a content of a file and cut all the emails from it,then echo them,

Sorry, can't be bothered to check the code :) but try this:

$data = file_get_conten ts('http://www.bihstudenti .com/kontakt.php');
$match = array();
preg_match_all( '/mailto:([^"]+)">/', $data, $match);
print_r($match[1]);

See http://php.net/preg-match-all

--
E. Dronkert

[NurAzije]

It have succeded for the after mailto: ones, thank you very much, I am
a beginner in PHP, I dont know to play with these '/mailto:([^"]+)">/'
is there some tutorials to lern this about charecters or something..
Thank you...

[Ewoud Dronkert]

NurAzije wrote:

a beginner in PHP, I dont know to play with these '/mailto:([^"]+)">/'

It's a "Regular Expression".
Start at http://php.net/manual/en/ref.pcre.php

--
E. Dronkert

[Iván Sánchez Ortega]

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

NurAzije wrote:

$lines = file_get_conten ts($url);
$done=explode(" @",$lines);

I think here lies your problem. explode() expects its second parameter to be
an string, but you are feeding it an array (file() always returns an
array). As a result of the automatic type casting, $done may be empty
everytime yourun the script.

You can either:
- - Use array_map to apply the explode() function to every element from
$lines, and then array_merge the results,
- - or use file_get_conten ts() instead of file(), that returns a string.

As usual, more information in php.net/manual ...

- --
- ----------------------------------
Iván Sánchez Ortega -i-punto-sanchez--arroba-mirame-punto-net

http://acm.asoc.fi.upm.es/~mr/
Proudly running Debian Linux with 2.6.12-1-686 kernel, KDE3.4.2, and PHP
5.0.5-3 generating this signature.
Uptime: 12:47:15 up 15:50, 2 users, load average: 0.38, 0.43, 0.35

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.2 (GNU/Linux)

iD8DBQFDWhlK3jc Q2mg3Pc8RAsboAJ 9jjcxTe0DLSC4UG hctFISP3ItfBwCf VENu
c+TD9oiDNhjcYxA wYQoo5Qw=
=knA6
-----END PGP SIGNATURE-----

[Iván Sánchez Ortega]

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

NurAzije wrote:

Oh, and, by the way:

for($i=0;$i<cou nt($done)+1;$i+ +)
Always use foreach() to transverse array: it's quite more secure (doesn't
miss any array keys, even if non-numeric) and compact (i.e. readable).

[...] $a=strrpos($don e[$i],":");

Also, if you are not going to use variable expansion (putting a variable
name inside a double-quote-enclosed string), use single quotes instead. It
saves the script a very small little bit of parsing time (that always
helps).

- --
- ----------------------------------
Iván Sánchez Ortega -i-punto-sanchez--arroba-mirame-punto-net

"If you haven't got anything nice to say about anybody, come sit next to
me."
- Alice Roosevelt Longworth (1884-1980)
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.2 (GNU/Linux)

iD8DBQFDWhnT3jc Q2mg3Pc8RAoyYAJ 9ozRD4EwSuHe9lK 3QSUFIe2+ZIiQCf fluZ
/b3Z0xAOSf64CnbG 3z8tFK0=
=SdHn
-----END PGP SIGNATURE-----

[Ewoud Dronkert]

Iván Sánchez Ortega wrote:

NurAzije wrote:

$lines = file_get_conten ts($url);
$done=explode(" @",$lines);

I think here lies your problem. explode() expects its second parameter to be
an string, but you are feeding it an array (file() always returns an
array). [...]
or use file_get_conten ts() instead of file(), that returns a string.

He did!

--
E. Dronkert

[NurAzije]

The expresions way is better, thanks ..
Now I must construct an expression that has an @ at the middle, and ><
at the sides, or spaces or " ", there is a list but the base is the
same ..

[NurAzije]

I am trying to write the expression like this, but something seems
wrong:
preg_match_all( '/(<|:| |").+@.+\....(> | |")/', $data, $match);
as follows :
(<|:| |") -- < or : or space or "
..+ -- any number of any charecters
@ -- is the @ in the email
..+ -- any number of any charecters
\. -- an escape for the dot
.... -- any three characters
(>| |") -- > or space or "

Any help please

[Ewoud Dronkert]

NurAzije wrote:

preg_match_all( '/(<|:| |").+@.+\....(> | |")/', $data, $match);

Greedy/non-greedy problem, I guess. (Also, you should enclose the part
that you *do* want to match in brackets, or the matches won't show up as
separate entries in $match.) Try '/[a-z0-9_.+-]+@[a-z0-9.-]+/i'.

--
E. Dronkert