If statement within an if statement

[Mark]

I am a complete novice with php scrip but I am wiling to learn.
I am in need of some help, please.

Can anyone sort this code out for me so that it works correctly and
adjusts the price for the quantity selected on the front end.
_______________ _______________ _______________ _______________ ___

if(article_get_ field('type')== 'Croclight Candle'){
article_set_fie ld('item_number ', 'CRC');
article_set_fie ld('price', 6.99);
}
elseif(article_ get_field('type ')== 'Spray') {
article_set_fie ld('item_number ', 'CRS');
article_set_fie ld('size', '50ml');
article_set_fie ld('price', 6.99);
}
elseif(article_ get_field('size ')== '15ml') {
article_set_fie ld('item_number ', 'CRS');
article_set_fie ld('type', 'Spray');
article_set_fie ld('price', 2.99);
}
elseif(article_ get_field('type ')== 'Roll-on') {
article_set_fie ld('item_number ', 'CRO');
article_set_fie ld('size', '50ml');
article_set_fie ld('price', 6.99);
}
_______________ _______________ _______________ _______________ ____

Thanks in advance

Mark

[Ken Robinson]

"Mark" <ma************ @ntlworld.com> wrote in
news:11******** **************@ g49g2000cwa.goo glegroups.com:

I am a complete novice with php scrip but I am wiling to learn.
I am in need of some help, please.

Can anyone sort this code out for me so that it works correctly and
adjusts the price for the quantity selected on the front end.
_______________ _______________ _______________ _______________ ___

if(article_get_ field('type')== 'Croclight Candle'){
article_set_fie ld('item_number ', 'CRC');
article_set_fie ld('price', 6.99);
}
elseif(article_ get_field('type ')== 'Spray') {
article_set_fie ld('item_number ', 'CRS');
article_set_fie ld('size', '50ml');
article_set_fie ld('price', 6.99);
}
elseif(article_ get_field('size ')== '15ml') {
article_set_fie ld('item_number ', 'CRS');
article_set_fie ld('type', 'Spray');
article_set_fie ld('price', 2.99);
}
elseif(article_ get_field('type ')== 'Roll-on') {
article_set_fie ld('item_number ', 'CRO');
article_set_fie ld('size', '50ml');
article_set_fie ld('price', 6.99);
}

First suggestion: Avoid elseif's if at all possible. Use the switch()
statement instead. <see http://www.php.net/switch>

switch (article_get_fi eld('type')) {
case 'Croclight Candle':
article_set_fie ld('item_number ', 'CRC');
article_set_fie ld('price', 6.99);
break;
case 'Spray':
article_set_fie ld('item_number ', 'CRS');
article_set_fie ld('size', '50ml');
article_set_fie ld('price', 6.99);
break;
case 'Roll-on':
article_set_fie ld('item_number ', 'CRO');
article_set_fie ld('size', '50ml');
article_set_fie ld('price', 6.99);
break;
}

if(article_get_ field('size') == '15ml') {
article_set_fie ld('item_number ', 'CRS');
article_set_fie ld('type', 'Spray');
article_set_fie ld('price', 2.99);
}

Also, when posting code, try to use indentation so that the different
code blocks can be determined.

Ken

[PHPGB]

<comp.lang.ph p , Ken Robinson , se**********@rb nsn.com>
<1124745948.eba 2d174dc98eac000 e32e39523bcf98@ teranews>
<Mon, 22 Aug 2005 21:25:48 GMT>

First suggestion: Avoid elseif's if at all possible. Use the switch()
statement instead. <see http://www.php.net/switch>

switch (article_get_fi eld('type')) {snip code}

Also, when posting code, try to use indentation so that the different
code blocks can be determined.

That looked a nice bit of code and i've been meaning to learn about
switch() for ages , But i'm the opposite and most of the time I regard
indents as a curse .

if ($poo<>$poo)
{
php code
}

Each to their own .
--
www.phpguestbook.co.uk

[Default User]

PHPGB wrote:

That looked a nice bit of code and i've been meaning to learn about
switch() for ages , But i'm the opposite and most of the time I
regard indents as a curse .

if ($poo<>$poo)
{
php code
}

Each to their own .

You'll find that proper indentation is almost universal amongst
programmers. There's a very good reason for that, having to do with
being able to read, debug, and maintain large code sections.

I recommend strongly that you start doing the same. Many code editors
help you out these days through auto-indenting. Use spaces, not tabs,
especially for posting code to usenet.


Brian

[PHPGB]

<comp.lang.ph p , Default User , de***********@y ahoo.com>
<3n************ *@individual.ne t>
<23 Aug 2005 21:57:29 GMT>

if ($poo<>$poo)
{
php code
}

Each to their own .

You'll find that proper indentation is almost universal amongst
programmers. There's a very good reason for that, having to do with
being able to read, debug, and maintain large code sections.

And if all the other programmers put their hand in the fire you would
want me to do the same would you ? :-)

I've always been in the frame of mind its what suits the person and not
what suits anybody else .
--
www.phpguestbook.co.uk

[Ramon]

Fair enouph, just dont expect assistance from the community then.

PHPGB wrote:

<comp.lang.ph p , Default User , de***********@y ahoo.com>
<3n************ *@individual.ne t>
<23 Aug 2005 21:57:29 GMT>

if ($poo<>$poo)
{
php code
}

Each to their own .

You'll find that proper indentation is almost universal amongst
programmers . There's a very good reason for that, having to do with
being able to read, debug, and maintain large code sections.

And if all the other programmers put their hand in the fire you would
want me to do the same would you ? :-)

I've always been in the frame of mind its what suits the person and not
what suits anybody else .

[Jerry Stuckle]

PHPGB wrote:

<comp.lang.ph p , Default User , de***********@y ahoo.com>
<3n************ *@individual.ne t>
<23 Aug 2005 21:57:29 GMT>

if ($poo<>$poo)
{
php code
}

Each to their own .

You'll find that proper indentation is almost universal amongst
programmers . There's a very good reason for that, having to do with
being able to read, debug, and maintain large code sections.

And if all the other programmers put their hand in the fire you would
want me to do the same would you ? :-)

I've always been in the frame of mind its what suits the person and not
what suits anybody else .

Gee, if all the other programmers were doing it, there must be a reason!

After almost 40 years of programming, I've found indenting is VERY important.
And I second Ramon's opinion - don't expect help from the group - or any other
programmer. And don't expect to ever get a job programming.

--
=============== ===
Remove the "x" from my email address
Jerry Stuckle
JDS Computer Training Corp.
js*******@attgl obal.net
=============== ===

[PHPGB]

<comp.lang.ph p , Jerry Stuckle , js*******@attgl obal.net>
<q5************ ********@comcas t.com>
<Tue, 23 Aug 2005 20:23:49 -0500>

And if all the other programmers put their hand in the fire you would
want me to do the same would you ? :-)

I've always been in the frame of mind its what suits the person and not
what suits anybody else .

Gee, if all the other programmers were doing it, there must be a reason!

After almost 40 years of programming, I've found indenting is VERY important.
And I second Ramon's opinion - don't expect help from the group - or any other
programmer.

Calm down lads .
'don't expect help from the group'

Do you realise what you have just said ? .

Professional programmers acting like foot stomping little children who
wont help a user because they use a different method than their own .
--
www.phpguestbook.co.uk

[Default User]

PHPGB wrote:

<comp.lang.ph p , Default User , de***********@y ahoo.com>
<3n************ *@individual.ne t>
<23 Aug 2005 21:57:29 GMT>

if ($poo<>$poo)
{
php code
}

Each to their own .

You'll find that proper indentation is almost universal amongst
programmers. There's a very good reason for that, having to do with
being able to read, debug, and maintain large code sections.

And if all the other programmers put their hand in the fire you would
want me to do the same would you ? :-)

Why would they? You seem to labor under the delusion that thousands of
professionals don't know what they are doing or would be malicious in
their advice. They do and they wouldn't be.
I've always been in the frame of mind its what suits the person and
not what suits anybody else .

Why do you find it has any benefit?

More importantly, posting unindented code to the newsgroup will cause
at least some people to ignore you.

Brian

[Ramon]

No, this has nothing to do with adolescent tantrums. The reason for the
hostile behavior, is because after being involved in the industry. There
is nothing quite like walking into a new and *exciting* job opportunity,
and then finding that you are responsible for maintaining the code of a
12 year old who was stuck inside a 45 year old's body. Or simply said
was too lazy to comment and indent.

And it takes you 10x the time to interpret what was written as there is
no documentation of any kind (if you are lucky you will get some PHPdoc
crap which isnt of much use either. Oh wait, its even better if you are
a team leader and you are in charge of integration 10 large scale
systems, into one cohesive one. While because 5 out of the 10 systems in
question were written by this same 12 year old.

Still wondering where the hostility stems from? Or did you get the drift?
PHPGB wrote:

<comp.lang.ph p , Jerry Stuckle , js*******@attgl obal.net>
<q5************ ********@comcas t.com>
<Tue, 23 Aug 2005 20:23:49 -0500>

And if all the other programmers put their hand in the fire you would
want me to do the same would you ? :-)

I've always been in the frame of mind its what suits the person and not
what suits anybody else .

Gee, if all the other programmers were doing it, there must be a reason!

After almost 40 years of programming, I've found indenting is VERY important.
And I second Ramon's opinion - don't expect help from the group - or any other
programmer.

Calm down lads .
'don't expect help from the group'

Do you realise what you have just said ? .

Professional programmers acting like foot stomping little children who
wont help a user because they use a different method than their own .