What is wrong with the code?

[tyagithehacker]

my $mesg2 = $ldap->modify('$dn', replace =>{'userpassword'=> 'Test123' });
 
 
        my $error = $mesg2->error;
        print "\n############$dn \n############$error";
        if($error == "Success")
        {
            print "\nPassword $error fully Changed";
        }
        else
        {
            print "\nCaught an exception: $error";
        }
    }
    print "\n\n***************END OF OPERATION***************\n\n"
 
}
 
$ldap->unbind;
 
out put of line 5:
############uid=dphdlmk,ou=people,ou=associates,dc=albertsons,dc=com
############Invalid DN
 
 

After successfully binding the code with the LDAP server, I tried to run this code to change the password of the user in the LDAP server.

The problem is i that didn't know weather the password has been changed or not. To check this i have introduced a
if-else block. The flow of control is managed by the value of error variable, which should show "Success" in idle case. But when i print its value (see line 5), it shows the above stated output (see line 21).

Concern:
If we go with the output, then how is it possible that for a valid DN (as shown in line 22), the error variable is showing Invalid DN.

Secondly, Since the value of error variable is "Invalid DN" control should go to the else block, but it is going in the If block.

thanks in advance.

[RonB]

== is a numerical test, it does not compare strings.

Change it to eq.

if($error eq "Success")

[tyagithehacker]

if ($ent ==  "")
    {
        print "\nNo Match Found !!!\nPassword Cannot be changed";
    }
    else
    {    
        my $dn=$ent->get_value('entrydn');
        my $cn=$ent->get_value('cn');
        print"\nOne Match Found !!!\nEmployee Name: $cn";
 
        my $mesg2 = $ldap->modify('$dn', replace =>{'userpassword'=> 'Test123' });
 
        my $error = $mesg2->error;
        print "\n############$dn \n############$error";
 
        if($error == "Success")
        {
            print "\nPassword $error fully Changed";
        }
        else
        {
            print "\nCaught an exception: $error";
        }
    }
    print "\n\n***************END OF OPERATION***************\n\n"
 

Thanks for replying, RonB.I tried what u said, it worked for line 16.
But still i don't see this as an exact reason. As if it were true, then expression at line one also follow the same rule. If i compare that expression using '==' operator it always return false (ie. go to else part). irrespective of rvalue is string(i tried "" , " " and "anystring") or integer (i tried -1,0 and 1).


Moreover, do you have any idea about my first concern(from previous post) ?
If we go with the output, then how is it possible that for a valid DN (as shown in line 22), the error variable is showing Invalid DN.

[bazz]

if you are comparing a variable to a sting, you should use 'eq' as already said. if comparing integers use '==' and if coparing against a null or empty value, I would use 'eq'

(Ignore the '' surrounding the operators).

bazz

[RonB]

Hi Bazz,

I see you're branching out.

Ron aka FishMonger

[RonB]

my $mesg2 = $ldap->modify('$dn', replace =>{'userpassword'=> 'Test123' });

Don't quote individual vars.

Since you're using single quotes around the $dn var, perl won't interpolate it. Instead, it sees it as the literal string $dn which is why you received the error message.

[tyagithehacker]

What a damn silly blunder it was. Feeling offended now. Sorry guys.
Thanks Bazz
Thanks RonB