What is wrong in this script ??? help plz!!!!

[vijayarl]

Hi All,

Thanks in Advance !!!!

I have one config file & am reading that file.later i am using one of the value specified in the config file & trying to get the files placed in the directory into the array.

problem is when i try to print the array varaible it doesn't hold any value even though i have placed some files under searching directory...

don't know where it's going wrong ??? can any one help me on this ???

script goes like this :

# parse the configuration text file entries into PARAMS associative array.
open (CONFIGFILE, "$config_file") or die;
 
while (<CONFIGFILE>) {    
    chomp;
    if($_!~ /QUIT_TXT/ ){
 
                        if ( ! ( $_ =~ /^#/ )) {
               $CONFIG = $CONFIG . $_ . " ";
 
        }
    }
    else{
        last;        
        }
 
    }
close (CONFIGFILE);
 
%PARAMS = split(/\s+/, $CONFIG);
#######################################
# Build an array of all the input files
my @files = `dir /B $PARAMS{INPUT_FILES_PATH}`;
print "@files\n";
 

Note : i have mention the directory path in "INPUT_FILES_PA TH" under configfile.

i doubt on this code :

my @files = `dir /B $PARAMS{INPUT_FILES_PATH}`;
 

Is this correct way to fetch the directory info ???
i have used GLOB also but no use !!!!

Regards,
Vijayarl

[numberwhun]

The code you have posted will definitely not do what you are expecting. The %PARAMS is a hash (as you have written it) and not an array. You really need to look up a tutorial on how to define a hash and to read them. A has is different from an array in that it has a key=>value pair. You should look up a tutorial on using them and then try to re-write this code.

*Hint: When populating the hash, you will want to put the filehandle into something like a while loop, otherwise you will only get the first line of the file.

Regards,

Jeff

[vijayarl]

Thanks Jeff for your patience reply...

let me tell you, this script works well when i run this script using Eclipse tool..
but the problem is when i try to run the same script through cmd line, i won't get the desired result.

Anyway's thanks for your valuable input on hash...for sure will go through that & get back to you.

Regards,
Vijayarl

[Icecrack]

try replacing the array @files

my @files = `dir /B $PARAMS{INPUT_FILES_PATH}`;

with:

opendir(DIR, $PARAMS{INPUT_FILES_PATH}) || die "can't opendir $PARAMS{INPUT_FILES_PATH}: $! \n";
@files=readdir(DIR);
closedir DIR;

Also as numberwhun said take a good look in hashes if you are going to use them,

[vijayarl]

Thanks Icecrack for your reply...

sure i will go through hash concept then later try to use it in the scripts..

now i did use your idea but the problem is after reading the contents in @ files

@files=readdir(DIR);
 

The @ files contains . .. as there first 2 elements (guess it's reading all the contents including all the hidden files)

now my script fails saying

Died at process_stats_iconprod.pl line 186.
 

line 186 contains :

open (TXTFILE, "$file") or die;
 

all i need now is how to skip reading first 2 array elements of the @files as it contains only . .. (dot & dot dot) then filenames...

Script goes like this :

 
opendir(DIR, $PARAMS{INPUT_FILES_PATH}) || die "can't opendir $PARAMS{INPUT_FILES_PATH}: $! \n"; 
@files=readdir(DIR); 
closedir DIR;
#print "@files\n";
   foreach $file_name_token (@files){
    chomp ($file_name_token);
    $file_name = $file_name_token;
    my $file = "";
    $file = $PARAMS{INPUT_FILE_BASE_PATH} . $file_name;
               open (TXTFILE, "$file") or die;
 
                blahh blahh
 
          }
 
 

Regards,
Vijayarl

[numberwhun]

Ok, feel free to use this code how you like, but here is a script that will populate an array with everything in a directory, except the "." and ".." files:

#!/usr/bin/perl
 
use strict;
use warnings;
 
my @tmparray;
my @files;
my $line;
 
opendir(DIR, "/my/dir/") or die "Cannot open /my/dir/\n");
@tmparray = readdir(DIR);
 
foreach(@tmparray){
    $line = $_;
    if($line !~ /^\.{1,2}$/){
        push(@files, $line);
    }
}
 
# To test that it worked
foreach(@files){
    print("$_\n");
}
 

I tested this on my Gentoo 2008 machine that is sitting next to me using Perl 5.8.8 and it works fine. Incorporate it as you choose.

Regards,

Jeff

[vijayarl]

Thanks jeff for your kind reply....

guess what... i did understand of your script expect for this line

 
if($line !~ /^\.{1,2}$/){ 
        push(@files, $line); 
    } 
 
 

hope u won't mind explaining me this ???

All that i can guess is that you are comparing & skipping 1 & 2 lines & then push everthing to @files... is that so !!!!!

Thanks again Jeff !!!!!

Thanks,
Vijayarl

[numberwhun]

Thanks jeff for your kind reply....

guess what... i did understand of your script expect for this line

 
if($line !~ /^\.{1,2}$/){ 
        push(@files, $line); 
    } 
 
 

hope u won't mind explaining me this ???

All that i can guess is that you are comparing & skipping 1 & 2 lines & then push everthing to @files... is that so !!!!!

Thanks again Jeff !!!!!

Thanks,
Vijayarl

Actually, that is a regular expression. What I did was top do a foreach loop to cycle through the @tmparray array, element by element. The loop first assigns the current element to $line. Then, the if loop compares $line against the regular expression. If you are not up on regular expressions, then you really need to put a little time in on them as they are a critical part of perl and more powerful in Perl than any other language.

Here is the regex, written slightly different, yet still valid:

/          #  This begins the regex
^          #  This says to match from the beginning of the line
\.         #  This matches a "."  The \ escapes its special nature in regex's
{1,2}     # This is a modifier to the previous \., telling it to match once but up to twice in a row
$         #  This says that after that match should be the end of line
/          #  This ends the regex.
 

Essentially, this will match a "." and "..", and that is it. But, because of this (!~), it will only enter the loop and print $line to file if the match does not occur.

I hope this helps.

Regards,

Jeff

[KevinADC]

I tested this on my Gentoo 2008 machine that is sitting next to me.....

Jeff

You have a machine sitting next to you? Sould I be jealous or scared?

[numberwhun]

You have a machine sitting next to you? Sould I be jealous or scared?

Yup, here at work I have my typical Window$ laptop, and then I have a second laptop that I installed Gentoo 2008.0 on and am still configuring. If you think that's nice, I should list what I have at home. :-)

Regards,

Jeff