Insecure dependency while running with -T switch

[kokul]

Hi friends,

I get a value from the html page using cgi->param function. Then i want to pass this value to access database. But it showing some error...I'll explain the details..

sub my_func {

my $id = cgi->param('id');
print "ID is $id"; //its works fine. value od id is 22

Now i want to pass this value to select the name of that id.

my $dbh = Bugzilla->dbh;
my $query = "select name from users where id != $id";
my $names = $dbh->selectrow_arra yref($query);

Here it's showing error:
undef error - Insecure dependency in parameter 1 of DBI::db=HASH(0x a8a628c)->selectrow_arra yref method call while running with -T switch

But when i give a integer value instead of $id in the query it's working fine.

Why the value of $id is not working with query??

Thanks in advance
Kokul

[KevinADC]

The -T switch is to save yourself from making a mistake that allows user input to do something that might be insecure. When you get the data from the form, that is user input, it comes from outside the program. When you put the value directly into the function yourself, it is not insecure because it comes from inside your program.

What you need to do is validate the user intput and then "untaint" it to make it secure:

my $id = cgi->param('id');
if ($id =~ /^(\d+)$/) {
   $id = $1;# <-- now $id comes from inside the program and is untainted
}
else {
   print "Error: id is not a digit";
   exit();
}

see also:

http://gunther.web66.com/FAQS/taintmode.html

[miller]

Because $id is currently "tainted" and database operations are secured operations.
perldoc perlsec

You can do the following which will verify that $id is an integer:

    my $id = cgi->param('id') =~ m/(\d+)/ ? $1 : die "Invalid id";
 

Or you could also look into see if using placeholders would allow you to use DBI will tained data. It might work, but I've never tested it.

my $sth = $dbh->prepare(q{SELECT name FROM users WHERE id!=?});
$sth->execute($id) or die $dbh->errstr;
my $names = $sth->fetchrow_arrayref($query);
 

- Miller