Set Focus on PostBack

[erickme]

Well I wasn't to sure if post this on the javascript forum or here, but since is an error that probably I got because something related to my ASP.Net code I decided to posted here.

Ok my problem is that I need to set focus on a textbox everytime the page is loaded. Maybe you already thinking what I thought at first, that with a textbox.setFocu s() that will do it. Nop this is .Net Framework 1.1 and textbox.setFocu s() didn't exist back then. So I did the other simple thing add a javascript on body onload="documen t.getElementByI d(<%= txtPCode.Client ID %>).focus(). It works on page load but not in postback. I really have try a couple of other things like adding this function in the .vb

 
        Private Sub SetFocus(ByVal ClientID As String)
            Dim Script As New System.Text.StringBuilder
            'Dim ClientID As String = FocusControl.ClientID
            With Script
                .Append("<script language='javascript'>")
                .Append("document.getElementById('")
                .Append(ClientID)
                .Append("').focus();")
                .Append("</script>")
            End With
            RegisterStartupScript("setFocus", Script.ToString())
        End Sub
 

and calling it in from the Page_Load like this SetFocus(textbo x.ClientID).

Anyway nothing of this have work to set the focus of the textbox on the page post back.

Anyone have another idea?

Thanks,

Erick

[Frinavale]

Why all this talk of hidden textboxes?
He knows the name of the textbox.
It's not hidden.
mynothiddentext box.focus()

(Assuming one uses the NAME property, otherwise you'll need the getElementById( ))

Hmm I had to read the question again.
Maybe this person's using an Ajax call to do a partial page update?

[erickme]

I'm tired of looking for the problem. I didn't create the code, it was the guy before me so maybe he have something that it's not allowing this to work. Here is the code if anyone can figured it out.

Imports System.Data.Odbc
 
Namespace ASPNET.StarterKit.Portal
 
    Public Class ProductLookUpPage
        'Inherits System.Web.UI.Page
        Inherits ASPNET.StarterKit.Portal.PortalPage
        Protected WithEvents lnkReturn0 As System.Web.UI.WebControls.LinkButton
        Protected WithEvents lnkReturn1 As System.Web.UI.WebControls.LinkButton
 
        Protected WithEvents phBanner As System.Web.UI.WebControls.PlaceHolder
        Protected WithEvents lblTitle As System.Web.UI.WebControls.Label
        Protected WithEvents cmdLocate As System.Web.UI.WebControls.Button
        Protected WithEvents txtPCode As System.Web.UI.WebControls.TextBox
        Protected WithEvents vsPCode As System.Web.UI.WebControls.ValidationSummary
        Protected WithEvents rfvPCode As System.Web.UI.WebControls.RequiredFieldValidator
        Protected WithEvents revPCode As System.Web.UI.WebControls.RegularExpressionValidator
        Protected WithEvents cvPCode As System.Web.UI.WebControls.CustomValidator
        Protected WithEvents dlProductNumbers As System.Web.UI.WebControls.DataList
        Protected WithEvents lblPCodeValue As System.Web.UI.WebControls.Label
        Protected WithEvents lblDescValue As System.Web.UI.WebControls.Label
        Protected WithEvents lblSizeValue As System.Web.UI.WebControls.Label
        Protected WithEvents lblWHHead As System.Web.UI.WebControls.Label
        Protected WithEvents lblWHQty As System.Web.UI.WebControls.Label
        Protected WithEvents lblStoreHead As System.Web.UI.WebControls.Label
        Protected WithEvents lblStoreQty As System.Web.UI.WebControls.Label
        Protected WithEvents btnPriceIt As System.Web.UI.HtmlControls.HtmlInputButton
        Protected WithEvents spnContent As System.Web.UI.HtmlControls.HtmlGenericControl
 
#Region " Web Form Designer Generated Code "
 
        'This call is required by the Web Form Designer.
        <System.Diagnostics.DebuggerStepThrough()> Private Sub InitializeComponent()
 
        End Sub
 
        Private Sub Page_Init(ByVal sender As System.Object, ByVal e As System.EventArgs) Handles MyBase.Init
            'CODEGEN: This method call is required by the Web Form Designer
            'Do not modify it using the code editor.
            InitializeComponent()
        End Sub
 
#End Region
 
        Private Sub Page_Load(ByVal sender As System.Object, ByVal e As System.EventArgs) Handles MyBase.Load
            Trace.Warn("Default.aspx.vb", "Called Page_Load()")
            'DO NOT remove this line
            'This is what loads the banner into the top
            phBanner.Controls.Add(Page.LoadControl("../../../DesktopPortalBanner.ascx"))
 
            '07/20/07
            SetFocus(txtPCode.ClientID)
 
            'Counteract the DHTML onclick event assigned to the Look-Up Command Button
            txtPCode.Attributes.Add("onfocus", "document.forms(0).cmdLookup.disabled = false;")
 
            ' 03/16/05 WNS Added PriceIt
            btnPriceIt.Visible = False
            Page.RegisterHiddenField("__EVENTTARGET", cmdLocate.ClientID)
            If Page.IsPostBack = False Then
                '  Store URL Referrer to return to portal
                Try
                    ViewState("UrlReferrer") = Request.UrlReferrer.ToString()
                Catch ex As Exception
                    Dim clsApp As New CustomAppSettings
                    ViewState("UrlReferrer") = clsApp.GetAppSetting("StoreTab_Url")
                End Try
 
                Page.RegisterHiddenField("__EVENTTARGET", cmdLocate.ClientID)
 
                If Request.Params("pcode") <> "" Then
                    Dim clsProducts As New ABCProducts
                    If clsProducts.IsValidPCode(Request.Params("pcode")) Then
                        txtPCode.Text = Request.Params("pcode")
                        LocateProduct()
                    End If
                End If
 
            End If
            RegisterStartupScript("SetFocus", ("<script>document.getElementById('txtPCode').focus();</script>"))
 
        End Sub
 
        'DO NOT remove this return procedure
        Private Sub lnkReturn_Click(ByVal sender As System.Object, ByVal e As System.EventArgs) Handles lnkReturn0.Click, lnkReturn1.Click
            'Return to Portal
            Response.Redirect(CType(ViewState("UrlReferrer"), String))
        End Sub
 
        Private Sub cmdLocate_Click(ByVal sender As System.Object, ByVal e As System.EventArgs) Handles cmdLocate.Click
            'A PCode has been entered and the submit button clicked
 
            'Query the SIRBALP by PCode and load into DataSet
            If Page.IsValid Then
                LocateProduct()
            End If
 
        End Sub
 
        Public Sub ValidatePCode(ByVal sender As Object, ByVal e As ServerValidateEventArgs)
            Try
                Dim intTest As Integer = txtPCode.Text
            Catch ex As Exception
                e.IsValid = False
                Exit Sub
            End Try
 
            'July 11, 2007
            'Validates PCODE against AS400 to see if is valid
            Dim sqlCmd As String = "SELECT * FROM ABCPROD.INVMSTP WHERE (PCODE = " & txtPCode.Text & ") "
            Dim conn As New OdbcConnection(System.Configuration.ConfigurationSettings.AppSettings("AS400"))
            Dim cmd As New OdbcCommand(sqlCmd, conn)
            conn.Open()
            Dim AS400reader As OdbcDataReader = cmd.ExecuteReader
 
            AS400reader.Read()
 
            If AS400reader.HasRows Then
                e.IsValid = True
            Else
                e.IsValid = False
            End If
        End Sub
 
        Private Sub LocateProduct()
            txtPCode.Text.Trim()
 
            Dim sqlCmd As String = "SELECT STORE_NO, PCODE, END_QTY, S#STAT " & _
                    "FROM ABCPROD.SIRBALP, ABCPROD.STRMSTP " & _
                    "WHERE ((ABCPROD.SIRBALP.STORE_NO = ABCPROD.STRMSTP.STRNO) " & _
                    "AND (S#STAT = 'A')) " & _
                    "AND (PCODE = " & txtPCode.Text & ") " & _
                    "AND (STORE_NO <> 10) " & _
                    "AND (STORE_NO <> 11) " & _
                    "AND (STORE_NO < 219) " & _
                    "AND (END_QTY > 0) " & _
                    "ORDER BY STORE_NO, PCODE, END_QTY"
 
            Dim conn As New OdbcConnection(System.Configuration.ConfigurationSettings.AppSettings("AS400"))
            Dim cmd As New OdbcCommand(sqlCmd, conn)
            cmd.CommandType = CommandType.Text
            Dim da As New OdbcDataAdapter(cmd)
            Dim ds As New DataSet
            da.Fill(ds)
 
            cmd.CommandText = "SELECT PCODE, ASIZE, DESC, OHQTY " & _
                "FROM ABCPROD.INVMSTP " & _
                "WHERE (PCODE = " & txtPCode.Text & ") "
            da.SelectCommand = cmd
            da.Fill(ds, "Product")
 
            lblPCodeValue.Text = ds.Tables("Product").Rows(0).Item("PCODE")
            lblDescValue.Text = ds.Tables("Product").Rows(0).Item("DESC")
            lblSizeValue.Text = ds.Tables("Product").Rows(0).Item("ASIZE")
            lblWHQty.Text = ds.Tables("Product").Rows(0).Item("OHQTY")
 
            lblWHHead.Visible = True
            lblWHQty.Visible = True
 
            ' if the requestor is at a store PC, then...
            Dim vlVisitor As New ABCNetDepartmentMenu(Request.ServerVariables("remote_addr"))
            If vlVisitor.IsStore Then
                Dim cmdStore As New OdbcCommand("SELECT STORE_NO, PCODE, END_QTY " & _
                    "FROM ABCPROD.SIRBALP " & _
                    "WHERE STORE_NO = " & vlVisitor.StoreNumber & _
                    " AND PCODE = " & txtPCode.Text, conn)
                Dim daStore As New OdbcDataAdapter(cmdStore)
                conn.Open()
                Dim dr As OdbcDataReader = cmdStore.ExecuteReader
 
                lblStoreQty.Text = 0
                While dr.Read
                    lblStoreQty.Text = dr.Item("END_QTY")
                End While
 
                daStore.Dispose()
                cmdStore.Dispose()
                conn.Dispose()
 
                lblStoreHead.Visible = True
                lblStoreQty.Visible = True
            End If
            vlVisitor.Dispose()
 
            dlProductNumbers.DataSource = ds.Tables(0)
            dlProductNumbers.DataBind()
 
            ds.Dispose()
            da.Dispose()
            cmd.Dispose()
            conn.Dispose()
 
            ' 03/16/05 WNS Added PriceIt
            With btnPriceIt
                .Visible = True
                .Attributes.Add("onclick", "NewWindow('PriceIt.aspx?pcode=" & txtPCode.Text & "','PriceLookUp',350,350,0,'center');")
            End With
 
            '6/29/07 Clear textbox
            txtPCode.Text = ""
            SetFocus(txtPCode.ClientID)
        End Sub
 
        '07/20/07 This procedure sets focus to specific controls.
        Private Sub SetFocus(ByVal ClientID As String)
            Dim Script As New System.Text.StringBuilder
            'Dim ClientID As String = FocusControl.ClientID
            With Script
                .Append("<script language='javascript'>")
                .Append("document.getElementById('")
                .Append(ClientID)
                .Append("').focus();")
                .Append("</script>")
            End With
            RegisterStartupScript("setFocus", Script.ToString())
        End Sub
End Namespace
 

Thanks

[Frinavale]

I'm tired of looking for the problem. I didn't create the code, it was the guy before me so maybe he have something that it's not allowing this to work. Here is the code if anyone can figured it out.

I remember having a similar problem to you in the past.
From what I remember, the problem was that the RegisterStartup Script method puts the JavaScript code in the <Body> portion of the Html. In order for the body to call your JavaScript function during the page's onload event, the JavaScript must exist in the <head> section of your Html.

What I to solve this solution was to put my JavaScript into an external JavaScript file hard code the import into the <head> section of my Html.

You don't need to put the JavaScript into an external file, but I'm almost certain that the JavaScript has to be defined in the <head> section in order to make the JavaScript call during your page's onload event.

eg:

 
 
<!DOCTYPE HTML PUBLIC "-//W3C//DTD HTML 4.0 Transitional//EN">
<HTML>
    <HEAD>
        <title>My Page's Title</title>
        <meta content="Microsoft Visual Studio .NET 7.1" name="GENERATOR">
        <meta content="Visual Basic .NET 7.1" name="CODE_LANGUAGE">
        <meta content="VBScript" name="vs_defaultClientScript">
        <meta content="http://schemas.microsoft.com/intellisense/ie5" name="vs_targetSchema">
        <LINK href="Styles.css" type="text/css" rel="stylesheet">    
           <script type="text/javascript">
               onload = function()
               { 
                  document.getElementById('myTextbox').focus();
               }
           </script>
 
    </HEAD>
 

Have you tried hard coding the JavaScript into the <head> section to see if this works?

-Frinny

[erickme]

I have tried that, don't work for me. This is how my script section on the page looks.

            <script language="javascript">
 
                var win=null;
 
                function NewWindow(mypage,myname,w,h,scroll,pos)
                {
                    if(win!=null && win.open) win.close()
 
                    if(pos=="random")
                    {
                        LeftPosition=(screen.width)?Math.floor(Math.random()*(screen.width-w)):100;
                        TopPosition=(screen.height)?Math.floor(Math.random()*((screen.height-h)-75)):100;
                    }
 
                    if(pos=="center")
                    {
                        LeftPosition=(screen.width)?(screen.width-w)/2:100;
                        TopPosition=(screen.height)?(screen.height-h)/2:100;
                    }
                    else if((pos!="center" && pos!="random") || pos==null)
                    {
                        LeftPosition=0;TopPosition=20;
                    }
 
                    settings='width='+w+',height='+h+',top='+TopPosition+',left='+LeftPosition+',scrollbars='+scroll+',location=no,directories=no,status=no,menubar=no,toolbar=no,resizable=no';
                    win=window.open(mypage,myname,settings);
 
                    if(win.focus)
                    {
                        win.focus();
                    }
                }
 
                function CloseNewWin()
                {
                    if(win!=null && win.open) win.close();
                }
 
                onload = function()
                {
                    document.getElementById('txtPCode').focus();
                }
            </script>
 

[Frinavale]

I have tried that, don't work for me. This is how my script section on the page looks.

Are you getting an JavaScript errors on the page at all?
Like an "object expected" error or the like?

[Plater]

As much as I hate to admit it (:-P) if you run it in firefox with that DOM parser thing on you will see a lot more hidden errors.

Are you remembering to have your body tag's onload function call out to that javascript onload thing

[Frinavale]

I'm going to ask one more small but vital question.

Are you using any use of Ajax in your html design?
Are you using the AjaxControlTool kit's UpdatePanel?

[erickme]

I just tried with firefox and it works, but not with Internet explorer. I didn't get any javascript error. I don't get it, whats wrong with IE (lol) then.

I'm not using AJAX in this application, this is an old application, it was develop long time before I started working here.

[Frinavale]

I just tried with firefox and it works, but not with Internet explorer. I didn't get any javascript error. I don't get it, whats wrong with IE (lol) then.

I'm not using AJAX in this application, this is an old application, it was develop long time before I started working here.

Have you checked out w3c?
Have you seen their focus() method example?

I tried their example in IE and it works fine....
Maybe you might find then answer in w3c.

[erickme]

Have you checked out w3c?
Have you seen their focus() method example?

I tried their example in IE and it works fine....
Maybe you might find then answer in w3c.

It doesn't seem to work with a asp button, I got this error:
Compiler Error Message: BC30390: 'ASPNET.Starter Kit.Portal.Prod uctLookUpPage.P rivate Sub SetFocus(Client ID As String)' is not accessible in this context because it is 'Private'.