Help on Bash Scripting

[keyvanrahmadi]

Hello there guys,

i think i am at the end of this, which i have to edmit has been a huge learning curve for me, but i still have couple of problems, which i was hoping you can help me. I think tbh its a very simple thing which i am over looking and just require a pair of fresh eyes to look at. I greatly appriciate if you could have a look at the script and let me know what you think. if you have any solution, or advise just email me or pm here..

player 1 option scripts:

#!/bin/bash
 
function stored_word()
{
  case $(( $$ % 8 )) in
    0 ) echo "energy"    ;;  1 ) echo "touch" ;;
    2 ) echo "climbing" ;; 3 ) echo "declare" ;;
    4 ) echo "marry"  ;;    5 ) echo "relax"   ;;
    6 ) echo "bugs"     ;;    7 ) echo "inaccessible" ;;
  esac
}
 
function startup() {
 
echo "Choose number of Players:"
read players
 
if [ $players -eq 1 ] ; then
        echo " A Random word has been chosen... Enjoy the Game"
elif [ $players -eq 2 ] ; then
        echo "choose a word for player two to guess:"
        read player2word
else
        echo "incorrect option..."
        replay
fi
}
 
function replay() {
 
echo " Do you wish to play again? TYPE \"y\" to play again or \"n\" to quit"
read choice
 
if [ $choice == y ] ; then
startup
else
echo "Hope you enjoyed the game"
exit 0
fi
}
 
startup
life=10
word=$(stored_word)
letters=$(echo $word | wc -c)
letters=$(( $letters - 1 ))
template="$(echo $word | tr '[a-z A-Z 0-9]' '.')"
remaining=$letters
 
echo "  ****The word you are trying to guess has \"$letters\" letters ****"
 
while [ $template != $word ] ; do
        echo""
        echo -n "Word is: $template Please choose a Letter: " ;
        read guess
         guesses=$(( $guesses + 1 ))
         echo " you have chosen $guess"
     if echo $guessed | grep -i $guess > .temp1 ; then
         echo "You've already guessed that letter. Try again!"
        guessed="$guessed$guess"
        echo $letter
     elif ! echo $word | grep -i $guess > .temp1 ; then
         echo "Sorry, the letter \"$guess\" is not in the word."
         guessed="$guessed$guess"
         badguesses=$(( $badguesses + 1))
         echo "$guessed"
         life=$(( $life -1 ))
         echo " you have $life life left"
     else
          echo "Good going! The letter $guess is in the word!"
          guessed="$guessed$guess"
          echo $letter
     fi
 
if [ $life == 0 ]; then
        echo "THE WORD YOU WERE TRYING TO GUESS WAS \"$word\""
        replay
        exit 0
 
fi
 
      lettercount=0
      template2=""
      while [ $lettercount != $(( $letters )) ] ; do
          val1=${word:lettercount:1}
 val2=${template:lettercount:1}
  if [ "$val1" == "$guess" ] ; then
          template2="$template2$guess"
          elif [ "$val2" != '.' ] ; then
          template2="$template2$val2"
          else
          template2="$template2."
          fi
          lettercount=$(( $lettercount + 1 ))
      done
      template=$template2
done
 
echo -n "Congratulations! You guessed \"$word\" in \"$guesses\" guesses"
echo " with $badguesses incorrect guesses"
replay
exit 0
 

The problem is when asked if you want to play again, when you say yes, it kicks out of the script after printing the followig line:

echo " A Random word has been chosen... Enjoy the Game"
 

player 2 option scripts:

startup
 
life=10
word=$player2word
 

Thats the only line which is different everything else is the same . The script again kicks out after it has asked you choose a word for player 2 to guess, during replay.

I created 3 function:

1- stored_words: words used for 1-player game.
2- Replay
3- Startup

so to sumerise and stop boring a hell out of you, the problems are:

1- the looping so the players can continue if they decide to play again.

2- combine both scripts into one

K

[keyvanrahmadi]

I'm not sure I understand: if you call "exit 0;" somehwere in the program it will exit immediately. Instead of calling exit, you should jump back to the beginning of the loop if choce is 'y'. Use the "continue" command, for instance.

HTH,
arne

I used continue, what it will do is contiune the script even when life is = 0

I am not even sure what i need to do next, as i have tried everything i know now.

K

[arne]

I used continue, what it will do is contiune the script even when life is = 0

I am not even sure what i need to do next, as i have tried everything i know now.

K

if [ $life -eq 0 ]; then     
  echo "THE WORD YOU WERE TRYING TO GUESS WAS \"$word\""     
  replay
  continue
fi
 

will continue the loop. Make sure to reset 'life' to 10, to clear the template and to choose another word.

HTH,
arne

[keyvanrahmadi]

if [ $life -eq 0 ]; then     
  echo "THE WORD YOU WERE TRYING TO GUESS WAS \"$word\""     
  replay
  continue
fi
 

will continue the loop. Make sure to reset 'life' to 10, to clear the template and to choose another word.

HTH,
arne

I have managed to set the life counter to 10, by creating a function and calling it when i need to. The only problem now is that not sure why it keeps on calling the same word over and over again when 1 player option is chosen. is there a way to clear the template?

K

[arne]

I have managed to set the life counter to 10, by creating a function and calling it when i need to. The only problem now is that not sure why it keeps on calling the same word over and over again when 1 player option is chosen. is there a way to clear the template?

K

What about defining a function that will select a new word randomly and set the template accordingly?

arne

[keyvanrahmadi]

What about defining a function that will select a new word randomly and set the template accordingly?

arne

stored_word()
{
  case $(( $$ % 10 )) in
    0 ) echo "energy"    ;;  1 ) echo "touch" ;;
    2 ) echo "climbing" ;;   3 ) echo "declare" ;;
    4 ) echo "marry"  ;;     5 ) echo "relax"   ;;
    6 ) echo "bugs"     ;;   7 ) echo "inaccessible" ;;
    8 ) echo "country" ;;    9 ) echo "folder"
  esac
}
 
 

thats what the first funtion dose. I think the main problem is that once the $word is set, it remains the same through out the cycle of the program and only once you exit the game it resets to zero.

have i misunderstood you?

K

[arne]

stored_word()
{
  case $(( $$ % 10 )) in
    0 ) echo "energy"    ;;  1 ) echo "touch" ;;
    2 ) echo "climbing" ;;   3 ) echo "declare" ;;
    4 ) echo "marry"  ;;     5 ) echo "relax"   ;;
    6 ) echo "bugs"     ;;   7 ) echo "inaccessible" ;;
    8 ) echo "country" ;;    9 ) echo "folder"
  esac
}
 
 

thats what the first funtion dose. I think the main problem is that once the $word is set, it remains the same through out the cycle of the program and only once you exit the game it resets to zero.

have i misunderstood you?

K

Yes, but this function (or another one) may also set the template, since if you run out of lifes and you want to play again, your program will reuse the template with the already guessed letters in it ...

arne

[keyvanrahmadi]

Yes, but this function (or another one) may also set the template, since if you run out of lifes and you want to play again, your program will reuse the template with the already guessed letters in it ...

arne

Ok i am officially raising my hand and putting a sign up saying i am too stupid and thick.. sorry :( i dont understand

K

[arne]

Ok i am officially raising my hand and putting a sign up saying i am too stupid and thick.. sorry :( i dont understand

K

Ok, the problem is that the continue jumps to the beginning of the inner loop. What we want is to jump to the beginning of the outer loop. So, try

     flag=0
     if [ $life -eq 0 ]; then
 
     echo "THE WORD YOU WERE TRYING TO GUESS WAS \"$word\""
 
              replay
          flag=1
          break
     fi
 

and

     if [ $flag -eq 1 ]; then
       continue;
     fi
 
     echo -n "Congratulations! You guessed \"$word\" in \"$guesses\" guesses"
 

I added some context so that you can see where to insert the changes.

BTW, try this stored_word function. If you use $$, i.e. the process PID, you will always choose the ssame word for a second game

stored_word()
 {
     number=$RANDOM
     let "number %= 10"
     case $number in     
     0 ) echo "energy"    ;;  1 ) echo "touch" ;;     
     2 ) echo "climbing" ;;   3 ) echo "declare" ;;     
     4 ) echo "marry"  ;;     5 ) echo "relax"   ;;     
     6 ) echo "bugs"     ;;   7 ) echo "inaccessible" ;;     
     8 ) echo "country" ;;    9 ) echo "folder"         
     esac     
 }
 

HTH,
arne