adding a value

[ballygowanboy]

i've put this code together.

there's a variable "s" giving me some grief at the mo, i'm actualy supprised it half works.

it's a simple shopping cart, you pick the quantitly of items, and it adds the total quantitly, total price including vat, that worked, now, that i've introduced shipping, i'm having a bit of trouble.

the shipping value is held in the var s, which i thought i could just add on to the total ammount........

now, it works if you choose shipping first, and then choose quantitly of items, but if you select some items first, you get a NaN in the total box.

here's the code, hope it makes more sence, thanks.

 
<script language="javascript1.2">
 
 
function checkreset()
{
 
   if (confirm('Are you sure you wish to clear the form?'))
   {
      return true
   }
   return false
}
 
function addnumbers()
{
 
// This function reads the values from the input boxes
// parseInt converts the input boxes into an integer
 
//loops through the shipping radio boxes
 
    var s, i;
 
    for (i=0; i<document.form1.shipping.length;i++)
    {
        if (document.form1.shipping[i].checked)
        {
            s = parseInt(document.form1.shipping[i].value);
        }
    }
 
 
a = parseInt(document.form1.abox.value);
b = parseInt(document.form1.bbox.value);
c = parseInt(document.form1.cbox.value);
d = parseInt(document.form1.dbox.value);
e = parseInt(document.form1.ebox.value);
f = parseInt(document.form1.fbox.value);
g = parseInt(document.form1.gbox.value);
h = parseInt(document.form1.hbox.value);
i = parseInt(document.form1.ibox.value);
j = parseInt(document.form1.jbox.value);
 
 
 
// Then we do the math
 
result = a + b + c + d + e + f + g + h + i + j;
 
// This adds the total number of products to the quantity box
document.form1.qbox.value = result;
 
// This calculates the total price, including vat at 21% and adds the shipping cost
// toFixed fixes the decimal point 2 places
document.form1.totalbox.value = "€" + (s+result*10*21/100+result*10).toFixed(2);
 
 
// As the function has already done the output, we don’t need a return value
}
</script>
 
 
 

and the html

 
<form name="form1" onReset="return checkreset()">
 
<!--#include virtual="inc/top.inc" --> 
 
 
<table width="700" border="0" cellpadding="15" cellspacing="1" bgcolor="#FF6600">
  <tr>
    <td width="65%" bgcolor="#FFFFFF"><img src="images/t1.jpg" alt="never forget" width="100" height="75" /> <span class="style1">&nbsp;<span class="style2">                  Never Forget: <span class="style4">&euro;10</span> </span><br />
      <br />
      Quantity</span> 
    <input type="text" id="abox" onChange="addnumbers()" value="0" size="3" maxlength="3">
    &nbsp;<span class="style1">Gift Wrap? </span>
    <label>
    <input name="gift" type="checkbox" id="gift" value="checkbox" />
    <br />
    </label></td>
    <td width="35%" rowspan="10" valign="top" bgcolor="#FFFFFF">
 
 
 
    <table width="100%" border="0" cellspacing="1" cellpadding="6">
      <tr>
        <td colspan="3" bgcolor="#FFF7D2"><span class="style3">Please choose your region for shipping </span></td>
        </tr>
      <tr>
        <td align="center"><span class="style1"><strong>Ireland<br />
        </strong>free </span><br />
         <input type="radio" name="shipping" onClick="addnumbers()" value="0"></td>
        <td align="center"><span class="style1"><strong>Other EU</strong><br />
          &euro;5<br />
</span>
        #  <input type="radio" name="shipping" onClick="addnumbers()" value="5">
        #</td>
        <td align="center">&nbsp; <span class="style1"><strong>Rest of World</strong><br />
          &euro;10<br />
</span>
          <input type="radio" name="shipping" onClick="addnumbers()" value="10"></td>
      </tr>
    </table>
 
      <table width="100%" border="0" cellspacing="1" cellpadding="6">
        <tr>
          <td colspan="2" bgcolor="#FFF7D2"><span class="style3">Shopping Cart </span></td>
        </tr>
        <tr>
          <td><span class="style1">Quantity</span></td>
          <td><input type="text" id="qbox" value="0"></td>
        </tr>
        <tr>
          <td><span class="style1">Total</span></td>
          <td><input type="text" id="totalbox" value="0"></td>
        </tr>
        <tr>
          <td></td>
          <td align="right"><input type="reset" value="Reset"></td>
        </tr>
      </table> 
 
 
    <br /></td>
  </tr>
  <tr>
    <td bgcolor="#FFFFFF"><img src="images/t2.jpg" alt="never forget" width="100" height="75" /> <span class="style1">&nbsp;<span class="style2">                   Viva La Evoluci&oacute;n: <span class="style4">&euro;10</span></span></span><span class="style1"><br />
      <br />
      Quantity</span>
       <input type="text" id="bbox" onChange="addnumbers()" value="0" size="3" maxlength="3">
&nbsp;<span class="style1">Gift Wrap? </span>
<label>
<input name="gift2" type="checkbox" id="gift2" value="checkbox" />
</label></td>
  </tr>
  <tr>
    <td bgcolor="#FFFFFF"><img src="images/t3.jpg" alt="never forget" width="100" height="75" /> <span class="style1">&nbsp;<span class="style2"> Finders Keepers: <span class="style4">&euro;10</span></span></span><span class="style1"><br />
      <br />
      Quantity</span>
       <input type="text" id="cbox" onChange="addnumbers()" value="0" size="3" maxlength="3">
&nbsp;<span class="style1">Gift Wrap? </span>
<label>
<input name="gift22" type="checkbox" id="gift22" value="checkbox" />
</label></td>
  </tr>
  <tr>
    <td bgcolor="#FFFFFF"><img src="images/t4.jpg" alt="never forget" width="100" height="75" /> <span class="style1">&nbsp;<span class="style2">                   Dont Stop Believin: <span class="style4">&euro;10</span></span></span><br />
      <br /> 
      <span class="style1">Quantity</span>
       <input type="text" id="dbox" onChange="addnumbers()" value="0" size="3" maxlength="3">
&nbsp;<span class="style1">Gift Wrap? </span>
<label>
<input name="gift222" type="checkbox" id="gift222" value="checkbox" />
</label></td>
  </tr>
  <tr>
    <td bgcolor="#FFFFFF"><img src="images/t5.jpg" alt="never forget" width="100" height="75" /> <span class="style1">&nbsp;<span class="style2"> Greece: <span class="style4">&euro;10</span></span></span><span class="style1"><br />
      <br />
      Quantity</span>
      <input type="text" id="ebox" onChange="addnumbers()" value="0" size="3" maxlength="3">
&nbsp;<span class="style1">Gift Wrap? </span>
<label>
<input name="gift2222" type="checkbox" id="gift2222" value="checkbox" />
</label></td>
  </tr>
  <tr>
    <td bgcolor="#FFFFFF"><img src="images/t6.jpg" alt="never forget" width="100" height="75" /> <span class="style1">&nbsp;<span class="style2"> South Korea's Got Seoul: <span class="style4">&euro;10</span></span></span><span class="style1"><br />
      <br />
      Quantity</span>
       <input type="text" id="fbox" onChange="addnumbers()" value="0" size="3" maxlength="3">
&nbsp;<span class="style1">Gift Wrap? </span>
<label>
<input name="gift22222" type="checkbox" id="gift22222" value="checkbox" />
</label></td>
  </tr>
  <tr>
    <td bgcolor="#FFFFFF"><img src="images/t7.jpg" alt="never forget" width="100" height="75" /> <span class="style1">&nbsp;<span class="style2"> Camping Is Intents: <span class="style4">&euro;10</span></span></span><span class="style1"><br />
      <br />
      Quantity</span>
      <input type="text" id="gbox" onChange="addnumbers()" value="0" size="3" maxlength="3">
&nbsp;<span class="style1">Gift Wrap? </span>
<label>
<input name="gift222222" type="checkbox" id="gift222222" value="checkbox" />
</label></td>
  </tr>
  <tr>
    <td bgcolor="#FFFFFF"><img src="images/t8.jpg" alt="never forget" width="100" height="75" /> <span class="style1">&nbsp;<span class="style2"> You Complete Me: <span class="style4">&euro;10</span></span></span><span class="style1"><br />
      <br />
      Quantity</span>
       <input type="text" id="hbox" onChange="addnumbers()" value="0" size="3" maxlength="3">
&nbsp;<span class="style1">Gift Wrap? </span>
<label>
<input name="gift2222222" type="checkbox" id="gift2222222" value="checkbox" />
</label></td>
  </tr>
  <tr>
    <td bgcolor="#FFFFFF"><img src="images/t9.jpg" alt="never forget" width="100" height="75" /> <span class="style1">&nbsp;<span class="style2"> Leave Lindsay A-Lohan: <span class="style4">&euro;10</span></span></span><br />
        <br />
      <span class="style1">Quantity</span>
       <input type="text" id="ibox" onChange="addnumbers()" value="0" size="3" maxlength="3">
&nbsp;<span class="style1">Gift Wrap? </span>
<label>
<input name="gift22222222" type="checkbox" id="gift22222222" value="checkbox" />
</label></td>
  </tr>
  <tr>
    <td bgcolor="#FFFFFF"><img src="images/t10.jpg" alt="never forget" width="100" height="75" /> <span class="style1">&nbsp;<span class="style2"> Blimpin' Ain't Easy: <span class="style4">&euro;10</span></span></span><br />
        <br />
      <span class="style1">Quantity</span>
       <input type="text" id="jbox" onChange="addnumbers()" value="0" size="3" maxlength="3">
&nbsp;<span class="style1">Gift Wrap? </span>
<label>
<input name="gift222222222" type="checkbox" id="gift222222222" value="checkbox" />
</label></td>
  </tr>
</table>
</form>
 

[iam_clint]

you need some default values for those
NaN = "Not a Number"!

[ballygowanboy]

you need some default values for those
NaN = "Not a Number"!

can you explain what you mean?

i had values set on the variables, and it wasn't taking the vaule i set, if i set the value to 1, it was giving it a value of 10.

the values are set on the radio buttons themselves.

[ballygowanboy]

ok, i've figured it out, thanks.

[acoder]

ok, i've figured it out, thanks.

Can you post how you solved it?