JS: What does this code need to validate & submit (not 1 or the other)

[holy moly]

Hello,
I have been trying to get this JS form validation code to work ad nauseam... it won't validate, stop if required and submit. The best I managed was to get it to display an empty field alert but still submit.

I think the problem lies with the form syntax but I tried different variations and still couldn't get it to work properly; the code is here:

function formValidator()
{
var firstname = document.getElementById("firstname");
//..rest of the fields}
    if(isEmpty(firstname, "Please enter a value"))
    {//..input check, rest of fields}
                return true;}
                return false;}
 

[html]
<form name="theform" id="theform" action="insert_ val.php" method="post" onSubmit="retur n formValidator() ">
//..rest of form input with id='firstname'
<input type="button" value="Add" onclick="submit ()" />
[/html]
Any suggestions for the syntax to use so the form is checked when submit is pressed, stops submit if there's an empty field then allows me to submit again?

[Logician]

<input type="button" value="Add" onclick="submit ()" />
[/html]
Any suggestions for the syntax to use so the form is checked when submit is pressed, stops submit if there's an empty field then allows me to submit again?

Use a submit type input and don't call the submit method.

[holy moly]

Do you mean this:

[html]<input type="submit" value="Add Observations" />[/html]

because that won't let me submit the form even if its ok

[holy moly]

The problem seems to be that even if the JS function finds an empty field and displays an alert box it will submit the form when you click 'ok'.

I need the function to let me correct the error then submit the form

    if(isEmpty(valp, "Please enter a value"))
    {
        return true;
 
function isEmpty(elem, helperMsg)
{
    if(elem.value.length == 0)
    {
        alert('Please Enter a Value');
        elem.focus();
        return true;
    }
    return false;
}

what changes here will enable this?

[acoder]

Do you mean this:

[html]<input type="submit" value="Add Observations" />[/html]

because that won't let me submit the form even if its ok

That should let you submit the form. Also, add an onsubmit handler in the form tag which will call your from validation function:
[HTML]<form ... onsubmit="retur n validate();">[/HTML]

[acoder]

The problem seems to be that even if the JS function finds an empty field and displays an alert box it will submit the form when you click 'ok'.

I need the function to let me correct the error then submit the form

    if(isEmpty(valp, "Please enter a value"))
    {
        return true;
 
function isEmpty(elem, helperMsg)
{
    if(elem.value.length == 0)
    {
        alert('Please Enter a Value');
        elem.focus();
        return true;
    }
    return false;
}

what changes here will enable this?

You should return false if there is an error and true if it passes successfully.