Trouble with an Array

[Saint48198]

I'm having trouble with an array of data created using the 'getElementsByT agName' call. I'm trying to remove duplicates from the Array. code follows:

// creates a list of all keywords and the removes any dublicates and printes the results
    getKeywords : function() {
 
        var keywords = articleHolder.getElementsByTagName('span');
        var savedKeywords = [];
        for (var i =0, allKeywords = keywords.length; i<allKeywords; i++) {
            savedKeywords[i] = new Array(articleHolder.getElementsByTagName('span')[i].firstChild.nodeValue);
        }
 
        if (allKeywords > 0) {
            var para = document.createElement('p');
            var strong = document.createElement('strong');
            para.appendChild(strong).appendChild(document.createTextNode('Keywords: '));
 
            savedKeywords.sort();
            for ( var n = 0, allSaved = savedKeywords.length; n <allSaved; n++) {
                alert(savedKeywords[n]);
                if (savedKeywords[n] == savedKeywords[n + 1]) {
 
                    savedKeywords.splice(n,1);
 
                }
                else {
                    para.appendChild(document.createTextNode(savedKeywords[n]));
                    para.appendChild(document.createTextNode(', '));
                }
            }
 
 
        }
 
            articleHolder.insertBefore(para, document.getElementById('copyright'));
    }

[Saint48198]

One last question if you don't mind. How would you create a loop to remove duplicates without using sort?

[dorinbogdan]

One last question if you don't mind. How would you create a loop to remove duplicates without using sort?

I'm sure that exist methods without sort, but they would be more complex.
If you really need, I will research for that deeper.

[acoder]

One last question if you don't mind. How would you create a loop to remove duplicates without using sort?

Well, it should be possible, but it won't be as efficient. You can have two arrays. One contains the words, the second one is empty. Then as you loop through the first array, you call a function which checks in the second array (has the word already been added). If the word is already present it is ignored, otherwise it is added. It should be quite simple to implement.

[mrhoo]

    Array.prototype.hasAny= function(wot){        
        var L= this.length, cnt= 0;
        for(var i= 0; i< L; i++){                
            if(A[i]=== wot) ++cnt;        
        }
        return cnt;
    }
    Array.prototype.unique= function(){
        var A= [];
        var L= this.length;
        for(var i= 0; i< L; i++){
            var tem= this[i];
            if(A.hasAny(tem)== 0) A.push(tem);
        }
        return A;
    }