firefox and 'element.style. display'

[basanistes]

Hi,

I have tried several things to get firefox show a bullet list (<ulwhen I
click on the list

having
1) <div onclick="javasc ript....">
2) <a href="javascrip t:..."
(see full HTML below!)

but in both cases, the swapP function is not triggered.
Why does firefox not bother about this?
<script language="javas cript" type="text/javascript">
function swapP(obj)
{var testit = obj.style.displ ay;
if ( testit == undefined) return false;
obj.style.displ ay = testit == 'block' ? 'none' : 'block';
}
</script>


(snippet)

<li>
<a id="_ctl0_conte nt_faqList__ctl 1_issue"
href="javascrip t:swapP(_ctl0_c ontent_faqList_ _ctl1_answer);" >
blah question blah blah ?
</a>

<div id="_ctl0_conte nt_faqList__ctl 1_answer" class="answer">
blha blah blah answer
</div>
</li>

(class answer is inside a css where div.answer {display=none;}

[Randy Webb]

basanistes said the following on 7/28/2006 1:18 PM:

Hi,

I have tried several things to get firefox show a bullet list (<ulwhen
I click on the list

having
1) <div onclick="javasc ript....">
2) <a href="javascrip t:..."
(see full HTML below!)

but in both cases, the swapP function is not triggered.
Why does firefox not bother about this?

It does, but view the error console.

<script language="javas cript" type="text/javascript">
function swapP(obj)
{var testit = obj.style.displ ay;

var testit=document .getElementById (obj).style.dis play

As the "obj" you pass is not the object, but rather the ID of the
object. Well, except in IE.

<a id="_ctl0_conte nt_faqList__ctl 1_issue"
href="javascrip t:swapP(_ctl0_c ontent_faqList_ _ctl1_answer);" >

First problem is the id of the object is not quoted in the function call.
Second problem is that IE is only browser with the ignorance built in to
create a global reference to any object with an ID.
Third problem is the use of the javascript: pseudo-protocol.
--
Randy
comp.lang.javas cript FAQ - http://jibbering.com/faq & newsgroup weekly
Javascript Best Practices - http://www.JavascriptToolbox.com/bestpractices/

[David Dorward]

basanistes wrote:

but in both cases, the swapP function is not triggered.
Why does firefox not bother about this?

<a id="_ctl0_conte nt_faqList__ctl 1_issue"
href="javascrip t:swapP(_ctl0_c ontent_faqList_ _ctl1_answer);" >

Since the JavaScript variable "_ctl0_content_ faqList__ctl1_i ssue" is not
defined.

There are two reasons for this:

1: The first character of an id must NOT be an underscore.

http://www.w3.org/TR/html4/types.html#type-name

2: Firefox does not automatically create, for each element with an id, a
variable in the global scope named after that id and containing a reference
to the element.

http://www.mozilla.org/docs/web-deve...ade_2.html#dom

--
David Dorward <http://blog.dorward.me .uk/ <http://dorward.me.uk/>
Home is where the ~/.bashrc is

[basanistes]

"David Dorward" <do*****@yahoo. comwrote in message
news:ea******** ***********@new s.demon.co.uk.. .

basanistes wrote:

>but in both cases, the swapP function is not triggered.
Why does firefox not bother about this?

> <a id="_ctl0_conte nt_faqList__ctl 1_issue"
href="javascrip t:swapP(_ctl0_c ontent_faqList_ _ctl1_answer);" >

Since the JavaScript variable "_ctl0_content_ faqList__ctl1_i ssue" is not
defined.

As I told that I did not include the whole page. Of course, you can assume
that I''m not that 'stupid' :)

There are two reasons for this:

1: The first character of an id must NOT be an underscore.

that must have been the reason then.

http://www.w3.org/TR/html4/types.html#type-name

2: Firefox does not automatically create, for each element with an id, a
variable in the global scope named after that id and containing a
reference
to the element.

http://www.mozilla.org/docs/web-deve...ade_2.html#dom

--
David Dorward <http://blog.dorward.me .uk/ <http://dorward.me.uk/>
Home is where the ~/.bashrc is

[basanistes]

"Randy Webb" <Hi************ @aol.comwrote in message
news:aI******** *************** *******@comcast .com...

basanistes said the following on 7/28/2006 1:18 PM:

>Hi,

I have tried several things to get firefox show a bullet list (<ulwhen
I click on the list

having
1) <div onclick="javasc ript....">
2) <a href="javascrip t:..."
(see full HTML below!)

but in both cases, the swapP function is not triggered.
Why does firefox not bother about this?

It does, but view the error console.

><script language="javas cript" type="text/javascript">
function swapP(obj)
{var testit = obj.style.displ ay;

var testit=document .getElementById (obj).style.dis play

that did the trick.
Thanks!

As the "obj" you pass is not the object, but rather the ID of the object.
Well, except in IE.

This sounds ok. THe object is referenced by id.

> <a id="_ctl0_conte nt_faqList__ctl 1_issue"
href="javascrip t:swapP(_ctl0_c ontent_faqList_ _ctl1_answer);" >

First problem is the id of the object is not quoted in the function call.
Second problem is that IE is only browser with the ignorance built in to
create a global reference to any object with an ID.
Third problem is the use of the javascript: pseudo-protocol.

So you mean that <div onclick=""etc should be better?

[Randy Webb]

basanistes said the following on 7/28/2006 2:23 PM:

>
"Randy Webb" <Hi************ @aol.comwrote in message
news:aI******** *************** *******@comcast .com...

>basanistes said the following on 7/28/2006 1:18 PM:

<snip>

>> <a id="_ctl0_conte nt_faqList__ctl 1_issue"
href="javascrip t:swapP(_ctl0_c ontent_faqList_ _ctl1_answer);" >

First problem is the id of the object is not quoted in the function call.
Second problem is that IE is only browser with the ignorance built in
to create a global reference to any object with an ID.
Third problem is the use of the javascript: pseudo-protocol.

So you mean that <div onclick=""etc should be better?

<button onclick="">
<a href="noscript. html" onclick="someth ing();return false">

Anything is better than href="javascrip t:

--
Randy
comp.lang.javas cript FAQ - http://jibbering.com/faq & newsgroup weekly
Javascript Best Practices - http://www.JavascriptToolbox.com/bestpractices/