can anyone explain me why this code won't work on IE?

[Motion Musso aka: Sathia]

function up(bpid)
{
image = document.getEle mentById('up_'+ bpid);

image.setAttrib ute('SRC','/templates/images/yespulse.gif')

up_down('/up_down.php?bpi d=' + bpid + '&action=up') ;

image.setAttrib ute('SRC','/templates/images/rated_up.gif')

action_ = document.getEle mentById('actio n_up_'+bpid);
action_.setAttr ibute('HREF', 'javascript:del _vote("'+bpid+' ", "up");');
action_.setAttr ibute('TITLE', 'Not anymore');

image = document.getEle mentById('down_ '+bpid);
image.setAttrib ute('SRC','/templates/images/no.gif')

action_ = document.getEle mentById('actio n_down_'+bpid);
action_.setAttr ibute('HREF', 'javascript:dow n("'+bpid+'");' );

}

I mean, the Ajax part is ok, but it doesn't change the images.
any idea?

thank you

--
Vedo gli amici ancora sulla strada, loro non hanno fretta,
rubano ancora al sonno l'allegria all'alba un po' di notte:
e poi la luce, luce che trasforma il mondo in un giocattolo.
Faremo gli occhiali così, Faremo gli occhiali così!

[RobG]

Motion Musso aka: Sathia wrote:

function up(bpid)
{
image = document.getEle mentById('up_'+ bpid);
Local variables should always be declared/initialised with the var keyword,
unless you mean image to be global, in which case it should have been
declared elsewhere using var. Presumably you've also done feature testing
for getElementById elsewhere too.

var image = document.getEle mentById('up_' + bpid);

image.setAttrib ute('SRC','/templates/images/yespulse.gif')
setAttribute is known to be buggy in IE, use shortcut property access (not
officially standard but more widely and consistently supported than
setAttribute):

img.src = '/templates/images/yespulse.gif';

up_down('/up_down.php?bpi d=' + bpid + '&action=up') ;
What does up_down() do? Where is it declared? What happens to the result?
Does it matter?

image.setAttrib ute('SRC','/templates/images/rated_up.gif')
image.src = '/templates/images/rated_up.gif';
Here the src attribute of the element referred to by image is changed,
likely before the old one had time to do anything useful.

action_ = document.getEle mentById('actio n_up_'+bpid);
var action_ = document.getEle mentById('actio n_up_'+bpid);

action_.setAttr ibute('HREF', 'javascript:del _vote("'+bpid+' ", "up");');
Using javascript within the HREF attribute has unwelcome affects on the
page in some browsers (e.g. IE, maybe others). You could use:

action_.href = "#";
action_.onclick = new Function(
'del_vote("' + bpid + '","up");ret urn false;');
Consider using 'this' within del_vote() to remove the need to pass the id
and 'up', you could get the id of action_ and parse it to get them, and
everything becomes simpler, e.g.
action_.onclick = del_vote;
and del_vote():
function del_vote(txt)
{
var bits = this.id.split(' _');
var updown = bits[1]; // up
var bpid = bits[2]; // bpid from up()

...

return false;
}

action_.setAttr ibute('TITLE', 'Not anymore');
action_.title = 'Not anymore';
And so on...

image = document.getEle mentById('down_ '+bpid);
image.setAttrib ute('SRC','/templates/images/no.gif')

action_ = document.getEle mentById('actio n_down_'+bpid);
action_.setAttr ibute('HREF', 'javascript:dow n("'+bpid+'");' );

}

I mean, the Ajax part is ok, but it doesn't change the images.
any idea?

What AJAX? There is no AJAX or Ajax or even Jiff here. :-)

--
Rob

[Motion Musso aka: Sathia]

RobG wrote:

Local variables should always be declared/initialised with the var
keyword, unless you mean image to be global, in which case it should have
been
declared elsewhere using var. Presumably you've also done feature testing
for getElementById elsewhere too.

var image = document.getEle mentById('up_' + bpid);

aw, I am so noob!
I'll convert this later.

image.setAttrib ute('SRC','/templates/images/yespulse.gif')

setAttribute is known to be buggy in IE, use shortcut property access (not
officially standard but more widely and consistently supported than
setAttribute):

img.src = '/templates/images/yespulse.gif';

Ok, I'll try this

up_down('/up_down.php?bpi d=' + bpid + '&action=up') ;

What does up_down() do? Where is it declared? What happens to the
result?
Does it matter?

I didn't post the whole .js page because it works ok. anyway up_down is a
simple function which handles an XMLHttpRequest

image.setAttrib ute('SRC','/templates/images/rated_up.gif')

image.src = '/templates/images/rated_up.gif';

yey
Here the src attribute of the element referred to by image is changed,
likely before the old one had time to do anything useful.
it was thought like a goodie,
ie: until the XMLHttpRequest isn't done leave a gif pulsing, replace it with
another gif at the end of the server side processing.

action_ = document.getEle mentById('actio n_up_'+bpid);

var action_ = document.getEle mentById('actio n_up_'+bpid);

yes

action_.setAttr ibute('HREF', 'javascript:del _vote("'+bpid+' ", "up");');

Using javascript within the HREF attribute has unwelcome affects on the
page in some browsers (e.g. IE, maybe others). You could use:

action_.href = "#";
action_.onclick = new Function(
'del_vote("' + bpid + '","up");ret urn
false;');

yes, I do believe this, yesterday evening i saw that Konqueror can't handle
"javascript :" at all. I'll surely use this other sintax
Consider using 'this' within del_vote() to remove the need to pass the id
and 'up', you could get the id of action_ and parse it to get them, and
everything becomes simpler, e.g.
action_.onclick = del_vote;

fantastic

action_.setAttr ibute('TITLE', 'Not anymore');

action_.title = 'Not anymore';
And so on...

ok, that will work surely

I mean, the Ajax part is ok, but it doesn't change the images.
any idea?

What AJAX? There is no AJAX or Ajax or even Jiff here. :-)

eheh, there was no need to flood the NG with the other crap on the .js file.

Thank you very much for your help, this evening (I'm in Italy) i'll let you
know if everything is ok.

thank you again.

Sathia



--
Vedo gli amici ancora sulla strada, loro non hanno fretta,
rubano ancora al sonno l'allegria all'alba un po' di notte:
e poi la luce, luce che trasforma il mondo in un giocattolo.
Faremo gli occhiali così, Faremo gli occhiali così!

[motion musso aka: sathia]

Motion Musso aka: Sathia wrote:

Thank you very much for your help, this evening (I'm in Italy) i'll let
you know if everything is ok.

everything has been fixed now, thank you very much for your help.

Sathia
--
Vedo gli amici ancora sulla strada, loro non hanno fretta,
rubano ancora al sonno l'allegria all'alba un po' di notte:
e poi la luce, luce che trasforma il mondo in un giocattolo.
Faremo gli occhiali così, Faremo gli occhiali così!