How to format textbox value before sum?

[staeri]

I'm looping through some textboxes to sum the values. If the value in
the textbox has a dot or a space as thousand separator the sum function
doesn't work.

Can someone help me to make it work also with thousand separators?

function UpdateBudget(ca llingcontrol, totalcontrol)
{
var amount = 0
var f = document.forms['form1'];
if (f) {
f = f.elements;
}
var i = f.length;
var disp = ""
while (i-- > 0) {
if (f[i].type == 'text') {
if (f[i].name.indexOf(" Budget") >= 0) {
if (f[i].name.substr(0, 16) ==
callingcontrol. name.substr(0,1 6)) {

var n = parseInt(f[i].value, 10);
if (isNaN(n)) {
amount += 0;
}
else {
amount += n;
}
}
}
}
}

SumBudget(calli ngcontrol, amount)
}

Grateful for help!

Regards,

S

[Randy Webb]

st****@gmail.co m said the following on 3/7/2006 1:32 AM:

I'm looping through some textboxes to sum the values. If the value in
the textbox has a dot or a space as thousand separator the sum function
doesn't work.
What about a comma separator?
Can someone help me to make it work also with thousand separators?
<snip>
var n = parseInt(f[i].value, 10);

var n = +f[i].value.replace( ' ','').replace(' .','').replace( ',','');

Will remove any spaces, commas or periods (dot). Makes me wonder what
happens if it has a decimal part to it though......

--
Randy
comp.lang.javas cript FAQ - http://jibbering.com/faq & newsgroup weekly
Javascript Best Practices - http://www.JavascriptToolbox.com/bestpractices/

[Jonas Raoni]

Randy Webb wrote:

var n = +f[i].value.replace( ' ','').replace(' .','').replace( ',','');

Will remove any spaces, commas or periods (dot). Makes me wonder what
happens if it has a decimal part to it though......

var s = '.. ,, xx';

alert(s.replace (' ','').replace(' .','').replace( ',',''));
alert(+s.replac e(' ','').replace(' .','').replace( ',',''));

I'm totally sure you know that the replace isn't recursive with single
strings, but as you love to find such idiot mistakes on the people code,
I showed your one too, but I won't do it again, since this is a really
idiot behaviour, makes me remember of our friend Mr. Spock :b
--
Jonas Raoni Soares Silva
http://www.jsfromhell.com

[Randy Webb]

Jonas Raoni said the following on 3/7/2006 2:31 AM:

Randy Webb wrote:

var n = +f[i].value.replace( ' ','').replace(' .','').replace( ',','');

Will remove any spaces, commas or periods (dot). Makes me wonder what
happens if it has a decimal part to it though......

var s = '.. ,, xx';

alert(s.replace (' ','').replace(' .','').replace( ',',''));
alert(+s.replac e(' ','').replace(' .','').replace( ',',''));

I'm totally sure you know that the replace isn't recursive with single
strings, but as you love to find such idiot mistakes on the people code,
I showed your one too, but I won't do it again, since this is a really
idiot behaviour, makes me remember of our friend Mr. Spock :b

I don't hunt "idiot mistakes", but I do point them out when I see them.
And yes, you are correct.

One thing I *do* do when I point it out is to offer a solution, and when
corrected I accept it:

var n= +f[i].s.replace(/\./g, '').replace(/\,/g, '').replace(/\ /g, '');

But you already knew that, right?

--
Randy
comp.lang.javas cript FAQ - http://jibbering.com/faq & newsgroup weekly
Javascript Best Practices - http://www.JavascriptToolbox.com/bestpractices/

[Jonas Raoni]

Randy Webb wrote:

I don't hunt "idiot mistakes", but I do point them out when I see them.
But it's horrible when you point them out, anybody is perfect, the
reader must be able to find the little mistake and correct by himself,
the important is the idea behind the code ='/
And yes, you are correct.
One thing I *do* do when I point it out is to offer a solution, and when
corrected I accept it:

var n= +f[i].s.replace(/\./g, '').replace(/\,/g, '').replace(/\ /g, '');

But you already knew that, right?

Sure, but I don't like to correct these mistakes, I consider that you
have a nice knowledge, so I take the mistakes as simple distractions
that can be seen by anyone, so they don't need to be corrected, but it's
just my opinion :b

It's annoying to stay correcting and correcting, your code isn't perfect
yet for example:

alert(+"a".repl ace(/\./g, '').replace(/\,/g, '').replace(/\ /g, ''));

But again, I won't correct and you don't need to do it, you already
pointed out the solution, let the person who asked dig a little :]

Now I'm really sleepy, it's 5am here haha, I'm tired of writing =/

Take a look on my recent movie
<URL:http://youtube.com/watch?v=lnQTZxq xc10> haha \o/\o/\o/

See ya tomorrow, there are many things to be discussed yet >=]
--
Jonas Raoni Soares Silva
http://www.jsfromhell.com

[Randy Webb]

Jonas Raoni said the following on 3/7/2006 3:14 AM:

Randy Webb wrote:

I don't hunt "idiot mistakes", but I do point them out when I see them.

But it's horrible when you point them out, anybody is perfect, the
reader must be able to find the little mistake and correct by himself,
the important is the idea behind the code ='/

No, you have it backwards. Bad code *needs* to be pointed out and
especially to new people. If it's not then the newbe's learn bad coding
and have to re-learn it and in the process the answers, and quality of
those answers, in comp.lang.javas cript diminishes. There is no good to
letting bad answers go and nothing but good to come of correcting them.

--
Randy
comp.lang.javas cript FAQ - http://jibbering.com/faq & newsgroup weekly
Javascript Best Practices - http://www.JavascriptToolbox.com/bestpractices/

[Dr John Stockton]

JRS: In article <B6************ ********@comcas t.com>, dated Tue, 7 Mar
2006 01:54:30 remote, seen in news:comp.lang. javascript, Randy Webb
<Hi************ @aol.com> posted :

var n = +f[i].value.replace( ' ','').replace(' .','').replace( ',','');

Will remove any spaces, commas or periods (dot). Makes me wonder what
happens if it has a decimal part to it though......

In a function UpdateBudget, one should not expect decimal parts. "A
billion here, a billion there - it soon adds up to real money" (approx).

Assuming your answer to have only the obvious answer-affecting error,

var n = +f[i].value.replace(/[\. ,]/g, "")

in which, in my system, the \ is not actually needed.

--
© John Stockton, Surrey, UK. ?@merlyn.demon. co.uk Turnpike v4.00 IE 4 ©
<URL:http://www.jibbering.c om/faq/> JL/RC: FAQ of news:comp.lang. javascript
<URL:http://www.merlyn.demo n.co.uk/js-index.htm> jscr maths, dates, sources.
<URL:http://www.merlyn.demo n.co.uk/> TP/BP/Delphi/jscr/&c, FAQ items, links.

[Thomas 'PointedEars' Lahn]

Dr John Stockton wrote:

Assuming your answer to have only the obvious answer-affecting error,

var n = +f[i].value.replace(/[\. ,]/g, "")

in which, in my system, the \ is not actually needed.

It is never necessary to escape the literal dot character within a
character class in a Regular Expression.
PointedEars

[staeri]

I'm grateful for the answers but they none of them are working on my
system. One textbox contains for example the value "2 100". This should
be treated as "2100" but is treated like "NaN".

Maybe it's easier to say that space, dot or comma should be eliminated.
And if the user by mistake writes anything else than numbers it should
be treated like "0" so that they always get a correct sum.

Thanks again!

/ S

[Randy Webb]

st****@gmail.co m said the following on 3/14/2006 7:55 AM:

I'm grateful for the answers but they none of them are working on my
system. One textbox contains for example the value "2 100". This should
be treated as "2100" but is treated like "NaN".

Maybe it's easier to say that space, dot or comma should be eliminated.
<input onchange="
this.value=this .value.replace(/\./g,'').replace(/\,/g,'').replace(/\ /g,
'');"

Will remove any commas, any dots and any spaces from the input. Test it :)
And if the user by mistake writes anything else than numbers it should
be treated like "0" so that they always get a correct sum.

So, if I type in "Randy Webb" instead of 123, it should deduce that I
meant 0? Test it for all digits after removing spaces commas and
periods. Then, if it contains non-digits you tell the user they have
incorrect input.

--
Randy
comp.lang.javas cript FAQ - http://jibbering.com/faq & newsgroup weekly
Javascript Best Practices - http://www.JavascriptToolbox.com/bestpractices/