firefox not firing onclick

realraven2000

Hi,

my colleague coded the following onclick events with Javascript which
only seem to fire in IE not in firefox. The checkboxes are built in
Form frmProdDet while looping through a recordset (ncount=0..1..2 ..n)
of Stock Items. The idea is to prefill quantity of ordered items with 1
when buy checkbox is checked, and to empty it when cleared. I put in
alert for testing displays in IE fine, not in fx. My guess its a
syntactical problem.

Any idea why this is not firing in firefox?

apart from this the site works well in both MSIE and ff. According to
him it does not have to be Mozilla compatible, but it would be nicer
for me (as I do most of my testing with ff first).

thanks in advance.
Axel

Relevant code:

Expand|Select|Wrap|Line Numbers

 
<!DOCTYPE HTML PUBLIC "-//W3C//DTD HTML 4.01 Transitional//EN">

<html>
 
<script language="JavaScript" type="text/JavaScript">

<!--

function chkbuy(ncount)

{

//alert

alert("checked=" + document.frmProdDet("checkbox" + ncount).checked);

if (document.frmProdDet("checkbox" + ncount).checked==true)

{

document.frmProdDet("txtQty" + ncount).value="1";

}

else

{

document.frmProdDet("txtQty" + ncount).value="";

}

}

//-->

</script>
 
<form Name="frmProdDet"  Method="post">
 
<table><tr>
 
<td width="30"> <div align="left">

<input type="checkbox" name="checkbox<%=ncount%>"

onclick=javascript:chkbuy(<%=ncount%>)>

</div></td>

<td width="31"> <input name="txtQty<%=ncount%>" type="text"

class="bodysmall" size="2">

</td>
 
</table></tr>
 
</form>

Jul 23 '05 #1

Subscribe Reply

17995

Martin Honnen

re***********@h otmail.com wrote:

alert("checked= " + document.frmPro dDet("checkbox" + ncount).checked );

^^^^^^^^^^^^^^^ ^^^^^
That is a function call, I am sure you get a script error in the Firefox
JavaScript console. If you want to access a property of an object then use
document.frmPro dDet["checkbox" + ncount]

However it appears easier to simply use
<input onclick="chkbuy (this);"
and then in the function you can directly process the input e.g.
function chkbuy (input) {
if (input.checked) {

--

Martin Honnen
http://JavaScript.FAQTs.com/

Jul 23 '05 #2

Michael Winter

On 06/07/2005 17:24, re***********@h otmail.com wrote:

[snip]

<script language="JavaS cript" type="text/JavaScript">
<!--
Drop the language attribute and the SGML comments.

[snip]
alert("checked= " + document.frmPro dDet("checkbox" + ncount).checked );
A form object is not a function, so calling it will only cause an error.
Use square brackets:

alert('checked= ' + document.frmPro dDet['checkbox' + ncount].checked);

The same applies later. However, you can go one step further by using
the forms and elements collections, as well as saving a reference to the
form, rather than resolving it more than once:

function chkbuy(ncount) {
var elements = document.forms. frmProdDet.elem ents;

if(elements['checkbox' + ncount].checked) {
elements['txtQty' + ncount].value = '1';
} else {
elements['txtQty' + ncount].value = '';
}
}

or even better (variables truncated to avoid wrapping):

function chkbuy(n) {
var e = document.forms. frmProdDet.elem ents;

e['txtQty' + n].value = e['checkbox' + n].checked
? '1'
: '';
}

[snip]
<input type="checkbox" name="checkbox< %=ncount%>"
onclick=Javascr ipt:chkbuy(<%=n count%>)>

That onclick attribute must be quoted. You can also drop the javascript:
prefix unless you're using client-side VBScript elsewhere (in which
case, compatibility with Firefox is rather pointless :).

Hope that helps,
Mike

--
Michael Winter
Prefix subject with [News] before replying by e-mail.

Jul 23 '05 #3

Lee

re***********@h otmail.com said:

Hi,

my colleague coded the following onclick events with Javascript which
only seem to fire in IE not in firefox. The checkboxes are built in
Form frmProdDet while looping through a recordset (ncount=0..1..2 ..n)
of Stock Items. The idea is to prefill quantity of ordered items with 1
when buy checkbox is checked, and to empty it when cleared. I put in
alert for testing displays in IE fine, not in fx. My guess its a
syntactical problem.

Any idea why this is not firing in firefox?

The syntax is wrong in a way that IE tolerates.
The references to form elements should be as below.
Also, you don't need the "" comments
and you don't need to compare a Boolean value to true.
<script language="JavaS cript" type="text/JavaScript">
function chkbuy(ncount)
{
//alert
alert("checked= " + document.frmPro dDet.elements["checkbox" + count].checked);
if (document.frmPr odDet.elements["checkbox" + ncount].checked)
{
document.frmPro dDet.elements["txtQty" + ncount].value="1";
}
else
{
document.frmPro dDet.elements["txtQty" + ncount].value="";
}
}
</script>

Jul 23 '05 #4

realraven2000

Thanks Mike,

lovely code. Didn't know you could use single quotes for strings as
well. But I like the use of the ? : operator reminds me of the times
when I was still programming C++ (bliss). I liked the suggestion using
'this' as well, but it doesn't quite work as I still would have to
reference the textbox and end up passing two references or ending up
with a mish mash. Not using the form.elements collection, in case its
to oblique for my colleage. But I am a JScript newbie myself wish I
could replace all the serverside VBScript for Java as well, but too
rusty - hence no exercise, no cigar.

This is the final function:

function chkbuy(ncount)
{
document.frmPro dDet["txtQty" + ncount].value =
(document.frmPr odDet["checkbox" + ncount].checked) ? "1" : "";
}

Jul 23 '05 #5

Similar topics

9301

Form submission in Firefox

by: Stuart Perryman | last post by:

Hi, I have the following code which works just fine in IE6 but not in Firefox. It is an extract of several table rows each with an individual form. It is generated by php. <form action="MaintNotification.php?ReqID=5" method="post" name="frm5"> <tr align="left" bgcolor="#dddddd" class="text" onClick="submit()"

Javascript

3854

Firefox and <body onload=.. > firing after page is rendered

by: usenet | last post by:

Hi All, I have some initialization to be done at page load time, which changes the text of some anchors so that they are consistent with the query string (these anchors are used as criteria selectors, and should be initialized to the criteria contained within the url). IE and Safari fire the onload event before rendering any elements, so when the event handler synchronizes the anchors, they are rendered with the right contents...

Javascript

2666

getElementById and Firefox

by: the other john | last post by:

I came across a third party script I want to learn how to configure as well as learn more dhtml in the doing. I'm not much of a JS guy yet but I'm working on it. This script works fine in IE6 but is a dead fish in FireFox. There is no support offered on the site where it came from. I'd really appreciate help with this as it will not only to get it working but to learn how it all works so I can add it to my repertoire. Thanks!

Javascript

2824

onClick Event Not Firing

by: =?Utf-8?B?Uml0YUc=?= | last post by:

I posted this question in the C# discussion group but am posting it here also since ASP is involved. I'm new to C# and need some help regarding an onClick event not firing. I have a data grid that I add a cell to programatically. The cell is a hyperlink and the onClick is set to _doPostBack. In my code I handle the event but when I click on that added hyperlink nothing happens. Here's my code (I'll just show the relevant stuff).

ASP.NET

1619

Pop up with strange behaviour in Internet Explorer but not Firefox.

by: ft310 | last post by:

Use Internet Explorer go to http://rhodeisland-aa.org/tester/meetings/index.htm On the left click "and go to meetings" Click any address in the right hand 'location' column. The entire page reloads in the frame. (Bad) Perform the same test using Firefox

Javascript

5519

Button clicks not firing!

by: Jay | last post by:

I am on the 2.0 framework and have run the c:\windows\microsoft.net \framework\v1.1.4322\aspnet_regiis.exe -c and had no success. About half of the buttons on my webforms are firing and the other half are not, primarily anything on the Master is firing but those in the content pane are not. This was working fine yesterday!! I've reviewed all the code changes and can't seem to find a culprit. Here's one example of what I'm trying to...

ASP.NET

5567

"<div>" events problem in firing in FireFox

by: Basharat | last post by:

Hi all I have problem on firing "onmouseleave" event of <div> html element. Here is the code im using: <div ID="BSHelpPanel" class="PageMenuMain" onclick="javascript:this.style.display='none';" runat="server" > its working fine in IE while some other events too are not firing in firefox like ondeactivate onfocusout etc.

Javascript

3480

Firefox not firing the onClick Event...but working in IE

by: sacha4 | last post by:

Hi, I need some help with my onClick event. I realise that there is some problem with the javascript but what exactly it is i am not able to know. <input type="Button" onClick="location = '' + jump.options.value;" value="Go!" /> This is my code for the onClick event. need help ! thanks!

.NET Framework

13462

OnClick event not firing

by: brucedodds | last post by:

I have an Access 2003 form bound to a SQL Server table via ODBC. Often clicking a button on the form has the effect of requerying the form rather than firing the OnClick event. Does anyone have an explanation? Is this evidence of corruption, or a known side effect? TIA Bruce

Microsoft Access / VBA

10008

Maximizing Business Potential: The Nexus of Website Design and Digital Marketing

by: jinu1996 | last post by:

In today's digital age, having a compelling online presence is paramount for businesses aiming to thrive in a competitive landscape. At the heart of this digital strategy lies an intricately woven tapestry of website design and digital marketing. It's not merely about having a website; it's about crafting an immersive digital experience that captivates audiences and drives business growth. The Art of Business Website Design Your website is...

Online Marketing

9837

Discussion: How does Zigbee compare with other wireless protocols in smart home applications?

by: tracyyun | last post by:

Dear forum friends, With the development of smart home technology, a variety of wireless communication protocols have appeared on the market, such as Zigbee, Z-Wave, Wi-Fi, Bluetooth, etc. Each protocol has its own unique characteristics and advantages, but as a user who is planning to build a smart home system, I am a bit confused by the choice of these technologies. I'm particularly interested in Zigbee because I've heard it does some...

General

8833

AI Job Threat for Devs

by: agi2029 | last post by:

Let's talk about the concept of autonomous AI software engineers and no-code agents. These AIs are designed to manage the entire lifecycle of a software development project—planning, coding, testing, and deployment—without human intervention. Imagine an AI that can take a project description, break it down, write the code, debug it, and then launch it, all on its own.... Now, this would greatly impact the work of software developers. The idea...

Career Advice

7381

Access Europe - Using VBA to create a class based on a table - Wed 1 May

by: isladogs | last post by:

The next Access Europe User Group meeting will be on Wednesday 1 May 2024 starting at 18:00 UK time (6PM UTC+1) and finishing by 19:30 (7.30PM). In this session, we are pleased to welcome a new presenter, Adolph Dupré who will be discussing some powerful techniques for using class modules. He will explain when you may want to use classes instead of User Defined Types (UDT). For example, to manage the data in unbound forms. Adolph will...

Microsoft Access / VBA

6651

Couldn’t get equations in html when convert word .docx file to html file in C#.

by: conductexam | last post by:

I have .net C# application in which I am extracting data from word file and save it in database particularly. To store word all data as it is I am converting the whole word file firstly in HTML and then checking html paragraph one by one. At the time of converting from word file to html my equations which are in the word document file was convert into image. Globals.ThisAddIn.Application.ActiveDocument.Select();...

C# / C Sharp

5279

Trying to create a lan-to-lan vpn between two differents networks

by: TSSRALBI | last post by:

Hello I'm a network technician in training and I need your help. I am currently learning how to create and manage the different types of VPNs and I have a question about LAN-to-LAN VPNs. The last exercise I practiced was to create a LAN-to-LAN VPN between two Pfsense firewalls, by using IPSEC protocols. I succeeded, with both firewalls in the same network. But I'm wondering if it's possible to do the same thing, with 2 Pfsense firewalls...

Networking - Hardware / Configuration

5423

Windows Forms - .Net 8.0

by: adsilva | last post by:

A Windows Forms form does not have the event Unload, like VB6. What one acts like?

Visual Basic .NET

3929

transfer the data from one system to another through ip address

by: 6302768590 | last post by:

Hai team i want code for transfer the data from one system to another through IP address by using C# our system has to for every 5mins then we have to update the data what the data is updated we have to send another system

C# / C Sharp

3532

How to add payments to a PHP MySQL app.

by: muto222 | last post by:

How can i add a mobile payment intergratation into php mysql website.

PHP