a few problems I am having with a card game I made...

[JNeko]

Hello all, awesome site! I guess I am technically not a beginner in JAVA, but from my code you would not realize it! I don’t expect anyone to help me with this, but I figure I might as well as try and ask. Any help is really appreciated; this should be a piece of cake…driving me crazy.

I am writing a simple program (from a book for fun) that creates a deck of cards, shuffles them, gives the user a card, and asks if the next card will be higher or lower. Then, I average all the wins or correct guesses made with the number of games played at the end. This only utilizes one class Cards1, in order to make a card object with suit and value properties. Ignore the horrible structure of the program; I am just trying to figure out why I am getting the errors I am getting following the program’s logic…

Problems occuring:
1. Every time I compile I always get the one of Spades as the first card, even though I shuffle the deck.
2. The next card is always either a two of spades or one of spades
3. when I guess wrong and prompted to play again, if I select no then the while loop I use is broken and it tells me how many games won lost or whatever, excellent, but when I say yes to play again…nothing happens, it does not loop back and start the game over, lol, I really don’t know why…so frustrating…

public class Text1{
 
    public static void main(String[] args){
        play();
 
    }
 
    static void play(){
 
        int deckCount = 0;
        int average = 0;
        int wins = 0;
        int gamesPlayed = 0;
        boolean continuePlay = true;
        boolean continueGame = true;
        boolean playAgainB = true;
 
 
        while (continuePlay){
 
            //make deck 
            Card1[] deck; 
            deck = new Card1[52];
            int tempcounter = 0;
            //suits and values
            for(int suit = 0;suit < 3;suit++){
 
                for(int value = 1;value < 13;value++){
 
                deck[tempcounter] = new Card1(suit, value); 
                tempcounter++;
 
                }//deck made
            }
 
            Card1 aCard, bCard;
 
            //now you need to shuffle
            for(int x = 51; x > 0; x--){
 
                int random = (int)(Math.random() * (x+1));
                deck[x] = deck[random];
                deck[random] = deck[x];
 
            }
 
 
            while (continueGame){
 
                aCard = deck[deckCount];
                bCard = deck[deckCount + 1];
 
                TextIO.putln("Your card is:");
                TextIO.putln("a " + aCard.switchValue() + " of " + aCard.switchSuit());
                int previousCard = aCard.getValue();
                int nextCard = bCard.getValue();
 
 
            while(true){
                TextIO.putln("Will the next card be higher or lower?!?!? Type H or L for higher or lower");
                char answer = TextIO.getlnChar();
 
                char answerToUp = Character.toUpperCase(answer);
 
                if (answerToUp == 'H'){
 
                    if (previousCard < nextCard){
 
                        TextIO.putln("Your right! The next card is a " + bCard.switchValue() + " of " + bCard.switchSuit());
                        wins++;
                        continueGame = true;
                        break;
                    }
 
                    else if (previousCard > nextCard){
 
                        TextIO.putln("Your wrong! The next card is a " + bCard.switchValue() + " of " + bCard.switchSuit());
                        continueGame = false;
                        break;
                    }
 
                    else {
                        TextIO.putln("Your wrong! A tie! The next card is a " + bCard.switchValue() + " of " + bCard.switchSuit());
                        continueGame = false;
                        break;
                    }
 
 
                }
 
                else if (answerToUp == 'L'){
 
                    if (previousCard > nextCard){
 
                        TextIO.putln("Your right! The next card is a " + bCard.switchValue() + " of " + bCard.switchSuit());
                        wins++;
                        continueGame = true;
                        break;
                    }
 
                    else if (previousCard < nextCard){
 
                        TextIO.putln("Your wrong! The next card is a " + bCard.switchValue() + " of " + bCard.switchSuit());
                        continueGame = false;
                        break;
                    }
 
                    else {
                        TextIO.putln("Your wrong! A tie! The next card is a " + bCard.switchValue() + " of " + bCard.switchSuit());
                        continueGame = false;
                        break;            
                    }
 
 
                }
 
                else
                    TextIO.putln("your gonna have to type in like a H or a L...");
 
            }//end high/low question while
 
            deckCount++;
 
            }//end continueGame while
 
            gamesPlayed++;
 
            while (playAgainB){    
                TextIO.putln("awwwww too bad...wanna play again? Type y or n for yes or no!");
                char playAgain = TextIO.getlnChar();
                char playAgainUp = Character.toUpperCase(playAgain);
 
                if (playAgainUp == 'Y')
                    playAgainB = false;
 
                else if (playAgainUp == 'N'){
                    continuePlay = false;    
                    playAgainB = false;        
                }
 
                else
                    TextIO.putln("your gonna have to type in like a y or a n...");
            }//end playagain while
 
        }//end continueplay while
 
        if (wins > 0){
            average = wins/gamesPlayed;
            TextIO.putln("you played " + gamesPlayed + " games and got like " + wins + " wins, so your average is like:" + average);
        }
        else 
            TextIO.putln("you played " + gamesPlayed + " games and got like " + wins + " wins");
    }//end play method
}//end class Text1
 
 
public class Card1{
 
 
    int Suit;
    int Value;
 
    public Card1(int suit, int value){
 
    Suit = suit;
 
    Value = value;
 
    }
 
    //method switch suit    
    public String switchSuit(){
 
        switch (Suit) {
 
        case 0: return "Spades";
        case 1: return "Clubs";
        case 2: return "Diamonds";
        case 3: return "Hearts";
        default: return "??";
 
        }
 
    }//end method switch suit
 
    //method switch value
    public String switchValue(){
 
        switch (Value) {
 
        case 1: return "1";
        case 2: return "2";
        case 3: return "3";
        case 4: return "4";
        case 5: return "5";
        case 6: return "6";
        case 7: return "7";
        case 8: return "8";
        case 9: return "9";
        case 10: return "10";
        case 11: return "jack";
        case 12: return "queen";
        case 13: return "king";
        default: return "??";
 
        }    
 
    }//end method switch value
 
    public int getValue(){
 
        return Value;
 
    }
 
 
}//end public class card
 

[horace1]

think in your shuffle you need to swop the cards, e.g.

                     //now you need to shuffle
                        for(int x = 51; x >= 0; x--){
                                int random = (int)(Math.random() * (x+1));
                                 Card1 temp=deck[x];
                                deck[x] = deck[random];
                                deck[random] = temp;
                        }
 

[JNeko]

think in your shuffle you need to swop the cards, e.g.

                     //now you need to shuffle
                        for(int x = 51; x >= 0; x--){
                                int random = (int)(Math.random() * (x+1));
                                 Card1 temp=deck[x];
                                deck[x] = deck[random];
                                deck[random] = temp;
                        }
 

excellent! thanks for the above code and the quick reply! I actually knew of that code but thought it performed the same functions as my original code, looking at it again though, uggghh, anyway, of course a new problem has come up and it's just as confusing to me. Now when i run the program with the new code, I sometimes* get a nullpoint at
TextIO.putln("a " + aCard.switchVal ue() + " of " + aCard.switchSui t());

which means I guess that the program is not finding a Card1 object at the deck[deckCount] (deckCount initially at 0), which is quite interesting because I could have sworn I just a made an array full of cards a few lines above this...

It really is weird, because sometimes it will run fine and display the first card! Then, like the other problem stated in my original post, once I get to the do you want to play again part and I select Y, it just sits there and does nothing...but first thing is first...

anyone know why this thing is giving me a nullpoint exception error? Thanks again!

[horace1]

think you are only initialising 3 suits and 12 cards. Should the initialisation be?

                        for(int suit = 0;suit < 4;suit++){
                                for(int value = 1;value < 14;value++){
                                deck[tempcounter] = new Card1(suit, value); 
                                tempcounter++;
                                }//deck made
 

[JNeko]

think you are only initialising 3 suits and 12 cards. Should the initialisation be?

                        for(int suit = 0;suit < 4;suit++){
                                for(int value = 1;value < 14;value++){
                                deck[tempcounter] = new Card1(suit, value); 
                                tempcounter++;
                                }//deck made
 

o....lord.....t hat would explain the nullpoint error, it's kewl to know that I wasted a few good hours because I forgot to add a freaking = sign after the <....nothing out of the ordinary for a JAVA programmer I guess...thanks so much horace1!

********JUST GOT IT**********
I just typed a really long message, asking the next question: why the heck is the game not looping back through once the player asks to play again. And after going through the program about the 80th time, realised I forgot to change my playAgainB and freaking continueGame booleans back to true at the beginning of the first while loop!! Why am I so freaking retarded?!?!?

But it works now..thanks again horace1...now to move on to reviewing superclasses... .this site is awesome!

[Ganon11]

Glad to see you got the help.

As far as the simple mistakes, don't sweat it! In fact, treasure the easily explained errors! I've been recently getting a few errors in my C++ code that even my teacher and I double-teamed cannot figure out.

[JNeko]

Glad to see you got the help.

As far as the simple mistakes, don't sweat it! In fact, treasure the easily explained errors! I've been recently getting a few errors in my C++ code that even my teacher and I double-teamed cannot figure out.

>< ugghh, i know i know, dont tell me that, lol, im sure i will run into that later, scary stuff