success! I think

[Bill Cunningham]

I began to think about some excercises I could with files after reading
turtorials today on arithmetic operators and confusing myself and decided to
do this.
Take the mv command from linux that moves and renames files read it as
binary and write it as text. After some compiler qipes it compiled and I
believe it did want I wanted it to.

#include <stdio.h>

int main(void) {
FILE *ifp, *ofp;
int a;
ifp=fopen("mv", "rb");
ofp=fopen("m"," wt");
a=fgetc(ifp);
if (a==EOF) {
fclose(ifp);
}
fputc(a,ofp);
if (a==EOF) {
fclose(ofp);
}
}

Because I didn't know how long the file would be I couldn't say exactly
how many bytes I should read so fread/fwrite were out and I decided on
fgetc/fputc. Is my code up to standards? And also can someone tell me what
the first int parameter of fputc is and does? My references that I look at
do not say. But I think I used it right. I guessed a 'container' for a char.

Bill

[Bartc]

"Bill Cunningham" <no****@nspam.c omwrote in message
news:V1aMj.3202 $Ho5.2125@trndd c01...

I began to think about some excercises I could with files after reading
turtorials today on arithmetic operators and confusing myself and decided
to do this.
Take the mv command from linux that moves and renames files read it as
binary and write it as text. After some compiler qipes it compiled and I
believe it did want I wanted it to.

#include <stdio.h>

int main(void) {
FILE *ifp, *ofp;
int a;
ifp=fopen("mv", "rb");
ofp=fopen("m"," wt");
a=fgetc(ifp);
if (a==EOF) {
fclose(ifp);
}
fputc(a,ofp);
if (a==EOF) {
fclose(ofp);
}
}

Because I didn't know how long the file would be I couldn't say exactly
how many bytes I should read so fread/fwrite were out and I decided on
fgetc/fputc. Is my code up to standards?

Not quite.

Try putting in a comment describing what it should do.

Try testing it to see that it does so!

--
Bart

[Bill Cunningham]

"Bartc" <[e-mail] rote in message
news:1e******** ********@text.n ews.virginmedia .com...

Not quite.

Try putting in a comment describing what it should do.

Try testing it to see that it does so!

Well as far as testing it an EBCDIC file was written with characters so
it seems to work. But when I changed the ofp pointer and fopen's mode to wb
I got the same thing. So now I am doubting that I am getting what I want
though it seemed work.

Bill

[Richard]

"Bill Cunningham" <no****@nspam.c omwrites:

"Bartc" <[e-mail] rote in message
news:1e******** ********@text.n ews.virginmedia .com...

>Not quite.

Try putting in a comment describing what it should do.

Try testing it to see that it does so!

Well as far as testing it an EBCDIC file was written with characters so
it seems to work. But when I changed the ofp pointer and fopen's mode to wb
I got the same thing. So now I am doubting that I am getting what I want
though it seemed work.

Bill

You are trolling aren't you?

[Bill Cunningham]

"Richard" <de***@gmail.co mwrote in message
news:ft******** **@registered.m otzarella.org.. .

You are trolling aren't you?

Where the hell did that come from? I am doubting that my code is doing
what I wanted and I would like to ask for serious feedback.

Bill

[Richard]

"Bill Cunningham" <no****@nspam.c omwrites:

"Richard" <de***@gmail.co mwrote in message
news:ft******** **@registered.m otzarella.org.. .

>You are trolling aren't you?

Where the hell did that come from? I am doubting that my code is doing
what I wanted and I would like to ask for serious feedback.

Bill

Here's some : step through it with a debugger. That will be specific to
your platform properly. Even a casual look at your code should tell you
it doesn't do what you want. Stepping through with a debugger will prove
invaluable since you clearly are a beginner in all aspects of
programming. Rather than take you through all the issues with your code,
try to figure it out yourself first. Go line by line and ask yourself
what it is doing and, as importantly, why.

[Barry Schwarz]

On Sat, 12 Apr 2008 21:43:17 GMT, "Bill Cunningham" <no****@nspam.c om>
wrote:

I began to think about some excercises I could with files after reading
turtorials today on arithmetic operators and confusing myself and decided to
do this.
Take the mv command from linux that moves and renames files read it as
binary and write it as text. After some compiler qipes it compiled and I
believe it did want I wanted it to.

#include <stdio.h>

int main(void) {
FILE *ifp, *ofp;
int a;
ifp=fopen("mv", "rb");
ofp=fopen("m"," wt");
a=fgetc(ifp);

How do you ever get back to read another character.

if (a==EOF) {
fclose(ifp);

If you would learn to indent your code, it might make it much easier
for you to see where you are going wrong.

}
fputc(a,ofp);
if (a==EOF) {
fclose(ofp);
}
}

Because I didn't know how long the file would be I couldn't say exactly
how many bytes I should read so fread/fwrite were out and I decided on

Your comment makes no sense. Both fread and fwrite have methods for
specifying how many bytes to read/write and for informing the caller
how many bytes were actually read/written. You don't have to use them
but to say you can't is a limitation on you and not the functions.

>fgetc/fputc. Is my code up to standards? And also can someone tell me what
the first int parameter of fputc is and does? My references that I look at
do not say. But I think I used it right. I guessed a 'container' for a char.

You need a better reference. Find one that describes the purpose of
each parameter of all the standard functions. You can even find free
copies of the draft standard (n1124 and n1256) on the web which will
do this.
Remove del for email

[Barry Schwarz]

On Sat, 12 Apr 2008 22:23:03 GMT, "Bill Cunningham" <no****@nspam.c om>
wrote:

>
"Bartc" <[e-mail] rote in message
news:1e******* *********@text. news.virginmedi a.com...

>Not quite.

Try putting in a comment describing what it should do.

Try testing it to see that it does so!

Well as far as testing it an EBCDIC file was written with characters so
it seems to work. But when I changed the ofp pointer and fopen's mode to wb
I got the same thing. So now I am doubting that I am getting what I want
though it seemed work.

Only for some strange definition of work. Your function doesn't
contain any form of looping. It executes fputc and fgetc each exactly
once. How can your function read or write more than one character?
Remove del for email

[Bill Cunningham]

Only for some strange definition of work. Your function doesn't

contain any form of looping. It executes fputc and fgetc each exactly
once. How can your function read or write more than one character?

I'm not exactly sure how to use fgetc and fputc. This is the first time
I've put them into code so I'm a little confused on where in the loops to
put them. I've never really used debuggers though I have gdb. I don't think
it takes more than a keaner eye than mine to see the problems though.

Bill

[Bill Cunningham]

"Barry Schwarz" <sc******@dqel. comwrote in message
news:j3******** *************** *********@4ax.c om...

> Because I didn't know how long the file would be I couldn't say
exactly
how many bytes I should read so fread/fwrite were out and I decided on

Your comment makes no sense. Both fread and fwrite have methods for
specifying how many bytes to read/write and for informing the caller
how many bytes were actually read/written. You don't have to use them
but to say you can't is a limitation on you and not the functions.

Exactly. Fread and fwrite require a buffer size and number of elements.
I just wanted to read the entire file without having to enter an exact size
so I don't think fwrite and fread would be the choice here.

Bill