Looping issues...

[gwenky]

Hello, so I was working this out yesterday and I am working on a function (w/o using arrays) that moves through the digits of a user inputted number and finds max/min ...this is the max option and it works ( up to < 10000), but I was wondering if there is a better format for looping this ...and if so where should I begin to look?

int FindDigitAtPosition ( int x, double counter )
{
    for ( i = 1; i <= counter; ++i )
    { 
        if ( x < 10)
        {
            x = x % 10;
 
            if ( digit <= x )
            {
                digit = x;
            }
        }
        if ( x < 100 && x > 99 )
        {
            j = x % 10;
            x = x / 10;
            if ( digit < j )
            {
                digit = j;
                if ( digit < x )
                {    
                digit = x;
                }
            }
        }
        if ( x < 1000 && x >= 100 )
        {
            j = x % 100;
            j = j % 10;
            if ( digit < j)
            {
                digit = j;
            }
            j = x / 100;
            j = j % 10;
            if ( digit < j )
            {
                digit = j;
            }
            j = x / 10;
            j = j % 10;
            if ( digit < j )
            {
                digit = j;
            }
 
        }
        if ( x < 10000 && x >= 1000 )
        {
            j = x / 1000;
            if ( digit < j)
            {
                digit = j;
            }
            j = x / 100;
            j = j % 10;
            if ( digit < j )
            {
                digit = j;
            }
            j = x / 10;
            j = j % 10;
            if ( digit < j )
            {
                digit = j;
            }
            j = x % 10;
            if ( digit < j )
            {
                digit = j;
            }
        }
 
    }
 
return digit;
}
 

Any suggestions would be greatly appriciated!!!

Thanks

[sicarie]

Hello, so I was working this out yesterday and I am working on a function (w/o using arrays) that moves through the digits of a user inputted number and finds max/min ...this is the max option and it works ( up to < 10000), but I was wondering if there is a better format for looping this ...and if so where should I begin to look?

I don't see how it works anywhere in the following:

        if ( x < 1000 && x >= 100 )
        {
            j = x % 100;
            j = j % 10;
            if ( digit < j)
            {
                digit = j;
            }
            j = x / 100;
            j = j % 10;
            if ( digit < j )
            {
                digit = j;
            }
            j = x / 10;
            j = j % 10;
            if ( digit < j )
            {
                digit = j;
            }
 
        }
        if ( x < 10000 && x >= 1000 )
        {
            j = x / 1000;
            if ( digit < j)
            {
                digit = j;
            }
            j = x / 100;
            j = j % 10;
            if ( digit < j )
            {
                digit = j;
            }
            j = x / 10;
            j = j % 10;
            if ( digit < j )
            {
                digit = j;
            }
            j = x % 10;
            if ( digit < j )
            {
                digit = j;
            }
        }
 
    }
 
return digit;
}
 

At no point do you save the values of x that you are modifying, in short - x never changes, is the same value as when it entered the loop, and will never exit the loop.

I would also recommend writing an function for any part of that series that is repeated - it seems like you do the if digit < j ... part a lot, that could be a function you call instead of 4 lines each time you want to do it.