Finding the lowest score

[namcintosh]

First of all, here is my program:

#include <iostream>
#include <conio>
using namespace std;
 
//Function prototype
void getscore(int&, int&, int&, int&, int&);
void findLowest (int, int, int, int, int, int);
int main()
{
        int LO, score1, score2, score3, score4, score5;
 
        getscore (score1, score2, score3, score4, score5);
        findLowest(LO, score1, score2, score3, score4, score5);
 
        getch();
        return 0;
}
 
 
 
void getscore (int &score1, int &score2, int &score3, int &score4, int &score5)
{
        cout << "Enter first score: ";
        cin  >> score1;
        cout << "Enter second score: ";
        cin  >> score2;
        cout << "Enter third score: ";
        cin  >> score3;
        cout << "Enter fourth score: ";
        cin  >> score4;
        cout << "Enter fifth score: ";
        cin  >> score5;
}
 
void findLowest(int LO, int score1, int score2, int score3, int score4, int score5)
{
 
        LO = 1000;
 
        if (score1 < LO)
        {
            LO = score1;
            cout << "The lowest score is" <<LO <<endl;
        }
 
        else if (score2 < LO)
        {
            LO = score2;
            cout << "The lowest score is" <<LO <<endl;
        }
        else if (score3 < LO)
        {
            LO = score3;
            cout << "The lowest score is" <<LO <<endl;
        }
        else if (score4 < LO)
        {
            LO = score4;
            cout << "The lowest score is" <<LO <<endl;
        }
        else if (score5 < LO)
        {
            LO = score5;
            cout << "The lowest score is" <<LO <<endl;
        }
}

Okay, I got one part of the program to work right. The only problem is finding the lowest score.

I declared some if/else if statements and also assigned LO to a large number, such as 1000. Here's my output:

Enter first score: 100
Enter second score: 75
Enter third score: 55
Enter fourth score: 100
Enter fifth score: 85
 The lowest score is100

Do you see what I mean? It declares 100 as the lowest number. Why is it doing that?

[sicarie]

Your else-if chain only checks to see if the numbers are less than LO, or 1000, and they only do it once, there's no looping, so it only does the first one (100), but doesn't loop back after LO is reset. (If a branch is taken in an if-else statement, the rest of it is disregarded) You should put that in a loop, and you'll have to change your logic a bit - otherwise it will print out each time the loop is executed.

[namcintosh]

Your else-if chain only checks to see if the numbers are less than LO, or 1000, and they only do it once, there's no looping, so it only does the first one (100), but doesn't loop back after LO is reset. (If a branch is taken in an if-else statement, the rest of it is disregarded) You should put that in a loop, and you'll have to change your logic a bit - otherwise it will print out each time the loop is executed.

Can you please show me in my program where that goes???

[sicarie]

I tried it with if statements, but all of the numbers printed out as low numbers

Have you tried a while loop? Having it repeat several times, and then exiting only when you're sure it has checked all 4 other values against your lowest?

[sicarie]

Can you please show me in my program where that goes???

I'd recommend sticking it here:

void findLowest(int LO, int score1, int score2, int score3, int score4, int score5)
{
 
        LO = 1000;
 
        if (score1 < LO)
        {
            LO = score1;
            cout << "The lowest score is" <<LO <<endl;
        }
 
        else if (score2 < LO)
        {
            LO = score2;
            cout << "The lowest score is" <<LO <<endl;
        }
        else if (score3 < LO)
        {
            LO = score3;
            cout << "The lowest score is" <<LO <<endl;
        }
        else if (score4 < LO)
        {
            LO = score4;
            cout << "The lowest score is" <<LO <<endl;
        }
        else if (score5 < LO)
        {
            LO = score5;
            cout << "The lowest score is" <<LO <<endl;
        }
}

Then you could change the function definition to return an int - if you loop until you're sure and return it, you can print it out in your main, not have to worry about IO in your function.

[namcintosh]

Have you tried a while loop? Having it repeat several times, and then exiting only when you're sure it has checked all 4 other values against your lowest?

I tried a while loop, but I kept getting an error message

[sicarie]

I tried a while loop, but I kept getting an error message

What's the error?

[namcintosh]

What's the error?

It keeps saying that I am missing a brace

Oh, and I tried that code that you gave me, and it's still doing the same thing. Run my program on your computer and you will see what I am talking about.

[Savage]

You need to use a loop just as sicarie sayed.

LO in call to function is not necsasary and why are u using the largest number instead of smallest,more important is to use a loop like:


int(int score1,int score2,int score3,int score4)
{
int S=score1;//we need to declare one number as smallest
int i=0;//we also need a counter for the loop

//Right here we need a do - while loop wchich will loop until it finds the smallest number(while i<4)

so here goes the loop body:

      if(score2<S) S=score2,i++;continue;
      if(score3<S) S=score3,i++;continue;
      if(score4<S) S=score4,i++;continue;

This way code is smaller and will execute more faster because all those if-else can realy slow down.

Now lets test it:

score1=20;
score2=15;
score3=8;
score4=13;

S=20;

1)15<20 yes,S=15;

2)15<15 no
8<15 yes,S=8;

3) 15<8 no.
8<8 no.
13<8 no.

As we can see smallest number is 8 which is correct.

Savage

[namcintosh]

Why are there four scores instead of five??? There should be five scores