removing duplicates in an array

[joestevens232]

Hello, I'm having a little problem with my code...I have the program written but its just not doing what I want and needs a minor tweak and I've been trying to fix it for ohurs and can't find a solution. I just need to write a function that removes the duplicates in an array. heres my code for main

#include <iostream>
#include "accfuncs.cpp"
using namespace std;
 
void sort(int a[], int h, int a2[], int size);
void printarray(int [], int); //the printarray function declaration             
int main ()
{
    int numbs[20], numbs2[20], r, idx; //declared numbs array and a integer sym\
bolizing the index.                                                             
    cout << "Please enter in a series of numbers ending it with a 0: ";
 
// For loop that takes input from the user of up to 20 numbers and stores them  
// in the numbs array. Also if the user enters a 0 it ends the loop.            
    for(idx = 0; idx < 20; idx++) {
        cin >> numbs[idx];
        if(numbs[idx] == 0) {
            break;  //user entered 0 signifying end of loop                     
        }
    }
    int n = idx; //saves the size of the array to the n variable                
    sort(numbs, r, numbs2, n);
    printarray(numbs2, r - 1); //calls the print array function and itterates i\
t                                                                               
//using numbs                                                                   
    cout << endl; // new line                                                   
}
 

and here my other file which contains the functions:

using namespace std;
 
//printarray definition                                                                 
void printarray(int a[], int size){
    for(int i = size; i > 0; i--)//loop that prints out all values in an array          
        cout << a[i];
}
 
void sort(int a[], int h, int a2[], int size){
    h = 0;
    for (int i = 0; i < size; i++){
        for ( int j = 0; j < size; j++){
            if (a[i] == a2[j]){break;}
            else{
                a[i] = a2[h];
                h++;}
        }
    }
}
 

I believe the problem is somewhere in my sort function..Im not supposed to srt it tho just simply remove the dupes and when I look at it I feel it should do just that but it's not :
If user enters 5 26 22 26 7 8 7 9 5
it should print: 5 26 22 7 8 9 (print each number once)
any help would be greatly appreciated because im seriously stuck

[JosAH]

Hello, I'm having a little problem with my code...I have the program written but its just not doing what I want and needs a minor tweak and I've been trying to fix it for ohurs and can't find a solution. I just need to write a function that removes the duplicates in an array. heres my code for main

#include <iostream>
#include "accfuncs.cpp"
using namespace std;
 
void sort(int a[], int h, int a2[], int size);
void printarray(int [], int); //the printarray function declaration             
int main ()
{
    int numbs[20], numbs2[20], r, idx; //declared numbs array and a integer sym\
bolizing the index.                                                             
    cout << "Please enter in a series of numbers ending it with a 0: ";
 
// For loop that takes input from the user of up to 20 numbers and stores them  
// in the numbs array. Also if the user enters a 0 it ends the loop.            
    for(idx = 0; idx < 20; idx++) {
        cin >> numbs[idx];
        if(numbs[idx] == 0) {
            break;  //user entered 0 signifying end of loop                     
        }
    }
    int n = idx; //saves the size of the array to the n variable                
    sort(numbs, r, numbs2, n);
    printarray(numbs2, r - 1); //calls the print array function and itterates i\
t                                                                               
//using numbs                                                                   
    cout << endl; // new line                                                   
}
 

and here my other file which contains the functions:

using namespace std;
 
//printarray definition                                                                 
void printarray(int a[], int size){
    for(int i = size; i > 0; i--)//loop that prints out all values in an array          
        cout << a[i];
}
 
void sort(int a[], int h, int a2[], int size){
    h = 0;
    for (int i = 0; i < size; i++){
        for ( int j = 0; j < size; j++){
            if (a[i] == a2[j]){break;}
            else{
                a[i] = a2[h];
                h++;}
        }
    }
}
 

I believe the problem is somewhere in my sort function..Im not supposed to srt it tho just simply remove the dupes and when I look at it I feel it should do just that but it's not :
If user enters 5 26 22 26 7 8 7 9 5
it should print: 5 26 22 7 8 9 (print each number once)
any help would be greatly appreciated because im seriously stuck

Take baby steps and separate responsibilitie s; here's a little function that
searches an array (up to element 'n') for a value 'v':

int isPresent(int a[], int v, int n) {
   for (int i= 0; i < n; i++)
      if (a[i] == v) return true;
   return false;
}

... now suppose an array contains the first occurances of elements so far and
suppose you're scanning another array for those first occurances of elements.
I don't think it'll come as a surprise that the following (pseudo) code can do
the job:

void uniques(int a[], int unique[], int size) {
   int u= 0; // no uniques found yet
   for (int i= 0; i < size; i++)
      if (!isPresent(unique, a[i], u)) {
         // add a[i] to array unique
         // and print it
     }
}

kind regards,

Jos

[joestevens232]

for the isPresent function though i don;t know what number im searching for...for the int v...shouldnt i have 2 for loops then to iterate all the number of the array

int isPresent(int a[], int n) {
    for (int i= 0; i < n; i++){
        for (int v = 1; v < n; v++)
        if (a[i] == a[v]) return true;
    return false;
    }
}
 

Im sorry but Im new to C++ this is only my second semester ever using it and I just got the basics barely down.

[Ganon11]

for the isPresent function though i don;t know what number im searching for...for the int v...shouldnt i have 2 for loops then to iterate all the number of the array

int isPresent(int a[], int n) {
    for (int i= 0; i < n; i++){
        for (int v = 1; v < n; v++)
        if (a[i] == a[v]) return true;
    return false;
    }
}
 

Im sorry but Im new to C++ this is only my second semester ever using it and I just got the basics barely down.

In JosAHs version, int n would be the item you are searching for. You would probably call isPresent within a loop, so that every number in a ends up being n in the function at one point. With this taken into consideration, JosAHs solution will work for you.

Your code, however, is closer to what I'd use - with some tweaking, it could work. You're right that you would need two loops - in JosAHs example, the second for loop (the outer one) is supposed to be outside the function, in main(). In your example, you will have both together. Also, your v loop will not work as planned. Suppose you are on the second iteration of the outer loop - that is, i = 1. Since you start the next loop at v = 1, true is returned - a[i] == a[v], because a[i] == a[1] == a[v].

[joestevens232]

In JosAHs version, int n would be the item you are searching for. You would probably call isPresent within a loop, so that every number in a ends up being n in the function at one point. With this taken into consideration, JosAHs solution will work for you.

Your code, however, is closer to what I'd use - with some tweaking, it could work. You're right that you would need two loops - in JosAHs example, the second for loop (the outer one) is supposed to be outside the function, in main(). In your example, you will have both together. Also, your v loop will not work as planned. Suppose you are on the second iteration of the outer loop - that is, i = 1. Since you start the next loop at v = 1, true is returned - a[i] == a[v], because a[i] == a[1] == a[v].

so where should i start v at....0? also im not sure which loop goes in main and how I get n to be every value in the array?

[joestevens232]

heres my main

#include <iostream>
#include "accfuncs.cpp"
using namespace std;
 
int isPresent(int a[], int v, int n);
void uniques(int a[], int unique[], int size);
void printarray(int a[], int size);// function declaration that prints array    
int main ()
{
    int numbs[20], numbs2[20], idx; //declared numbs array and a integer symbol\
izing the index.                                                                
    cout << "Please enter in a series of numbers ending it with a 0: ";
 
// For loop that takes input from the user of up to 20 numbers and stores them  
// in the numbs array. Also if the user enters a 0 it ends the loop.            
    for(idx = 0; idx < 20; idx++) {
        cin >> numbs[idx];
        if(numbs[idx] == 0) {
            break;  //user entered 0 signifying end of loop                     
        }
    }
    int n = idx; //saves the size of the array to the n variable                
    for (i = 0; i < n; i++){
        isPresent(numbs, n, numbs[i]);
    }
    uniques(numbs, numbs2, n);
    printarray(numbs2, n); //call function and print array (numbs)              
    cout << endl; // new line                                                   
}
 

and heres the function file

void printarray(int a[], int size){
    for(int i = 0; i < size; i++)//loop that prints out all values in an array 
        cout << a[i];
}
int isPresent(int a[], int v, int n) {
    for (int i= 0; i < n; i++)
        if (a[i] == v) return true;
    return false;
}
void uniques(int a[], int unique[], int size) {
    int u = 0;// no uniques found yet                                           
    for (int i= 0; i < size; i++)
        if (!isPresent(unique, a[i], u)) {
            a[i] = unique;
        }
}
 

When I try to compile it I get the following errors and Im unsure of what they mean....I tried 80 different things and I always get compiling errors and then when I don't it prints some wacky output but I know the code works without the two function uniques and isPresent. But all it does is take input from the user and outputs it back to the screen without removing the duplicates and that s what Im trying to accompish but Im having minor problems. ALl it needs is a little tweak but Im to inexperienced to see what it is that needs changed. Im up for any help possible. Thank You

heres the compiler errors with that exact code: accfuncs.cpp: In function `void uniques(int*, int*, int)':
accfuncs.cpp:23 : error: invalid conversion from `int*' to `int'
accountant.cpp: In function `int main()':
accountant.cpp: 28: error: `i' was not declared in this scope

[joestevens232]

update i fixed the error in main i didnt have the int i in the for loop. but still need help with what i said before.

[ilikepython]

heres my main

#include <iostream>
#include "accfuncs.cpp"
using namespace std;
 
int isPresent(int a[], int v, int n);
void uniques(int a[], int unique[], int size);
void printarray(int a[], int size);// function declaration that prints array    
int main ()
{
    int numbs[20], numbs2[20], idx; //declared numbs array and a integer symbol\
izing the index.                                                                
    cout << "Please enter in a series of numbers ending it with a 0: ";
 
// For loop that takes input from the user of up to 20 numbers and stores them  
// in the numbs array. Also if the user enters a 0 it ends the loop.            
    for(idx = 0; idx < 20; idx++) {
        cin >> numbs[idx];
        if(numbs[idx] == 0) {
            break;  //user entered 0 signifying end of loop                     
        }
    }
    int n = idx; //saves the size of the array to the n variable                
    for (i = 0; i < n; i++){
        isPresent(numbs, n, numbs[i]);
    }
    uniques(numbs, numbs2, n);
    printarray(numbs2, n); //call function and print array (numbs)              
    cout << endl; // new line                                                   
}
 

and heres the function file

void printarray(int a[], int size){
    for(int i = 0; i < size; i++)//loop that prints out all values in an array 
        cout << a[i];
}
int isPresent(int a[], int v, int n) {
    for (int i= 0; i < n; i++)
        if (a[i] == v) return true;
    return false;
}
void uniques(int a[], int unique[], int size) {
    int u = 0;// no uniques found yet                                           
    for (int i= 0; i < size; i++)
        if (!isPresent(unique, a[i], u)) {
            a[i] = unique;
        }
}
 

When I try to compile it I get the following errors and Im unsure of what they mean....I tried 80 different things and I always get compiling errors and then when I don't it prints some wacky output but I know the code works without the two function uniques and isPresent. But all it does is take input from the user and outputs it back to the screen without removing the duplicates and that s what Im trying to accompish but Im having minor problems. ALl it needs is a little tweak but Im to inexperienced to see what it is that needs changed. Im up for any help possible. Thank You

heres the compiler errors with that exact code: accfuncs.cpp: In function `void uniques(int*, int*, int)':
accfuncs.cpp:23 : error: invalid conversion from `int*' to `int'
accountant.cpp: In function `int main()':
accountant.cpp: 28: error: `i' was not declared in this scope

You're saying "a[i] = unique". "unique" is an array, and you can't assign an array to "a[i]" I believe what you need is a variable to store the current index in "unique". So then you can do "unique[variable_that stores_index] = a[i];" That way you fill unique with the numbers that are not duplicates.
Hope that helped.

[joestevens232]

You're saying "a[i] = unique". "unique" is an array, and you can't assign an array to "a[i]" I believe what you need is a variable to store the current index in "unique". So then you can do "unique[variable_that stores_index] = a[i];" That way you fill unique with the numbers that are not duplicates.
Hope that helped.

WOW that worked only one problem...its getting rid of the duplicates but im gettin some crazy extra output after i enter in some numbers. Their is one minor problem in the code and I can't find it. it compiles fine and does what i want but then additional numbers get output that weren't in the input. heres my code...Please any ideas will help... when i enter in:
3
3
4
5
6
6
7
0
output:
3456758900360

heres my main:

#include <iostream>
#include "accfuncs.cpp"
using namespace std;
 
int isPresent(int a[], int v, int n);
void uniques(int a[], int unique[], int size);
void printarray(int a[], int size);// function declaration that prints array    
int main ()
{
    int numbs[20], numbs2[20], idx; //declared numbs array and a integer symbol\
izing the index.                                                                
    cout << "Please enter in a series of numbers ending it with a 0: ";
 
// For loop that takes input from the user of up to 20 numbers and stores them  
// in the numbs array. Also if the user enters a 0 it ends the loop.            
 
int isPresent(int a[], int v, int n);
void uniques(int a[], int unique[], int size);
void printarray(int a[], int size);// function declaration that prints array    
int main ()
{
    int numbs[20], numbs2[20], idx; //declared numbs array and a integer symbol\
izing the index.                                                                
    cout << "Please enter in a series of numbers ending it with a 0: ";
 
// For loop that takes input from the user of up to 20 numbers and stores them  
// in the numbs array. Also if the user enters a 0 it ends the loop.            
    for(idx = 0; idx < 20; idx++) {
        cin >> numbs[idx];
        if(numbs[idx] == 0) {
            break;  //user entered 0 signifying end of loop                     
        }
    }
    int n = idx; //saves the size of the array to the n variable                
    for (int i = 0; i < n; i++){
        isPresent(numbs, n, numbs[i]);
    }
    uniques(numbs, numbs2, n);
    printarray(numbs2, 7); //call function and print array (numbs)              
    cout << endl; // new line                                                   
}
 
 

heres the functions file

using namespace std;
 
//printarray definition                                                         
void printarray(int a[], int size){
    for(int i = 0; i < size; i++)//loop that prints out all values in an array 
        cout << a[i];
}
int isPresent(int a[], int v, int n) {
    for (int i= 0; i < n; i++)
        if (a[i] == v) return true;
    return false;
}
void uniques(int a[], int unique[], int size) {
    int u = 0;// no uniques found yet                                           
    for (int i= 0; i < size; i++)
        if (!isPresent(unique, a[i], u)) {
            unique[u] = a[i];
            u++;
        }
}
 

[joestevens232]

disregard that last post and for some reaosn i couldn't delete it that was when I was trying some changes of my own...heres the right code i have

its getting rid of the duplicates but im gettin some crazy extra output after i enter in some numbers. Their is one minor problem in the code and I can't find it. it compiles fine and does what i want but then additional numbers get output that weren't in the input. heres my code...Please any ideas will help... when i enter in:
3
3
4
5
6
7
7
8
0
output: 3456780-1075255112

heres my main:

#include <iostream>
#include "accfuncs.cpp"
using namespace std;
 
int isPresent(int a[], int v, int n);
void uniques(int a[], int unique[], int size);
void printarray(int a[], int size);// function declaration that prints array    
int main ()
{
    int numbs[20], numbs2[20], idx; //declared numbs array and a integer symbol\
izing the index.                                                                
    cout << "Please enter in a series of numbers ending it with a 0: ";
 
// For loop that takes input from the user of up to 20 numbers and stores them  
// in the numbs array. Also if the user enters a 0 it ends the loop.            
 
int isPresent(int a[], int v, int n);
void uniques(int a[], int unique[], int size);
void printarray(int a[], int size);// function declaration that prints array    
int main ()
{
    int numbs[20], numbs2[20], idx; //declared numbs array and a integer symbol\
izing the index.                                                                
    cout << "Please enter in a series of numbers ending it with a 0: ";
 
// For loop that takes input from the user of up to 20 numbers and stores them  
// in the numbs array. Also if the user enters a 0 it ends the loop.            
    for(idx = 0; idx < 20; idx++) {
        cin >> numbs[idx];
        if(numbs[idx] == 0) {
            break;  //user entered 0 signifying end of loop                     
        }
    }
    int n = idx; //saves the size of the array to the n variable                
    for (int i = 0; i < n; i++){
        isPresent(numbs, n, numbs[i]);
    }
    uniques(numbs, numbs2, n);
    printarray(numbs2, n); //call function and print array (numbs)              
    cout << endl; // new line                                                   
}
 
 

heres the functions file

using namespace std;
 
//printarray definition                                                         
void printarray(int a[], int size){
    for(int i = 0; i < size; i++)//loop that prints out all values in an array 
        cout << a[i];
}
int isPresent(int a[], int v, int n) {
    for (int i= 0; i < n; i++)
        if (a[i] == v) return true;
    return false;
}
void uniques(int a[], int unique[], int size) {
    int u = 0;// no uniques found yet                                           
    for (int i= 0; i < size; i++)
        if (!isPresent(unique, a[i], u)) {
            unique[u] = a[i];
            u++;
        }
}