Fprintf works in one function but not in the other .

[Smegly]

Hi,

I'm confused about a situation i have ..

fprintf works in one function, but not in the other . .

This is my part of my code for the two functions ..
void customer(FILE *fin, FILE *fout, int msqid, message_buf sbuf, size_t
buf_length, int timer)
----------------------------------------------------------------------------
-----
//printf("%s\n", buff);
time(&now);
fprintf(fout,"--------------------------------------------------\n");
fprintf(fout,"C ustomer %s: %s\rArrival time: %s\r", custRef,
custAction, ctime(&now));

//fprintf(fout,"--------------------------------------------------\n");

----------------------------------------------------------------------------
------

this fprintf works. . .

now this is part of the other function teller()

void teller(FILE *fptr1, message_buf rbuf, int msqid, int i, int Td, int Tw)
----------------------------------------------------------------------------
-----

printf("Custome r statistics for Teller %d\n", getpid());
printf("Servici ng customer %s - Action required %s\n", custNum,
custAct);
fprintf(fout, "Customer statistics for Teller %d\n",getpid()) ;

----------------------------------------------------------------------------
----

this fprintf does not work . .
Does anyone know why this would be the case ?

Matt

[Russell Hanneken]

Smegly wrote:

fprintf(fout, "Customer statistics for Teller %d\n",getpid()) ;

this fprintf does not work . .
In what sense does it "not work?" It doesn't compile? It causes your
program to crash? It prints something you didn't expect?
Does anyone know why this would be the case ?

I can't compile the teller function, because message_buf is an
unrecognized type, and custNum, custAct, and fout haven't been declared
in the scope of the teller function. Is this the same problem you're
experiencing? If not, you need to take out whatever isn't necessary,
and add whatever is necessary, to show us your problem.

--
Russell Hanneken
rg********@pobo x.com
Remove the 'g' from my address to send me mail.

[Vijay Kumar R Zanvar]

"Smegly" <sm****@eftel.n et.au> wrote in message news:40******** @usenet.per.par adox.net.au...

Hi,

I'm confused about a situation i have ..

fprintf works in one function, but not in the other . .

This is my part of my code for the two functions ..
void customer(FILE *fin, FILE *fout, int msqid, message_buf sbuf, size_t
buf_length, int timer)
----------------------------------------------------------------------------
-----
//printf("%s\n", buff);
time(&now);
fprintf(fout,"--------------------------------------------------\n");
fprintf(fout,"C ustomer %s: %s\rArrival time: %s\r", custRef,
custAction, ctime(&now));

I think the carriage return character, '\r', is your culprit.
Try changing it to the newline character, '\n'.
[..]

[Russell Hanneken]

Vijay Kumar R Zanvar wrote:

"Smegly" <sm****@eftel.n et.au> wrote in message news:40******** @usenet.per.par adox.net.au...

fprintf works in one function, but not in the other . .

This is my part of my code for the two functions ..
void customer(FILE *fin, FILE *fout, int msqid, message_buf sbuf, size_t
buf_length, int timer)
----------------------------------------------------------------------------
-----
//printf("%s\n", buff);
time(&now);
fprintf(fout,"--------------------------------------------------\n");
fprintf(fout,"C ustomer %s: %s\rArrival time: %s\r", custRef,
custAction, ctime(&now));

I think the carriage return character, '\r', is your culprit.
Try changing it to the newline character, '\n'.

You snipped the line where he says "this fprintf works." He says the
problem is with the second fprintf statement in his post, which is in
another function.

--
Russell Hanneken
rg********@pobo x.com
Remove the 'g' from my address to send me mail.

[Matthew Jakeman]

In the second function you do fprintf(fout, ...) ;
Where is fout defined, in the first function it is clearly defined but I
can't see it defined in the second one?
Good Luck!
The Fat Man
"Smegly" <sm****@eftel.n et.au> wrote in message
news:40******** @usenet.per.par adox.net.au...

Hi,

I'm confused about a situation i have ..

fprintf works in one function, but not in the other . .

This is my part of my code for the two functions ..
void customer(FILE *fin, FILE *fout, int msqid, message_buf sbuf, size_t
buf_length, int timer)
-------------------------------------------------------------------------- -- -----
//printf("%s\n", buff);
time(&now);
fprintf(fout,"--------------------------------------------------\n"); fprintf(fout,"C ustomer %s: %s\rArrival time: %s\r", custRef,
custAction, ctime(&now));

//fprintf(fout,"--------------------------------------------------\n");

-------------------------------------------------------------------------- -- ------

this fprintf works. . .

now this is part of the other function teller()

void teller(FILE *fptr1, message_buf rbuf, int msqid, int i, int Td, int Tw) -------------------------------------------------------------------------- -- -----

printf("Custome r statistics for Teller %d\n", getpid());
printf("Servici ng customer %s - Action required %s\n", custNum,
custAct);
fprintf(fout, "Customer statistics for Teller %d\n",getpid()) ;

-------------------------------------------------------------------------- -- ----

this fprintf does not work . .
Does anyone know why this would be the case ?

Matt

[Smegly]

sorry i corrected the code in the editor ..

The void teller(FILE *fptr1, message_buf rbuf, int msqid, int i, int Td, int
Tw)

is actually FILE *fout, etc ... )

the statement does not add any thing to the simulation_log file.

Matt
"Matthew Jakeman" <m.*******@nosp am.lancaster.ac .uk> wrote in message
news:c8******** **@alliance.lan cs.ac.uk...

In the second function you do fprintf(fout, ...) ;
Where is fout defined, in the first function it is clearly defined but I
can't see it defined in the second one?
Good Luck!
The Fat Man
"Smegly" <sm****@eftel.n et.au> wrote in message
news:40******** @usenet.per.par adox.net.au...

Hi,

I'm confused about a situation i have ..

fprintf works in one function, but not in the other . .

This is my part of my code for the two functions ..
void customer(FILE *fin, FILE *fout, int msqid, message_buf sbuf, size_t buf_length, int timer)

--------------------------------------------------------------------------
--

-----
//printf("%s\n", buff);
time(&now);

fprintf(fout,"--------------------------------------------------\n");

fprintf(fout,"C ustomer %s: %s\rArrival time: %s\r", custRef,
custAction, ctime(&now));

//fprintf(fout,"--------------------------------------------------\n");

--------------------------------------------------------------------------
--

------

this fprintf works. . .

now this is part of the other function teller()

void teller(FILE *fptr1, message_buf rbuf, int msqid, int i, int Td, int

Tw)

--------------------------------------------------------------------------
--

-----

printf("Custome r statistics for Teller %d\n", getpid());
printf("Servici ng customer %s - Action required %s\n", custNum,
custAct);
fprintf(fout, "Customer statistics for Teller %d\n",getpid()) ;

--------------------------------------------------------------------------
--

----

this fprintf does not work . .
Does anyone know why this would be the case ?

Matt

[Karthik]

Smegly wrote:

sorry i corrected the code in the editor ..

The void teller(FILE *fptr1, message_buf rbuf, int msqid, int i, int Td, int
Tw)

is actually FILE *fout, etc ... )

the statement does not add any thing to the simulation_log file.

Matt

Seems like you had a global variable by name - fout .
See, now you have got a valid reason why you should try to avoid global
variables as far as possible.

--
Karthik.
Humans please 'removeme_' for my real email.

[Mario Charest]

>

The void teller(FILE *fptr1, message_buf rbuf, int msqid, int i, int Td, int Tw)

is actually FILE *fout, etc ... )

the statement does not add any thing to the simulation_log file.

Matt

Test the return value of fprintf (yes you can do that), I expect it to
return an error then check errno. Most likely the file handle fout is
invalid. Also make sure getpid() has its prototype included.

[Dan Pop]

In <A2************ ********@wagner .videotron.net> "Mario Charest" <po********@127 .0.0.1> writes:

The void teller(FILE *fptr1, message_buf rbuf, int msqid, int i, int Td,

int

Tw)

is actually FILE *fout, etc ... )

the statement does not add any thing to the simulation_log file.

Matt

Test the return value of fprintf (yes you can do that), I expect it to
return an error then check errno. Most likely the file handle fout is
invalid.

Then, the fprintf call invokes undefined behaviour and all the bets are
off.

Dan
--
Dan Pop
DESY Zeuthen, RZ group
Email: Da*****@ifh.de