initialization of a struct in a vector

[Jayw710]

hi all,

this should be basic, but I can't seem to get the right syntax.

i have a struct

struct PTStruct
{
int x;
int y;
};

class abc
{
public:
abc();
...

std::vector<PTS truct> mypoints;
}

void abc::abc() : mypoints(100)
{

}
and i'm trying to get all the PTStruct variables (x and y) in mypoints to be
initialized to zero, but I'm screwing up the syntax somehow.

Any suggestions how this should be done?

Thanks to all!

Jay

[Shezan Baig]

Jayw710 wrote:

hi all,

this should be basic, but I can't seem to get the right syntax.

i have a struct

struct PTStruct
{
int x;
int y;
add a ctor here. Ctors are always useful, even in structs:

PTStruct(int initX, int initY) : x(initX), y(initY) { }

};

class abc
{
public:
abc();
...

std::vector<PTS truct> mypoints;
}

void abc::abc() : mypoints(100)

change this to:

void abc::abc() : mypoints(100, PTStruct(0, 0))

Hope this helps,
-shez-
{

}
and i'm trying to get all the PTStruct variables (x and y) in mypoints to be initialized to zero, but I'm screwing up the syntax somehow.

Any suggestions how this should be done?

Thanks to all!

Jay

[Andrey Tarasevich]

Jayw710 wrote:

...
i have a struct

struct PTStruct
{
int x;
int y;
};

class abc
{
public:
abc();
...

std::vector<PTS truct> mypoints;
}

void abc::abc() : mypoints(100)
'void'??? Constructors have no return type. Should be just

abc::abc() : mypoints(100)
{

}
and i'm trying to get all the PTStruct variables (x and y) in mypoints to be
initialized to zero, but I'm screwing up the syntax somehow.

Any suggestions how this should be done?
...

You don't need to do anything. The code above already initializes all
field in all structs to zero. If your compiler doesn't do that, it's broken.

--
Best regards,
Andrey Tarasevich

[Shezan Baig]

Andrey Tarasevich wrote:

Jayw710 wrote:

...
i have a struct

struct PTStruct
{
int x;
int y;
};

class abc
{
public:
abc();
...

std::vector<PTS truct> mypoints;
}

void abc::abc() : mypoints(100)
'void'??? Constructors have no return type. Should be just

abc::abc() : mypoints(100)

{

}
and i'm trying to get all the PTStruct variables (x and y) in mypoints to be initialized to zero, but I'm screwing up the syntax somehow.

Any suggestions how this should be done?
...

You don't need to do anything. The code above already initializes all
field in all structs to zero. If your compiler doesn't do that, it's

broken.

Doesn't it depend where the vector gets its memory from?

[Andrey Tarasevich]

Shezan Baig wrote:

Andrey Tarasevich wrote:

Jayw710 wrote:

> ...
> i have a struct
>
> struct PTStruct
> {
> int x;
> int y;
> };
>
> class abc
> {
> public:
> abc();
> ...
>
> std::vector<PTS truct> mypoints;
> }
>
> void abc::abc() : mypoints(100)

'void'??? Constructors have no return type. Should be just

abc::abc() : mypoints(100)

> {
>
> }
>
>
> and i'm trying to get all the PTStruct variables (x and y) in mypoints to be > initialized to zero, but I'm screwing up the syntax somehow.
>
> Any suggestions how this should be done?
> ...

You don't need to do anything. The code above already initializes all
field in all structs to zero. If your compiler doesn't do that, it's

broken.

Doesn't it depend where the vector gets its memory from?

No. Why?

Initializing this vector as 'mypoints(100)' is equivalent to
initializing it as 'mypoints(100, PTStruct(),
std::allocator< PTStruct>())' (default arguments get implicitly
filled-in), which means that all freshly created elements are
copy-initialized from 'PTStruct()'. And 'PTStruct()' is an instance of
'PTStruct' with both fields set to 0.

--
Best regards,
Andrey Tarasevich

[Jayw710]

>

add a ctor here. Ctors are always useful, even in structs:

PTStruct(int initX, int initY) : x(initX), y(initY) { }

Thank you, this is what I was missing. I knew I had left something out (my
compiler VC++ doesn't initialize anything to zero in the structs).

Thanks again!

Jay

[Shezan Baig]

Jayw710 wrote:

add a ctor here. Ctors are always useful, even in structs:

PTStruct(int initX, int initY) : x(initX), y(initY) { }

Thank you, this is what I was missing. I knew I had left something

out (my compiler VC++ doesn't initialize anything to zero in the structs).

Thanks again!

Jay

Also you might want to set default arguments, like this:

PTStruct(int initX = 0, int initY = 0) : x(initX), y(initY) { }

And you can simplify your containers constructor to how it was
originally:

abc::abc() : mypoints(100) { }

That way, even if you don't use the standard allocator, it will always
initialize to zero.

Hope this helps,
-shez-

[davidrubin]

Shez, what does the allocator have to do with the values used to
initialize concrete data members? Nothing... /david

[Shezan Baig]

da********@warp mail.net wrote:

Shez, what does the allocator have to do with the values used to
initialize concrete data members? Nothing... /david

Yes, you are right. Sorry, for some reason, my mind was on dynamic
memory :)

-shez-

[Real Name]

> And 'PTStruct()' is an instance of

'PTStruct' with both fields set to 0.

Why? PTStruct only contains PODs - their default ctors wont we called
implicit, you have to call them explicit in your own ctor.

regards,
me