Problem writing parametrized query

[weird0]

Hi!

On the recommendation of one of the MVP's on this group....... I tried
writing parametrized queries. But the fucking thing does not work and
it does not update the data in the table.
I gotta do my work by concatenation right now. But what is wrong with
the code anyway?

Can anyone figure out.

public static bool Change_CC_Pinco de(string userName, string
Pincode)
{
string query = "UPDATE CreditCard SET cc_pincode=@PIN CODE
WHERE username=@USERN AME";
SqlConnection cn = new SqlConnection(c onnectionString );
// Create a new SQL Command object with our query
// Note the syntax for our parameter field, "first"
SqlCommand sqlCommand = new SqlCommand(quer y, cn);

sqlCommand.Para meters.Add("@PI NCODE", SqlDbType.Int). Value
= Pincode;
sqlCommand.Para meters.Add("@US ERNAME",
SqlDbType.VarCh ar).Value =userName.ToCha rArray();
cn.Open();
int result = sqlCommand.Exec uteNonQuery();

// Close Reader and Connection.
cn.Close();
if (result 0)
return true;
else
return false;

}

Regards
Generous for your help

[sonicwrx]

On Apr 17, 11:48 am, weird0 <amiredi...@gma il.comwrote:

Hi!

On the recommendation of one of the MVP's on this group....... I tried
writing parametrized queries. But the fucking thing does not work and
it does not update the data in the table.
I gotta do my work by concatenation right now. But what is wrong with
the code anyway?

Can anyone figure out.

public static bool Change_CC_Pinco de(string userName, string
Pincode)
{
string query = "UPDATE CreditCard SET cc_pincode=@PIN CODE
WHERE username=@USERN AME";
SqlConnection cn = new SqlConnection(c onnectionString );

// Create a new SQL Command object with our query
// Note the syntax for our parameter field, "first"
SqlCommand sqlCommand = new SqlCommand(quer y, cn);

sqlCommand.Para meters.Add("@PI NCODE", SqlDbType.Int). Value
= Pincode;
sqlCommand.Para meters.Add("@US ERNAME",
SqlDbType.VarCh ar).Value =userName.ToCha rArray();
cn.Open();
int result = sqlCommand.Exec uteNonQuery();

// Close Reader and Connection.
cn.Close();
if (result 0)
return true;
else
return false;

}

Regards
Generous for your help

In the code I have written I have not used the @ sign in the variable
names when adding the parameters and it has worked. For example, drop
the @ in the line

sqlCommand.Para meters.Add("@PI NCODE", SqlDbType.Int). Value = Pincode;

to

sqlCommand.Para meters.Add("PIN CODE", SqlDbType.Int). Value = Pincode;

Perhaps it will work or atleast get you to your next error!

[Patrick H]

public static bool Change_CC_Pinco de(string userName, string
Pincode)
{
SqlConnection conn = null;
int result = -1;
try
{
conn = new SqlConnection(c onnectionString );
SqlCommand command = conn.CreateComm and();
command.Command Text = "UPDATE CreditCard SET
cc_pincode=@PIN CODE WHERE
username=@USERN AME";

command.Paramet ers.AddWithValu e("@PINCODE", Pincode);
command.Paramet ers.AddWithValu e("@USERNAME" userName);
conn.Open();

result = command.Execute NonQuery();

}
catch( Exception ex )
{
//woopsie
}
finally
{
if( conn != null ) conn.Close();
return result 0;
}
}