does anyone see what is wrong with my .gif download logic? no matter what image url i try it downloads a junk file that can't be opened in any paint program.

[dr]

does anyone see what is wrong with my .gif download logic? no matter what
image url i try it downloads a junk file that can't be opened in any paint
program.
System.Net.WebR equest myRequest = System.Net.WebR equest.Create(u rl);
System.Net.WebR esponse myResponse = myRequest.GetRe sponse();
System.IO.Strea m imgStream = myResponse.GetR esponseStream() ;
long len = myResponse.Cont entLength;
byte[] binarydata = new byte[len];
System.IO.Strea m streambinary = myResponse.GetR esponseStream() ;
streambinary.Re ad(binarydata, 0, (int)len);
using(System.IO .BinaryWriter binWriter = new
System.IO.Binar yWriter(System. IO.File.Open(@" C:\foo.gif",
System.IO.FileM ode.Create)))
{
binWriter.Write (binarydata, 0, (int)len);
}

[=?ISO-8859-1?Q?G=F6ran_Andersson?=]

dr wrote:

does anyone see what is wrong with my .gif download logic? no matter what
image url i try it downloads a junk file that can't be opened in any paint
program.
System.Net.WebR equest myRequest = System.Net.WebR equest.Create(u rl);
System.Net.WebR esponse myResponse = myRequest.GetRe sponse();
System.IO.Strea m imgStream = myResponse.GetR esponseStream() ;
long len = myResponse.Cont entLength;
byte[] binarydata = new byte[len];
System.IO.Strea m streambinary = myResponse.GetR esponseStream() ;
streambinary.Re ad(binarydata, 0, (int)len);
using(System.IO .BinaryWriter binWriter = new
System.IO.Binar yWriter(System. IO.File.Open(@" C:\foo.gif",
System.IO.FileM ode.Create)))
{
binWriter.Write (binarydata, 0, (int)len);
}

You read the data from the stream without considering the result. The
Read method returns an integer that is the number of bytes actually
read, which may be smaller than the number of bytes requested.

When you read the data, the buffer will only be partially filled with
data, then you save the entire buffer as if it all contained valid data.
This will produce a broken file.

You have to get the return value from the Read call and use that to
determine how much data you have gotten, and loop until you have got all
the data.

--
Göran Andersson
_____
http://www.guffa.com

[Michael C]

Please don't multipost.

[Thomas Due]

Michael C wrote:

>Please don't multipost.

One should think, this kind of reply would only be necessary in one group and not both...

--
Thomas Due
Posted with XanaNews version 1.18.1.6

"A military operation involves deception. Even though you are
competent, appear to be incompetent. Though effective, appear
to be ineffective."
-- Sun-tzu, The Art of War. Strategic Assessments

[Ignacio Machin \( .NET/ C# MVP \)]

Hi,

"dr" <so************ *******@yahoo.c omwrote in message
news:eV******** ********@TK2MSF TNGP06.phx.gbl. ..

does anyone see what is wrong with my .gif download logic? no matter what
image url i try it downloads a junk file that can't be opened in any paint
program.

Use this code

HttpWebRequest request = (HttpWebRequest ) WebRequest.Crea te(
"http://www..com/update.zip");
HttpWebResponse response =(HttpWebRespon se) request.GetResp onse();
Stream source = response.GetRes ponseStream();
string targetFile = Config.CodeBase + "\\" +
DateTime.Now.Ti cks.ToString() + ".zip";
FileStream writer = new FileStream( targetFile, FileMode.Create );
byte[] buffer = new byte[4098];
int readed=0;
while( (readed=source. Read( buffer, 0, 4098))>0)
{
writer.Write( buffer, 0, readed);
}
writer.Close();
source.Close();

[Michael C]

"Thomas Due" <tdue@mail_remo ve_.dkwrote in message
news:%2******** **********@TK2M SFTNGP02.phx.gb l...

One should think, this kind of reply would only be necessary in one group
and not both...

Shouldn't both groups know that maybe the question has been answered
elsewhere?

--
Thomas Due
Posted with XanaNews version 1.18.1.6

"A military operation involves deception. Even though you are
competent, appear to be incompetent. Though effective, appear
to be ineffective."
-- Sun-tzu, The Art of War. Strategic Assessments

[Otis Mukinfus]

On Mon, 19 Feb 2007 06:09:25 -0800, "Thomas Due" <tdue@mail_remo ve_.dkwrote:

>Michael C wrote:

>>Please don't multipost.

One should think, this kind of reply would only be necessary in one group and not both...

Long live Sun-tzu
and Clausewitz too.

Good luck with your project,

Otis Mukinfus

http://www.otismukinfus.com
http://www.arltex.com
http://www.tomchilders.com
http://www.n5ge.com