SocketException : Too many open files - can't understand why though?

[Lee]

Hey all, I'm using the following code to send stuff accross the
network, appologies for it being in full, but I've really no idea
exactly where this error is occuring.

=======network code=========== =

using System;
using System.Net;
using System.Net.Sock ets;
using System.Threadin g;
using System.Windows. Forms;
using System.Componen tModel;
using System.Text;
using System.IO;
//Class for actually sending data accross the network
//should be used by parser.cs and perhaps a few forms
namespace FINN
{
public delegate void DataRecivedHand ler(object sender, DataEventArgs
e);
public class DataEventArgs : EventArgs
{
public string data;
public bool corGuess;
public TcpClient client = new TcpClient();
public DataEventArgs(s tring data)
{
this.data = data;
this.corGuess = false;
}
public DataEventArgs(s tring data, bool corGuess)
{
this.data =data;
this.corGuess = corGuess;
}
public DataEventArgs(s tring data, TcpClient client)
{
this.data = data;
this.client = client;
}
}
public class tcpClient
{
public event DataRecivedHand ler DataReceived;
private string gameip;
//private userObject user;
private TcpClient Client;
private StreamWriter SW;
private StreamReader SR;
public bool connected = false;
public tcpClient(strin g gameip)
{
bool error =false;
this.gameip = gameip;
Console.WriteLi ne(gameip.ToStr ing());
//this.user = user;
Client = new TcpClient();
try
{
Client.Connect( gameip, 9090);
}
catch (Exception e)
{
Console.WriteLi ne(e.ToString() );
error =true;
}
if(!error)
{
connected = true;
Thread t = new Thread(new ThreadStart(rec Data));
t.Start();
}
SW = new StreamWriter(Cl ient.GetStream( ));
SR = new StreamReader(Cl ient.GetStream( ));
Console.WriteLi ne("New files created");
}
public void sendData(string data)
{
SW.AutoFlush = true;
SW.WriteLine(da ta);
SW.Flush();
//SW.Close()
}
private void recData()
{
//NetworkStream NR = Client.GetStrea m();

while(true)
{
try
{
string data = SR.ReadLine();
//onsole.WriteLin e("Client Recived: " + data);
DataEventArgs dea = new DataEventArgs(d ata);
if(data != null)
{
DataReceived(th is, dea);
}
}
catch
{
}

}
SR.Close();
}
public void Disconnect()
{
Client.Close();
}
}

}
=======network code=========== =
This works fine for the most part, but when sendData gets called
repeatedly it causes it to throw the following exception and crash out:

System.Net.Sock ets.SocketExcep tion: Too many open files
at System.Net.Sock ets.Socket..cto r (AddressFamily family, SocketType
type, ProtocolType proto) [0x00000]
at System.Net.Sock ets.TcpClient.I nit (AddressFamily family) [0x00000]
at System.Net.Sock ets.TcpClient.. ctor () [0x00000]
at FINN.DataEventA rgs..ctor (System.String data) [0x00000]
at FINN.frmGame.pi cMainDrawArea_m ouseMove (System.Object sender,
System.Windows. Forms.MouseEven tArgs e) [0x00000]
at (wrapper delegate-invoke)
System.Multicas tDelegate:invok e_void_object_M ouseEventArgs
(object,System. Windows.Forms.M ouseEventArgs)
at System.Windows. Forms.Control.O nMouseMove
(System.Windows .Forms.MouseEve ntArgs e) [0x00000]
at System.Windows. Forms.Control.W ndProc
(System.Windows .Forms.Message& m) [0x00000]
at System.Windows. Forms.Control+C ontrolNativeWin dow.WndProc
(System.Windows .Forms.Message& m) [0x00000]
at System.Windows. Forms.NativeWin dow.WndProc (IntPtr hWnd, Msg msg,
IntPtr wParam, IntPtr lParam) [0x00000]
I really can't figure out why this is occuring and was wondering if
anyone was able to help me improve my code and show me where it's wrong
(and why!) so that I can stop this from occuring.
Cheers all
Lee

[Nicholas Paldino [.NET/C# MVP]]

Lee,

It's impossible to tell. You aren't even showing how you are using the
class.

Also, why not just use the TcpClient class that the framework provides?

Hope this helps.
--
- Nicholas Paldino [.NET/C# MVP]
- mv*@spam.guard. caspershouse.co m

"Lee" <lv******@gmail .comwrote in message
news:11******** **************@ 16g2000cwy.goog legroups.com...

Hey all, I'm using the following code to send stuff accross the
network, appologies for it being in full, but I've really no idea
exactly where this error is occuring.

=======network code=========== =

using System;
using System.Net;
using System.Net.Sock ets;
using System.Threadin g;
using System.Windows. Forms;
using System.Componen tModel;
using System.Text;
using System.IO;
//Class for actually sending data accross the network
//should be used by parser.cs and perhaps a few forms
namespace FINN
{
public delegate void DataRecivedHand ler(object sender, DataEventArgs
e);
public class DataEventArgs : EventArgs
{
public string data;
public bool corGuess;
public TcpClient client = new TcpClient();
public DataEventArgs(s tring data)
{
this.data = data;
this.corGuess = false;
}
public DataEventArgs(s tring data, bool corGuess)
{
this.data =data;
this.corGuess = corGuess;
}
public DataEventArgs(s tring data, TcpClient client)
{
this.data = data;
this.client = client;
}
}
public class tcpClient
{
public event DataRecivedHand ler DataReceived;
private string gameip;
//private userObject user;
private TcpClient Client;
private StreamWriter SW;
private StreamReader SR;
public bool connected = false;
public tcpClient(strin g gameip)
{
bool error =false;
this.gameip = gameip;
Console.WriteLi ne(gameip.ToStr ing());
//this.user = user;
Client = new TcpClient();
try
{
Client.Connect( gameip, 9090);
}
catch (Exception e)
{
Console.WriteLi ne(e.ToString() );
error =true;
}
if(!error)
{
connected = true;
Thread t = new Thread(new ThreadStart(rec Data));
t.Start();
}
SW = new StreamWriter(Cl ient.GetStream( ));
SR = new StreamReader(Cl ient.GetStream( ));
Console.WriteLi ne("New files created");
}
public void sendData(string data)
{
SW.AutoFlush = true;
SW.WriteLine(da ta);
SW.Flush();
//SW.Close()
}
private void recData()
{
//NetworkStream NR = Client.GetStrea m();

while(true)
{
try
{
string data = SR.ReadLine();
//onsole.WriteLin e("Client Recived: " + data);
DataEventArgs dea = new DataEventArgs(d ata);
if(data != null)
{
DataReceived(th is, dea);
}
}
catch
{
}

}
SR.Close();
}
public void Disconnect()
{
Client.Close();
}
}

}
=======network code=========== =
This works fine for the most part, but when sendData gets called
repeatedly it causes it to throw the following exception and crash out:

System.Net.Sock ets.SocketExcep tion: Too many open files
at System.Net.Sock ets.Socket..cto r (AddressFamily family, SocketType
type, ProtocolType proto) [0x00000]
at System.Net.Sock ets.TcpClient.I nit (AddressFamily family) [0x00000]
at System.Net.Sock ets.TcpClient.. ctor () [0x00000]
at FINN.DataEventA rgs..ctor (System.String data) [0x00000]
at FINN.frmGame.pi cMainDrawArea_m ouseMove (System.Object sender,
System.Windows. Forms.MouseEven tArgs e) [0x00000]
at (wrapper delegate-invoke)
System.Multicas tDelegate:invok e_void_object_M ouseEventArgs
(object,System. Windows.Forms.M ouseEventArgs)
at System.Windows. Forms.Control.O nMouseMove
(System.Windows .Forms.MouseEve ntArgs e) [0x00000]
at System.Windows. Forms.Control.W ndProc
(System.Windows .Forms.Message& m) [0x00000]
at System.Windows. Forms.Control+C ontrolNativeWin dow.WndProc
(System.Windows .Forms.Message& m) [0x00000]
at System.Windows. Forms.NativeWin dow.WndProc (IntPtr hWnd, Msg msg,
IntPtr wParam, IntPtr lParam) [0x00000]
I really can't figure out why this is occuring and was wondering if
anyone was able to help me improve my code and show me where it's wrong
(and why!) so that I can stop this from occuring.
Cheers all
Lee

[Peter Duniho]

"Lee" <lv******@gmail .comwrote in message
news:11******** **************@ 16g2000cwy.goog legroups.com...

[...]
System.Net.Sock ets.SocketExcep tion: Too many open files
at System.Net.Sock ets.Socket..cto r (AddressFamily family, SocketType
type, ProtocolType proto) [0x00000]
at System.Net.Sock ets.TcpClient.I nit (AddressFamily family) [0x00000]
at System.Net.Sock ets.TcpClient.. ctor () [0x00000]
at FINN.DataEventA rgs..ctor (System.String data) [0x00000]
at FINN.frmGame.pi cMainDrawArea_m ouseMove (System.Object sender,
System.Windows. Forms.MouseEven tArgs e) [0x00000]
at (wrapper delegate-invoke)
[...]
I really can't figure out why this is occuring and was wondering if
anyone was able to help me improve my code and show me where it's wrong
(and why!) so that I can stop this from occuring.

Just a guess, but I suspect that you have too many files open.

It's hard for me to read the code you posted, as there's no indentation at
all, and it's not clear that you've actually posted a good sample (e.g.
minimal code required to *fully* reproduce the issue). However, creating a
TcpClient inside your mouse-move event handler is a little odd. Mouse-moves
happen all the time...I don't see any legitimate reason to create a new
TcpClient each time one happens, even if one does assume that those
TcpClients are properly cleaned up (and given the error you're getting, it
seems they may not be).

So, rather than creating a new TcpClient every time you instantiate a
DataEventArgs, perhaps it would be better for you to create a TcpClient
once, and then supply that to the DataEventArgs constructor, or otherwise
gain access to it.

I suppose you could keep doing it the way you're doing it now, as long as
you added an explicit Close/Dispose method to the DataEventArgs class and
called that everywhere that you create a DataEventArgs and then are done
using it. But that's a pain, and it ignores the fact that creating a new
TcpClient every time you move the mouse is still a bad idea.

Pete

[Lee]

Humm, sorry it is tab-indented here... guess it got lost in the post
somehow.

To clear things up, this class isn't instantiated when mouse move is
called, only it's 'sendData' method is called then.

The reason I'm not using TcpClient class is because, well, this is
merely a wrapper to it, to encapsulate reciving data and have an
appropriate event triggered.

If required I could re-post this class onto a paste-bin and hopefully
tab indenting would be preserved?

Peter Duniho wrote:

"Lee" <lv******@gmail .comwrote in message
news:11******** **************@ 16g2000cwy.goog legroups.com...

[...]
System.Net.Sock ets.SocketExcep tion: Too many open files
at System.Net.Sock ets.Socket..cto r (AddressFamily family, SocketType
type, ProtocolType proto) [0x00000]
at System.Net.Sock ets.TcpClient.I nit (AddressFamily family) [0x00000]
at System.Net.Sock ets.TcpClient.. ctor () [0x00000]
at FINN.DataEventA rgs..ctor (System.String data) [0x00000]
at FINN.frmGame.pi cMainDrawArea_m ouseMove (System.Object sender,
System.Windows. Forms.MouseEven tArgs e) [0x00000]
at (wrapper delegate-invoke)
[...]
I really can't figure out why this is occuring and was wondering if
anyone was able to help me improve my code and show me where it's wrong
(and why!) so that I can stop this from occuring.

Just a guess, but I suspect that you have too many files open.

It's hard for me to read the code you posted, as there's no indentation at
all, and it's not clear that you've actually posted a good sample (e.g.
minimal code required to *fully* reproduce the issue). However, creating a
TcpClient inside your mouse-move event handler is a little odd. Mouse-moves
happen all the time...I don't see any legitimate reason to create a new
TcpClient each time one happens, even if one does assume that those
TcpClients are properly cleaned up (and given the error you're getting, it
seems they may not be).

So, rather than creating a new TcpClient every time you instantiate a
DataEventArgs, perhaps it would be better for you to create a TcpClient
once, and then supply that to the DataEventArgs constructor, or otherwise
gain access to it.

I suppose you could keep doing it the way you're doing it now, as long as
you added an explicit Close/Dispose method to the DataEventArgs class and
called that everywhere that you create a DataEventArgs and then are done
using it. But that's a pain, and it ignores the fact that creating a new
TcpClient every time you move the mouse is still a bad idea.

Pete

[Chris Dunaway]

Hey all, I'm using the following code to send stuff accross the

network, appologies for it being in full, but I've really no idea
exactly where this error is occuring.

while(true)
{
try
{
string data =
SR.ReadLine();

//onsole.WriteLin e("Client Recived: " + data);
DataEventArgs
dea = new DataEventArgs(d ata);
if(data !=
null)
{

DataReceived(th is, dea);
}
}
catch
{
}

}

Your while loop is infinite. Every time through the loop, you create a
new instance of DataEventArgs. Inside that class, you create a new
instance of the TcpClient class. I suspect that is why, but I'm not
sure.

Chris

[Peter Duniho]

"Lee" <lv******@gmail .comwrote in message
news:11******** *************@f 1g2000cwa.googl egroups.com...

Humm, sorry it is tab-indented here... guess it got lost in the post
somehow.

To clear things up, this class isn't instantiated when mouse move is
called, only it's 'sendData' method is called then.

Well, the stack trace you posted says otherwise.

You may think that you aren't instantiating a DataEventArgs object when your
picMainDrawArea _mouseMove method is called, but you clearly are. Since you
didn't post that code, I don't know for sure whether it's EVERY time that
method is called, but I suspect it is. Either way, it's a problem.

I also agree with Chris's comment about your while() loop in your recData
method. That is another place you are creating DataEventArgs objects, and
if you execute that loop frequently enough, those objects might not get
cleaned up quickly enough to avoid having too many files open.

That said, the exception occurs while creating a DataEventArgs object inside
your picMainDrawArea _mouseMove method. So that's the first place you need
to look.

Pete

[Lee]

Thanks all, I'll check it out when I'm back at work tomorrow and post
back how I get on.
Peter Duniho wrote:

"Lee" <lv******@gmail .comwrote in message
news:11******** *************@f 1g2000cwa.googl egroups.com...

Humm, sorry it is tab-indented here... guess it got lost in the post
somehow.

To clear things up, this class isn't instantiated when mouse move is
called, only it's 'sendData' method is called then.

Well, the stack trace you posted says otherwise.

You may think that you aren't instantiating a DataEventArgs object when your
picMainDrawArea _mouseMove method is called, but you clearly are. Since you
didn't post that code, I don't know for sure whether it's EVERY time that
method is called, but I suspect it is. Either way, it's a problem.

I also agree with Chris's comment about your while() loop in your recData
method. That is another place you are creating DataEventArgs objects, and
if you execute that loop frequently enough, those objects might not get
cleaned up quickly enough to avoid having too many files open.

That said, the exception occurs while creating a DataEventArgs object inside
your picMainDrawArea _mouseMove method. So that's the first place you need
to look.

Pete

[Lee]

Changing

public TcpClient client = new TcpClient();

to

public TcpClient client;

Fixed the problem, thanks all! :-)

(The rest of the code is probably still rubbish, but at least it works
now)