Combine functions into 1

[tshad]

I have about 10 functions that are identical except for one variable name
that I am using in my "for" loop:

for (ktr1=1;ktr1<=n hDataBean.proje ctCodeList.GetU pperBound(0);kt r1++)
for (ktr1=1;ktr1<=n hDataBean.shift CodeList.GetUpp erBound(0);ktr1 ++)
for (ktr1=1;ktr1<=n hDataBean.statu sCodeList.GetUp perBound(0);ktr 1++)

How can I change the "nhDataBean.xxx .GetUpperBound( 0)" so that I can use
only one function?

The code functions and how they are called:

*************** *************** *************** *************** ****
public void GetProjects(Dat aTable dt)
{
int ktr1 = 0;
DataRow dr;
// Add the columns to the DataTable's Columns collection
dt.Columns.Add( "code");
dt.Columns.Add( "descriptio n");

for (ktr1=1;ktr1<=n hDataBean.proje ctCodeList.GetU pperBound(0);kt r1++)
{
dr = dt.NewRow();
dr["code"] = nhDataBean.proj ectCodeList[ktr1][0];
dr["descriptio n"] = nhDataBean.proj ectCodeList[ktr1][1];
dt.Rows.Add(dr) ;
}
}

public void GetShifts(DataT able dt)
{
int ktr1 = 0;
DataRow dr;
// Add the columns to the DataTable's Columns collection
dt.Columns.Add( "code");
dt.Columns.Add( "descriptio n");

for (ktr1=1;ktr1<=n hDataBean.shift CodeList.GetUpp erBound(0);ktr1 ++)
{
dr = dt.NewRow();
dr["code"] = nhDataBean.shif tCodeList[ktr1][0];
dr["descriptio n"] = nhDataBean.shif tCodeList[ktr1][1];
dt.Rows.Add(dr) ;
}
}

public void GetStatus(DataT able dt)
{
int ktr1 = 0;
DataRow dr;
// Add the columns to the DataTable's Columns collection
dt.Columns.Add( "code");
dt.Columns.Add( "descriptio n");

for (ktr1=1;ktr1<=n hDataBean.statu sCodeList.GetUp perBound(0);ktr 1++)
{
dr = dt.NewRow();
dr["code"] = nhDataBean.stat usCodeList[ktr1][0];
dr["descriptio n"] = nhDataBean.stat usCodeList[ktr1][1];
dt.Rows.Add(dr) ;
}
}

public DataSet GetCompanyHRInf o()
{
GetProjects(ds. Tables.Add("Pro jects"));
GetShifts(ds.Ta bles.Add("Shift s"));
GetStatus(ds.Ta bles.Add("Statu s"));
return ds;
}
*************** *************** *************** *************** ***

Thanks,

Tom

[Mythran]

"tshad" <ts**********@f tsolutions.com> wrote in message
news:OV******** ******@TK2MSFTN GP04.phx.gbl...

I have about 10 functions that are identical except for one variable name
that I am using in my "for" loop:

for (ktr1=1;ktr1<=n hDataBean.proje ctCodeList.GetU pperBound(0);kt r1++)
for (ktr1=1;ktr1<=n hDataBean.shift CodeList.GetUpp erBound(0);ktr1 ++)
for (ktr1=1;ktr1<=n hDataBean.statu sCodeList.GetUp perBound(0);ktr 1++)

How can I change the "nhDataBean.xxx .GetUpperBound( 0)" so that I can use
only one function?

The code functions and how they are called:

Easy I hope :)

public void GetWhateverYouW antThisNamed(Da taTable dt, object[] items)
{
...
for (...;ktr1 <= items.GetUpperB ound(0); ktr1++)
...
}

It would be better if we knew the type for projectCodeList , shiftCodeList,
and statusCodeList. If they are all the same array type, you could use the
object type instead of "object[]"...

HTH :)

Mythran

[tshad]

"Mythran" <ki********@hot mail.comREMOVET RAIL> wrote in message
news:%2******** ********@TK2MSF TNGP03.phx.gbl. ..

"tshad" <ts**********@f tsolutions.com> wrote in message
news:OV******** ******@TK2MSFTN GP04.phx.gbl...

I have about 10 functions that are identical except for one variable name
that I am using in my "for" loop:

for (ktr1=1;ktr1<=n hDataBean.proje ctCodeList.GetU pperBound(0);kt r1++)
for (ktr1=1;ktr1<=n hDataBean.shift CodeList.GetUpp erBound(0);ktr1 ++)
for (ktr1=1;ktr1<=n hDataBean.statu sCodeList.GetUp perBound(0);ktr 1++)

How can I change the "nhDataBean.xxx .GetUpperBound( 0)" so that I can use
only one function?

The code functions and how they are called:

Easy I hope :)

public void GetWhateverYouW antThisNamed(Da taTable dt, object[] items)
{
...
for (...;ktr1 <= items.GetUpperB ound(0); ktr1++)
...
}

It would be better if we knew the type for projectCodeList , shiftCodeList,
and statusCodeList. If they are all the same array type, you could use
the object type instead of "object[]"...

The objects are actually string[][] objects.

Setting it up your way (but using string instead of objects as you
suggested), looks like this:

*************** *************** *************** *************** ***
public void GetHomeStateSta tus2(DataTable dt, string[][] items)
{
int ktr1 = 0;
DataRow dr;
// Add the columns to the DataTable's Columns collection
dt.Columns.Add( "code");
dt.Columns.Add( "descriptio n");

for (ktr1=1;ktr1<=i tems.GetUpperBo und(0);ktr1++)
{
dr = dt.NewRow();
dr["code"] = items[ktr1][0];
dr["descriptio n"] = items[ktr1][1];
dt.Rows.Add(dr) ;
}
}
*************** *************** *************** *************** ****

This is called like so:

GetHomeStateSta tus2(ds.Tables. Add("HomeStateS tatus"),etDataB ean.homeStateSt atus);I am getting the error:[NullReferenceEx ception: Object reference not set to an instance of anobject.] MyFunctions.New Hire.GetWorkSta teStatus2(DataT able dt, String[][] items) MyFunctions.New Hire.AddNewHire FW()I know the data is there, it shows in the debugger as:+ homeStateStatus {Length=6} string[][]If I replace the items in the functions with etDataBean.home StateStatus, itworks fine.Thanks,Tom >> HTH :)>> Mythran

[tshad]

Never mind.

I got it recompiled and it started to work. I must not have copied the DLL
correctly.

So the string[][] worked fine.

Thanks,

Tom
"tshad" <ts**********@f tsolutions.com> wrote in message
news:eJ******** ********@TK2MSF TNGP03.phx.gbl. ..

"Mythran" <ki********@hot mail.comREMOVET RAIL> wrote in message
news:%2******** ********@TK2MSF TNGP03.phx.gbl. ..

"tshad" <ts**********@f tsolutions.com> wrote in message
news:OV******** ******@TK2MSFTN GP04.phx.gbl...

I have about 10 functions that are identical except for one variable name
that I am using in my "for" loop:

for (ktr1=1;ktr1<=n hDataBean.proje ctCodeList.GetU pperBound(0);kt r1++)
for (ktr1=1;ktr1<=n hDataBean.shift CodeList.GetUpp erBound(0);ktr1 ++)
for (ktr1=1;ktr1<=n hDataBean.statu sCodeList.GetUp perBound(0);ktr 1++)

How can I change the "nhDataBean.xxx .GetUpperBound( 0)" so that I can use
only one function?

The code functions and how they are called:

Easy I hope :)

public void GetWhateverYouW antThisNamed(Da taTable dt, object[] items)
{
...
for (...;ktr1 <= items.GetUpperB ound(0); ktr1++)
...
}

It would be better if we knew the type for projectCodeList ,
shiftCodeList, and statusCodeList. If they are all the same array type,
you could use the object type instead of "object[]"...

The objects are actually string[][] objects.

Setting it up your way (but using string instead of objects as you
suggested), looks like this:

*************** *************** *************** *************** ***
public void GetHomeStateSta tus2(DataTable dt, string[][] items)
{
int ktr1 = 0;
DataRow dr;
// Add the columns to the DataTable's Columns collection
dt.Columns.Add( "code");
dt.Columns.Add( "descriptio n");

for (ktr1=1;ktr1<=i tems.GetUpperBo und(0);ktr1++)
{
dr = dt.NewRow();
dr["code"] = items[ktr1][0];
dr["descriptio n"] = items[ktr1][1];
dt.Rows.Add(dr) ;
}
}
*************** *************** *************** *************** ****

This is called like so:

GetHomeStateSta tus2(ds.Tables. Add("HomeStateS tatus"),etDataB ean.homeStateSt atus);I
am getting the error:[NullReferenceEx ception: Object reference not set to
an instance of anobject.]
MyFunctions.New Hire.GetWorkSta teStatus2(DataT able dt, String[][] items)
MyFunctions.New Hire.AddNewHire FW()I know the data is there, it shows in
the debugger as:+ homeStateStatus {Length=6} string[][]If I replace the
items in the functions with etDataBean.home StateStatus, itworks
fine.Thanks,Tom >> HTH :)>> Mythran