Replace /n with a <br> help please

[CK]

Hi all,

I have a textarea control. I am putting it's value in an html email. The
problem is that the new lines are being ignored. I want to take the
controls value and replace any newline carriage returns, with an html <br>
tag. I tried the following function but it doesn't work. Does anyone have
any ideas how to accomplish this? Thanks in advance. ~ CK

string getComments()

{

string s = tbxComments.Tex t;

Regex r = new Regex("/\n/g");

s = r.Replace(s, "<br/>");
return s;

}

[Swanand Mokashi]

Have you tried replacing chr(10) and chr(13) instead of \n ?
--
Swanand Mokashi
Microsoft Certified Solution Developer (.NET) - Early Achiever
Microsoft Certified Application Developer (.NET)

http://www.dotnetgenerics.com/
DotNetGenerics. com -- anything and everything about Microsoft .NET
technology ...

http://www.swanandmokashi.com/
http://www.swanandmokashi.com/HomePage/WebServices/
Home of the Stock Quotes, Quote of the day and Horoscope web services
"CK" <c_**********@h otmail.com> wrote in message
news:jJ******** ***********@new ssvr27.news.pro digy.net...

Hi all,

I have a textarea control. I am putting it's value in an html email. The
problem is that the new lines are being ignored. I want to take the
controls value and replace any newline carriage returns, with an html <br>
tag. I tried the following function but it doesn't work. Does anyone
have any ideas how to accomplish this? Thanks in advance. ~ CK

string getComments()

{

string s = tbxComments.Tex t;

Regex r = new Regex("/\n/g");

s = r.Replace(s, "<br/>");
return s;

}

[CK]

I am using c# and not VB. Does c# use the chr() function? I do not think
so.
Any other ideas?

"Swanand Mokashi" <sw***********@ swanandmokashi. com> wrote in message
news:eF******** *****@TK2MSFTNG P02.phx.gbl...

Have you tried replacing chr(10) and chr(13) instead of \n ?
--
Swanand Mokashi
Microsoft Certified Solution Developer (.NET) - Early Achiever
Microsoft Certified Application Developer (.NET)

http://www.dotnetgenerics.com/
DotNetGenerics. com -- anything and everything about Microsoft .NET
technology ...

http://www.swanandmokashi.com/
http://www.swanandmokashi.com/HomePage/WebServices/
Home of the Stock Quotes, Quote of the day and Horoscope web services
"CK" <c_**********@h otmail.com> wrote in message
news:jJ******** ***********@new ssvr27.news.pro digy.net...

Hi all,

I have a textarea control. I am putting it's value in an html email.
The problem is that the new lines are being ignored. I want to take the
controls value and replace any newline carriage returns, with an html
<br> tag. I tried the following function but it doesn't work. Does
anyone have any ideas how to accomplish this? Thanks in advance. ~ CK

string getComments()

{

string s = tbxComments.Tex t;

Regex r = new Regex("/\n/g");

s = r.Replace(s, "<br/>");
return s;

}

[Jon Skeet [C# MVP]]

CK <c_**********@h otmail.com> wrote:

I have a textarea control. I am putting it's value in an html email. The
problem is that the new lines are being ignored. I want to take the
controls value and replace any newline carriage returns, with an html <br>
tag. I tried the following function but it doesn't work. Does anyone have
any ideas how to accomplish this? Thanks in advance. ~ CK

string getComments()
{
string s = tbxComments.Tex t;
Regex r = new Regex("/\n/g");
s = r.Replace(s, "<br/>");
return s;
}

The first thing to do (IMO) is to get rid of the use of regular
expressions when they're unnecessary. I'm not a regex expert, so I
couldn't tell you without looking it up whether the above does what
you'd expect it to - but I *do* know that the following will do what
you'd expect it to:

string replaced = tbxComments.Tex t.Replace ("\n", "<br />");

Now, that only deals with line feeds, not carriage returns - but you
could always remove all carriage returns afterwards.

--
Jon Skeet - <sk***@pobox.co m>
http://www.pobox.com/~skeet Blog: http://www.msmvps.com/jon.skeet
If replying to the group, please do not mail me too

[Chris Chilvers]

I like to create a text reader and a text writer for this task as you don't have to worry about what
the line terminator is. Just keep calling read line and write line.

Here's a method I wrote to handle this:

public static string ToHtmlNewLine(s tring text) {
if (text == null) return null;

int length;
StringReader reader;
StringWriter writer;
StringBuilder builder;
string line;

length = text.Length() * 1.2; //apply some padding to avoid array resizing, you probably want to
//tweak this value for the size of the strings you're using
reader = new StringReader(te xt);
builder = new StringBuilder(l ength);
writer = new StringWriter(bu ilder) ;

line = reader.ReadLine ();
if (line != null) {
/*this if then while loop avoids adding an extra blank line at the end of the conversion
* as opposed to just using:
* while (line != null) {
* writer.Write(li ne);
* writer.WriteLin e("<br/>");
*/

writer.Write(li ne);
line = reader.ReadLine ();

while (line != null) {
writer.WriteLin e("<br/>");
writer.Write(li ne);
line = reader.ReadLine ();
}
}

return writer.ToString ();
}
CK wrote:

Hi all,

I have a textarea control. I am putting it's value in an html email. The
problem is that the new lines are being ignored. I want to take the
controls value and replace any newline carriage returns, with an html <br>
tag. I tried the following function but it doesn't work. Does anyone have
any ideas how to accomplish this? Thanks in advance. ~ CK

string getComments()

{

string s = tbxComments.Tex t;

Regex r = new Regex("/\n/g");

s = r.Replace(s, "<br/>");
return s;

}

[Swanand Mokashi]

In that case have you tried replace \n as well as\r.
Also you can use Environment.New Line instead of \n
"CK" <c_**********@h otmail.com> wrote in message
news:HZ******** **********@news svr27.news.prod igy.net...

I am using c# and not VB. Does c# use the chr() function? I do not think
so.
Any other ideas?

"Swanand Mokashi" <sw***********@ swanandmokashi. com> wrote in message
news:eF******** *****@TK2MSFTNG P02.phx.gbl...

Have you tried replacing chr(10) and chr(13) instead of \n ?
--
Swanand Mokashi
Microsoft Certified Solution Developer (.NET) - Early Achiever
Microsoft Certified Application Developer (.NET)

http://www.dotnetgenerics.com/
DotNetGenerics. com -- anything and everything about Microsoft .NET
technology ...

http://www.swanandmokashi.com/
http://www.swanandmokashi.com/HomePage/WebServices/
Home of the Stock Quotes, Quote of the day and Horoscope web services
"CK" <c_**********@h otmail.com> wrote in message
news:jJ******** ***********@new ssvr27.news.pro digy.net...

Hi all,

I have a textarea control. I am putting it's value in an html email.
The problem is that the new lines are being ignored. I want to take the
controls value and replace any newline carriage returns, with an html
<br> tag. I tried the following function but it doesn't work. Does
anyone have any ideas how to accomplish this? Thanks in advance. ~ CK

string getComments()

{

string s = tbxComments.Tex t;

Regex r = new Regex("/\n/g");

s = r.Replace(s, "<br/>");
return s;

}

[Jon Skeet [C# MVP]]

Chris Chilvers <ke****@dynafus .com> wrote:

I like to create a text reader and a text writer for this task as you
don't have to worry about what the line terminator is. Just keep
calling read line and write line.

That's a lot of work for:

string replaced = original.Replac e("\r\n", "<br/>")
.Replace("\r", "<br/>")
.Replace("\n", "<br/>");

In some cases your method *may* be more efficient - but I'd have to see
evidence that it's actually significant in the actual real-world cases
before using a page of code instead of 3 simple lines.

--
Jon Skeet - <sk***@pobox.co m>
http://www.pobox.com/~skeet Blog: http://www.msmvps.com/jon.skeet
If replying to the group, please do not mail me too

[brians[MCSD]]

Something which works for me for replacing carriage return linefeed combo:

string brChar;
string txtMessage;

brChar = Convert.ToStrin g(Convert.ToCha r(13)) +
Convert.ToStrin g(Convert.ToCha r(10));
txtMessage.Repl ace(m_brChar, "<br>")

--
brians
http://www.limbertech.com
"Jon Skeet [C# MVP]" wrote:

CK <c_**********@h otmail.com> wrote:

I have a textarea control. I am putting it's value in an html email. The
problem is that the new lines are being ignored. I want to take the
controls value and replace any newline carriage returns, with an html <br>
tag. I tried the following function but it doesn't work. Does anyone have
any ideas how to accomplish this? Thanks in advance. ~ CK

string getComments()
{
string s = tbxComments.Tex t;
Regex r = new Regex("/\n/g");
s = r.Replace(s, "<br/>");
return s;
}

The first thing to do (IMO) is to get rid of the use of regular
expressions when they're unnecessary. I'm not a regex expert, so I
couldn't tell you without looking it up whether the above does what
you'd expect it to - but I *do* know that the following will do what
you'd expect it to:

string replaced = tbxComments.Tex t.Replace ("\n", "<br />");

Now, that only deals with line feeds, not carriage returns - but you
could always remove all carriage returns afterwards.

--
Jon Skeet - <sk***@pobox.co m>
http://www.pobox.com/~skeet Blog: http://www.msmvps.com/jon.skeet
If replying to the group, please do not mail me too

[Jon Skeet [C# MVP]]

brians[MCSD] <br********@dis cussions.micros oft.com> wrote:

Something which works for me for replacing carriage return linefeed combo:

string brChar;
string txtMessage;

brChar = Convert.ToStrin g(Convert.ToCha r(13)) +
Convert.ToStrin g(Convert.ToCha r(10));
txtMessage.Repl ace(m_brChar, "<br>")

That's great - but you don't need to go to all that trouble to get
brChar. It's just "\r\n".

--
Jon Skeet - <sk***@pobox.co m>
http://www.pobox.com/~skeet Blog: http://www.msmvps.com/jon.skeet
If replying to the group, please do not mail me too

[Swanand Mokashi]

The Environment.New Line will probably do the same thing too :)

"Jon Skeet [C# MVP]" <sk***@pobox.co m> wrote in message
news:MP******** *************** *@msnews.micros oft.com...

brians[MCSD] <br********@dis cussions.micros oft.com> wrote:

Something which works for me for replacing carriage return linefeed
combo:

string brChar;
string txtMessage;

brChar = Convert.ToStrin g(Convert.ToCha r(13)) +
Convert.ToStrin g(Convert.ToCha r(10));
txtMessage.Repl ace(m_brChar, "<br>")

That's great - but you don't need to go to all that trouble to get
brChar. It's just "\r\n".

--
Jon Skeet - <sk***@pobox.co m>
http://www.pobox.com/~skeet Blog: http://www.msmvps.com/jon.skeet
If replying to the group, please do not mail me too