dbReader creating error

[tshad]

I have a function that is getting an error on my dbReader statment:

C:\VSProjects\C lassLibrary4\Ne wHire.cs(53): 'dbReader' denotes a 'variable'
where a 'method' was expected

Here is the function:
*************** *************** *************** *************** ************
private static void GetNewHire(ref string returnString)
{
DbObject myDbObject = new DbObject();
SqlDataReader dbReader;

SqlParameter[] parameters = {
new SqlParameter("@ ApplicantID",Sq lDbType.Int)};

parameters[0].Value = 241;

dbReader = myDbObject.RunP rocedure("GetNe wHire", parameters);
if (dbReader.Read( ))
{
returnString = dbReader("First Name") + "/n" + dbReader("LastN ame");
<-- error on first dbreader
};
dbReader.Close( );
}
*************** *************** *************** *************** ************

What is wrong with this statement?

Thanks,

Tom

[Tom Porterfield]

"tshad" <ts**********@f tsolutions.com> wrote in message
news:Ow******** ******@TK2MSFTN GP14.phx.gbl...

I have a function that is getting an error on my dbReader statment:

C:\VSProjects\C lassLibrary4\Ne wHire.cs(53): 'dbReader' denotes a
'variable' where a 'method' was expected

Here is the function:
*************** *************** *************** *************** ************
private static void GetNewHire(ref string returnString)
{
DbObject myDbObject = new DbObject();
SqlDataReader dbReader;

SqlParameter[] parameters = {
new SqlParameter("@ ApplicantID",Sq lDbType.Int)};

parameters[0].Value = 241;

dbReader = myDbObject.RunP rocedure("GetNe wHire", parameters);
if (dbReader.Read( ))
{
returnString = dbReader("First Name") + "/n" + dbReader("LastN ame"); <--
error on first dbreader
};
dbReader.Close( );
}

The correct syntax is:

returnString = dbReader["FirstName"] ...

--
Tom Porterfield

[Marc Gravell]

Wrong brackets : this should (at the least) use the indexer notation and
casting:

string returnString = ((string)dbRead er["FirstName"]) + "/n" +
((string)dbRead er["LastName"]);

You could lost some of the casting if you used string.Format:

string returnString = string.Format(" {0}\n{1}",
dbReader["FirstName"],dbReader["LastName"]);

The ideal would be to use .GetString(), but this only takes an ordinal - not
worth doing if you only intend reading one line, but if you were reading
2000 it makes sense to use ordinal-based access, finding each ordinal once
(at the top).

Marc

[Marc Gravell]

Oops - I inverted the \n vs /n in one of the examples

[tshad]

"Tom Porterfield" <tp******@mvps. org> wrote in message
news:Oh******** ******@TK2MSFTN GP11.phx.gbl...

"tshad" <ts**********@f tsolutions.com> wrote in message
news:Ow******** ******@TK2MSFTN GP14.phx.gbl...

I have a function that is getting an error on my dbReader statment:

C:\VSProjects\C lassLibrary4\Ne wHire.cs(53): 'dbReader' denotes a
'variable' where a 'method' was expected

Here is the function:
*************** *************** *************** *************** ************
private static void GetNewHire(ref string returnString)
{
DbObject myDbObject = new DbObject();
SqlDataReader dbReader;

SqlParameter[] parameters = {
new SqlParameter("@ ApplicantID",Sq lDbType.Int)};

parameters[0].Value = 241;

dbReader = myDbObject.RunP rocedure("GetNe wHire", parameters);
if (dbReader.Read( ))
{
returnString = dbReader("First Name") + "/n" + dbReader("LastN ame");
<-- error on first dbreader
};
dbReader.Close( );
}

The correct syntax is:

returnString = dbReader["FirstName"] ...

That fixed it.

Thanks,

Tom
--
Tom Porterfield