Removing events

[Bob Rundle]

I have the following code, which appears to be working. However it doesn't
look right. The part I am wondering about is the logic in
DisconnectEvent s(). This logic creates a new delegate and then expects to
find that delegate in the list of event handlers.

What is the proper way of writing this?

Regards,
Bob Rundle
public void ConnectEvents(j oaCollectionEve nts events)
{
OnChanged += new OnChangedDelega te(events.OnCha nged);
OnAdded += new OnAddedDelegate (events.OnAdded );
OnRenamed += new OnRenamedDelega te(events.OnRen amed);
OnRemoved += new OnRemovedDelega te(events.OnRem oved);
}

public void DisconnectEvent s(joaCollection Events events)
{
OnChanged -= new OnChangedDelega te(events.OnCha nged);
OnAdded -= new OnAddedDelegate (events.OnAdded );
OnRenamed -= new OnRenamedDelega te(events.OnRen amed);
OnRemoved -= new OnRemovedDelega te(events.OnRem oved);
}

[Jon Skeet [C# MVP]]

Bob Rundle <ru****@rundle. com> wrote:

I have the following code, which appears to be working. However it doesn't
look right. The part I am wondering about is the logic in
DisconnectEvent s(). This logic creates a new delegate and then expects to
find that delegate in the list of event handlers.

What is the proper way of writing this?

That's fine. So long as it's got the same target as the original
delegate, and the same method, it'll match.

(If you'd changed the value of "events", for example, nothing would
have been removed.)

--
Jon Skeet - <sk***@pobox.co m>
http://www.pobox.com/~skeet
If replying to the group, please do not mail me too

[Ignacio Machin \( .NET/ C# MVP \)]

Hi Bob,
You could also keep a reference to the added delegates:

OnChangedDelega te ocHandler = null;

public void ConnectEvents(j oaCollectionEve nts events)
{
ocHandler = new OnChangedDelega te(events.OnCha nged);
OnChanged += ocHandler;
}

public void DisconnectEvent s(joaCollection Events events)
{
if ( ocHandler!= null )
OnChanged -= ocHandler;
}
Cheers,

--
Ignacio Machin,
ignacio.machin AT dot.state.fl.us
Florida Department Of Transportation

"Bob Rundle" <ru****@rundle. com> wrote in message
news:u%******** *******@TK2MSFT NGP12.phx.gbl.. .

I have the following code, which appears to be working. However it doesn't look right. The part I am wondering about is the logic in
DisconnectEvent s(). This logic creates a new delegate and then expects to
find that delegate in the list of event handlers.

What is the proper way of writing this?

Regards,
Bob Rundle
public void ConnectEvents(j oaCollectionEve nts events)
{
OnChanged += new OnChangedDelega te(events.OnCha nged);
OnAdded += new OnAddedDelegate (events.OnAdded );
OnRenamed += new OnRenamedDelega te(events.OnRen amed);
OnRemoved += new OnRemovedDelega te(events.OnRem oved);
}

public void DisconnectEvent s(joaCollection Events events)
{
OnChanged -= new OnChangedDelega te(events.OnCha nged);
OnAdded -= new OnAddedDelegate (events.OnAdded );
OnRenamed -= new OnRenamedDelega te(events.OnRen amed);
OnRemoved -= new OnRemovedDelega te(events.OnRem oved);
}