Shared functions vs Non-Shared Functions

[tshad]

I am setting up some of my functions in a class called MyFunctions.

I am not clear as to the best time to set a function as Shared and when not
to. For example, I have the following bit manipulation routines in my
Class:

*************** *************** *************** *************** *************** ****
imports System

NameSpace MyFunctions

Public Class BitHandling

'*----------------------------------------------------------*
'* Name : BitSet *
'*----------------------------------------------------------*
'* Purpose : Sets a given Bit in Number *
'*----------------------------------------------------------*
Public Shared Function BitSet(Number As Integer, _
ByVal Bit As Integer) As Long
If Bit = 31 Then
Number = &H80000000 Or Number
Else
Number = (2 ^ Bit) Or Number
End If
BitSet = Number
End Function

'*----------------------------------------------------------*
'* Name : BitClear *
'*----------------------------------------------------------*
'* Purpose : Clears a given Bit in Number *
'*----------------------------------------------------------*
Public Shared Function BitClear(Number As Integer, _
ByVal Bit As Integer) As Long
If Bit = 31 Then
Number = &H7FFFFFFF And Number
Else
Number = ((2 ^ Bit) Xor &HFFFFFFFF) And Number
End If

BitClear = Number
End Function

'*----------------------------------------------------------*
'* Name : BitIsSet *
'*----------------------------------------------------------*
'* Purpose : Test if bit 0 to bit 31 is set *
'*----------------------------------------------------------*
Public Shared Function BitIsSet(ByVal Number As Integer, _
ByVal Bit As Integer) As Boolean
BitIsSet = False

If Bit = 31 Then
If Number And &H80000000 Then BitIsSet = True
Else
If Number And (2 ^ Bit) Then BitIsSet = True
End If
End Function

End Class

End Namespace

*************** *************** *************** *************** *************** *****

Now I have these set up as shared so I don't have to create an instance of
the class:

temp = BitHandling.Bit Set(temp,3)

vs.

dim MyBits as new BitHandling
temp = MyBits.BitSet(t emp,3)

I am also setting up my function to send out various emails which entails
reading an Sql Record and reading a text file from disk, as well as sending
the email:

SmtpMail.SmtpSe rver = mailServer
smtpMail.Send(m essage)

What would tell me that I need to make this a non-shared function vs a
shared one?

Thanks,

Tom

[Karl Seguin]

Ok...
Your codebehind file is a class which inherits Page.

Page exposes the request/response/server which is why it just works as is..
Your email class isn't "web aware" since it doesn't inherit from Page or any
other "web aware" classes.

To have webawarness you use System.Web.Http Context.Current . You cannot
import this because it's a property...you simply can't import properties in
vb.net.

youshould be doing:

Imports System.Web

and in your code use
HttpContext.Cur rent.Request

or, as I showed earlier, use
dim context as HttpContext = HttpContext.Cur rent
dim request as HttpRequest = context.Request
We've covered a lot of ground in this thread :)

Karl

--
MY ASP.Net tutorials
http://www.openmymind.net/ - New and Improved (yes, the popup is
annoying)
http://www.openmymind.net/faq.aspx - unofficial newsgroup FAQ (more to
come!)
"tshad" <ts**********@f tsolutions.com> wrote in message
news:%2******** ********@tk2msf tngp13.phx.gbl. ..

"Karl Seguin" <karl REMOVE @ REMOVE openmymind REMOVEMETOO . ANDME net>
wrote in message news:uH******** *****@TK2MSFTNG P12.phx.gbl...

You've lost me a bit with the mass amounts of code.

That's exactly what I'm saying about moving it around (as a parameter).

As for your error. Objects which you typically program with in your page
and user controls such as Request, Response, Server, ... are there
because they are exposed as part of the System.Web.UI.C ontrol class your
page/user control inherits from (couple levels deep).

Your email class inherits directly from Object, so Request, Response,
Server are meaningless. To get references to these objects within your
class functions, you need to use System.Web.Http Context.Current which
returns the current context (ie the web request) which exposes the
Response, Request, Server, ...

so you would do:

dim context as HttpContext = HttpContext.Cur rent
if context is nothing then 'possible if someone is trying to use this
class outside of a web-scope
throw new InvalidOperatio nException("MyF unc needs to be called from web
request") 'maybe you can do something other than throw an exception?
end if
'now you have access to your request and response objects, here's an
example
dim request as HttpRequest = context.Request
dim someValue as string =Request.QueryS tring("blah")

I may be a little dense here.

If I do this:

*************** *************** *************** *************** *************** ***
Imports System.Web.HTTP Context
Imports Microsoft.Visua lBasic

NameSpace MyFunctions

Public Class Email

Public Shared sub sendEmail ( )
dim URLPath As String = Left(Current.re quest.path,
InStrRev(Curren t.request.path, "/") - 1)
end sub

End Class

End Namespace
*************** *************** *************** *************** *************** ***

Where I use "Current.reques t.path" - it works fine.
If I do this:
*************** *************** *************** *************** *************** ***
Imports System.Web.HTTP Context
Imports System.Web.HTTP Context.Current
Imports Microsoft.Visua lBasic

NameSpace MyFunctions

Public Class Email

Public Shared sub sendEmail ( )
dim URLPath As String = Left(request.pa th, InStrRev(reques t.path, "/") -
1)
end sub

End Class

End Namespace
*************** *************** *************** *************** *************** ***
Where I have "Imports System.Web.HTTP Context.Current ", I get 2 errors:

C:\Inetpub\wwwr oot\staffingwor kshop\emailold3 .vb(2) : error BC30466:
Namespace or type 'Current' for the Imports
'System.Web.HTT PContext.Curren t' cannot be found.

Imports System.Web.HTTP Context.Current

and

C:\Inetpub\wwwr oot\staffingwor kshop\emailold3 .vb(10) : error BC30469:
Reference to a non-shared member requires an object reference.

dim URLPath As String = Left(request.pa th,
InStrRev(reques t.path, "/") - 1)

You, and the error, say I need to have an object reference. But when I
create an aspx page (where I am using code inside), I don't need this. I
can reference request (and MapPath) directly.

I understood that the difference between code-inside and code-behind was
that you had to explicitly do the imports in a code-behind file). But in
this case, it is even more than that.

That is where I am confused.

Thanks,

Tom

hope that helps..

Karl

--
MY ASP.Net tutorials
http://www.openmymind.net/ - New and Improved (yes, the popup is
annoying)
http://www.openmymind.net/faq.aspx - unofficial newsgroup FAQ (more to
come!)
"tshad" <ts**********@f tsolutions.com> wrote in message
news:u0******** ********@TK2MSF TNGP15.phx.gbl. ..

"Karl Seguin" <karl REMOVE @ REMOVE openmymind REMOVEMETOO . ANDME net>
wrote in message news:O%******** ********@tk2msf tngp13.phx.gbl. ..
You would create an instance class with instance members if you wanted
to create an Email object, set it's properties and have a Send()
method, ala:

dim email as new Email("some subject")
email.Body = "xxx"
email.Send()
you would use a shared member if you wanted to pass everything in as
parameters

EmailHelp.Send( "some subject", "xxx")

I personally prefer the syntax of the 2nd example...but if you wanted
to keep a bunch of different emails, say you wanted to cache them or
move them around between your layers, it'd be necessary to have
distinct instances.

I prefer the 2nd example also.

But when you talk about caching or moving them, are you saying that you
want an instance so you could do something like:

sub somefunction (myEmail as Email)
...
myEmail.somemet hod()

end sub

Then using your 1st example:

dim email as new Email("some subject")
email.Body = "xxx"
email.Send()
...
somefunction(em ail) ' calling the above function
BTW, I took my email function and tried to compile it using:

C:\Inetpub\wwwr oot\staffingwor kshop>vbc /t:library email.vb
/r:system.web.dl l /r:system.data.d ll /r:system.dll
/r:Microsoft.Vis ualBasic.dll

and I get the following errors:

C:\Inetpub\wwwr oot\staffingwor kshop\email.vb( 49) : error BC30469:
Reference to a non-shared member requires an object reference.

I am getting this for request.path and for MapPath.

My file looks like:
*************** *************** *************** *************** *************** *******
Imports System
Imports System.Web
Imports System.IO
Imports System.Web.UI
Imports System.Web.Sess ionState
Imports System.Web.Mail
Imports System.Data
Imports System.Data.Sql Client
Imports System.Web.Http Cookie
Imports System.Web.Http CookieCollectio n
Imports System.Web.Http Response
Imports System.Web.Http Request
Imports System.Web.Http Application
Imports System.Web.Http ApplicationStat e
Imports Microsoft.Visua lBasic

NameSpace MyFunctions

Public Class Email

Public Shared sub sendEmail ( )
dim webMasterEmail As String
dim emailSubject As String
Dim mailServer As String
Dim contactEmail As String
Dim screenTestSubje ct As String

Dim emailReader As SqlDataReader

Dim ConnectionStrin g as String
=System.Configu ration.Configur ationSettings.A ppSettings("MM_ CONNECTION_STRI NG_ftsolutions" )
Dim objConn as New SqlConnection (ConnectionStri ng)
Dim CommandText as String = "Select
MailServer,WebM asterEmail,Cont actEmail,Screen TestSubject from
emailResponse where ClientID = '1234'"
Dim objCmd as New SqlCommand(Comm andText,objConn )

objConn.Open()

emailReader = objCmd.ExecuteR eader

if emailReader.Rea d then
mailServer = emailReader("Ma ilServer")
webMasterEmail = emailReader("We bMasterEmail")
contactEmail = emailReader("Co ntactEmail")
screenTestSubje ct = emailReader("Sc reenTestSubject ")
end If

objConn.close()

dim URLPath As String = _
Left(request.pa th, InStrRev(reques t.path, "/") - 1)

Dim objStreamReader as StreamReader
Dim strInput As String
Dim strBuffer As String

If File.exists(Map Path("..\..\aut omail\new_accou nt_automail.htm "))
then
objStreamReader =
File.OpenText(M apPath("..\..\a utomail\new_acc ount_automail.h tm"))
strInput = objStreamReader .ReadLine()
while strInput <> nothing
strBuffer = strBuffer & strInput
strInput = objStreamReader .ReadLine()
end while
objStreamReader .Close
end if

Dim Message As New MailMessage()
message.To = contactEmail
message.From = webMasterEmail
message.Subject = screenTestSubje ct
message.Body = "This is line 1<br><br>"
message.Body = message.Body & "This is line 2<br><br>"
strInput = strBuffer.repla ce("#MESSAGE#", message.Body)
strInput = strInput.replac e("#MAILTITLE#" ,"Screen Test Confirmation")
message.Body = strInput
message.BodyFor mat = MailFormat.Html
SmtpMail.SmtpSe rver = mailServer
smtpMail.Send(m essage)
end sub

End Class

End Namespace
*************** *************** *************** *************** *************** *********

This happens whether emailSend is Shared or not.

Thanks,

Tom
Trust your gut feeling.

Karl

--
MY ASP.Net tutorials
http://www.openmymind.net/ - New and Improved (yes, the popup is
annoying)
http://www.openmymind.net/faq.aspx - unofficial newsgroup FAQ (more to
come!)
"tshad" <ts**********@f tsolutions.com> wrote in message
news:%2******** ********@TK2MSF TNGP09.phx.gbl. ..
> "Karl Seguin" <karl REMOVE @ REMOVE openmymind REMOVEMETOO . ANDME
> net> wrote in message news:e5******** ******@TK2MSFTN GP12.phx.gbl...
>> Tom:
>> Is the function manipulating instance data? Looking at your
>> functions, they look like they need to be shared.
>>
>> Think of it this way.
>>
>> You have a class called Car, which has a property named
>> AirbagDeployed as boolean
>>
>> if you have a function named DeployAirbag() it would need to be an
>> instance (non-shared) method. Why? Because you would have create a
>> new car instance and would want to deploy that particular car's
>> airbag. in other words, instnace methods behave against a particular
>> instance. Your BitHandling class looks like a helper function for
>> dealing with bit information. You wouldn't create separate instance
>> of them as you don't need to represent different bithandling (as you
>> would differnent cars)...ergo your function don't behave against
>> instances.
>>
>> A case where you might have instances is if your BitHandling was
>> culture-specific. In which case you might have different bithandling
>> instances per culture. In this case you'd need to create a new
>> BitHandling class (specifying the culture) and then your functions
>> would behave against that particular instance. (As an aside, an
>> alternative would be to pass the culture information to each shared
>> function so you wouldn't need to create culture-specific instances
>> which works fine for a single parameter, but becomes messy when
>> you're talking about more..)
>
> That's what gets confusing. Trying to figure out the instances bit
> (no pun intended) and if it is needed. Here is the other function
> that I am creating to put in my MyFunctions Namespace. I would give
> is a class of email, I suppose.
>
> This is just my prototype email program that I am putting together to
> make a more generalized function from.
>
> It, in essence:
> gets the connection to Sql
> gets the email record to get the subject and from/to addresses
> reads a text file to put into the body of the message
> adds a few things to the email
> sends the email
>
> I would probably change the function to something like:
>
> public shared sendEmail(filen ame as string, subject as string)
>
> *************** *************** *************** *************** *************** ************
> sub sendEmail ( )
> dim webMasterEmail As String
> dim emailSubject As String
> Dim mailServer As String
> Dim contactEmail As String
> Dim screenTestSubje ct As String
>
> Dim emailReader As SqlDataReader
>
> Dim ConnectionStrin g as String
> =System.Configu ration.Configur ationSettings.A ppSettings("MM_ CONNECTION_STRI NG_solutions")
> Dim objConn as New SqlConnection (ConnectionStri ng)
> Dim CommandText as String = "Select
> MailServer,WebM asterEmail,Cont actEmail,Screen TestSubject from
> emailResponse where ClientID = '1234'"
> Dim objCmd as New SqlCommand(Comm andText,objConn )
>
> objConn.Open()
>
> emailReader = objCmd.ExecuteR eader
>
> if emailReader.Rea d then
> mailServer = emailReader("Ma ilServer")
> webMasterEmail = emailReader("We bMasterEmail")
> contactEmail = emailReader("Co ntactEmail")
> screenTestSubje ct = emailReader("Sc reenTestSubject ")
> end If
>
> objConn.close()
>
> dim URLPath As String = _
> Left(request.pa th, InStrRev(reques t.path, "/") - 1)
>
> Dim objStreamReader as StreamReader
> Dim strInput As String
> Dim strBuffer As String
>
> If File.exists(Map Path("\new_acco unt_automail.ht m")) then
> objStreamReader = File.OpenText(M apPath("\new_ac count_automail. htm"))
> strInput = objStreamReader .ReadLine()
> while strInput <> nothing
> strBuffer = strBuffer & strInput
> strInput = objStreamReader .ReadLine()
> end while
> objStreamReader .Close
> end if
>
> Dim Message As New MailMessage()
> message.To = contactEmail
> message.From = webMasterEmail
> message.Subject = screenTestSubje ct
> message.Body = "This is line 1<br><br>"
> message.Body = message.Body & "This is line 2<br><br>"
> strInput = strBuffer.repla ce("#MESSAGE#", message.Body)
> strInput = strInput.replac e("#MAILTITLE#" ,"Screen Test Confirmation")
> message.Body = strInput
> message.BodyFor mat = MailFormat.Html
> SmtpMail.SmtpSe rver = mailServer
> smtpMail.Send(m essage)
> end sub
> *************** *************** *************** *************** *************** **
>
> Would this work as a shared function, or would I need to make this an
> instance?
>
> Thanks,
>
> Tom
>>
>> Karl
>>
>>
>>
>> --
>> MY ASP.Net tutorials
>> http://www.openmymind.net/ - New and Improved (yes, the popup is
>> annoying)
>> http://www.openmymind.net/faq.aspx - unofficial newsgroup FAQ (more
>> to
>> come!)
>> "tshad" <ts**********@f tsolutions.com> wrote in message
>> news:uB******** ******@tk2msftn gp13.phx.gbl...
>>>I am setting up some of my functions in a class called MyFunctions.
>>>
>>> I am not clear as to the best time to set a function as Shared and
>>> when not to. For example, I have the following bit manipulation
>>> routines in my Class:
>>>
>>> *************** *************** *************** *************** *************** ****
>>> imports System
>>>
>>> NameSpace MyFunctions
>>>
>>> Public Class BitHandling
>>>
>>> '*----------------------------------------------------------*
>>> '* Name : BitSet *
>>> '*----------------------------------------------------------*
>>> '* Purpose : Sets a given Bit in Number *
>>> '*----------------------------------------------------------*
>>> Public Shared Function BitSet(Number As Integer, _
>>> ByVal Bit As Integer) As Long
>>> If Bit = 31 Then
>>> Number = &H80000000 Or Number
>>> Else
>>> Number = (2 ^ Bit) Or Number
>>> End If
>>> BitSet = Number
>>> End Function
>>>
>>> '*----------------------------------------------------------*
>>> '* Name : BitClear *
>>> '*----------------------------------------------------------*
>>> '* Purpose : Clears a given Bit in Number *
>>> '*----------------------------------------------------------*
>>> Public Shared Function BitClear(Number As Integer, _
>>> ByVal Bit As Integer) As Long
>>> If Bit = 31 Then
>>> Number = &H7FFFFFFF And Number
>>> Else
>>> Number = ((2 ^ Bit) Xor &HFFFFFFFF) And Number
>>> End If
>>>
>>> BitClear = Number
>>> End Function
>>>
>>> '*----------------------------------------------------------*
>>> '* Name : BitIsSet *
>>> '*----------------------------------------------------------*
>>> '* Purpose : Test if bit 0 to bit 31 is set *
>>> '*----------------------------------------------------------*
>>> Public Shared Function BitIsSet(ByVal Number As Integer, _
>>> ByVal Bit As Integer) As Boolean
>>> BitIsSet = False
>>>
>>> If Bit = 31 Then
>>> If Number And &H80000000 Then BitIsSet = True
>>> Else
>>> If Number And (2 ^ Bit) Then BitIsSet = True
>>> End If
>>> End Function
>>>
>>> End Class
>>>
>>> End Namespace
>>>
>>> *************** *************** *************** *************** *************** *****
>>>
>>> Now I have these set up as shared so I don't have to create an
>>> instance of the class:
>>>
>>> temp = BitHandling.Bit Set(temp,3)
>>>
>>> vs.
>>>
>>> dim MyBits as new BitHandling
>>> temp = MyBits.BitSet(t emp,3)
>>>
>>> I am also setting up my function to send out various emails which
>>> entails reading an Sql Record and reading a text file from disk, as
>>> well as sending the email:
>>>
>>> SmtpMail.SmtpSe rver = mailServer
>>> smtpMail.Send(m essage)
>>>
>>> What would tell me that I need to make this a non-shared function vs
>>> a shared one?
>>>
>>> Thanks,
>>>
>>> Tom
>>>
>>
>>
>
>

[tshad]

"Karl Seguin" <karl REMOVE @ REMOVE openmymind REMOVEMETOO . ANDME net>
wrote in message news:eW******** ******@TK2MSFTN GP09.phx.gbl...

Ok...
Your codebehind file is a class which inherits Page.

Page exposes the request/response/server which is why it just works as
is..
Your email class isn't "web aware" since it doesn't inherit from Page or
any other "web aware" classes.

To have webawarness you use System.Web.Http Context.Current . You cannot
import this because it's a property...you simply can't import properties
in vb.net.

youshould be doing:

Imports System.Web

and in your code use
HttpContext.Cur rent.Request

or, as I showed earlier, use
dim context as HttpContext = HttpContext.Cur rent
dim request as HttpRequest = context.Request
We've covered a lot of ground in this thread :)
Yes, we have - and I really appreciate it. These are the things that are
hard to get a handle on as it isn't covered well in most of the books I have
(or at least not in the places I have been reading).

If you knew where to find this, it would probably be there - but you have to
find it.

Thanks,

Tom
Karl

--
MY ASP.Net tutorials
http://www.openmymind.net/ - New and Improved (yes, the popup is
annoying)
http://www.openmymind.net/faq.aspx - unofficial newsgroup FAQ (more to
come!)
"tshad" <ts**********@f tsolutions.com> wrote in message
news:%2******** ********@tk2msf tngp13.phx.gbl. ..

"Karl Seguin" <karl REMOVE @ REMOVE openmymind REMOVEMETOO . ANDME net>
wrote in message news:uH******** *****@TK2MSFTNG P12.phx.gbl...

You've lost me a bit with the mass amounts of code.

That's exactly what I'm saying about moving it around (as a parameter).

As for your error. Objects which you typically program with in your
page and user controls such as Request, Response, Server, ... are there
because they are exposed as part of the System.Web.UI.C ontrol class your
page/user control inherits from (couple levels deep).

Your email class inherits directly from Object, so Request, Response,
Server are meaningless. To get references to these objects within your
class functions, you need to use System.Web.Http Context.Current which
returns the current context (ie the web request) which exposes the
Response, Request, Server, ...

so you would do:

dim context as HttpContext = HttpContext.Cur rent
if context is nothing then 'possible if someone is trying to use this
class outside of a web-scope
throw new InvalidOperatio nException("MyF unc needs to be called from web
request") 'maybe you can do something other than throw an exception?
end if
'now you have access to your request and response objects, here's an
example
dim request as HttpRequest = context.Request
dim someValue as string =Request.QueryS tring("blah")

I may be a little dense here.

If I do this:

*************** *************** *************** *************** *************** ***
Imports System.Web.HTTP Context
Imports Microsoft.Visua lBasic

NameSpace MyFunctions

Public Class Email

Public Shared sub sendEmail ( )
dim URLPath As String = Left(Current.re quest.path,
InStrRev(Curren t.request.path, "/") - 1)
end sub

End Class

End Namespace
*************** *************** *************** *************** *************** ***

Where I use "Current.reques t.path" - it works fine.
If I do this:
*************** *************** *************** *************** *************** ***
Imports System.Web.HTTP Context
Imports System.Web.HTTP Context.Current
Imports Microsoft.Visua lBasic

NameSpace MyFunctions

Public Class Email

Public Shared sub sendEmail ( )
dim URLPath As String = Left(request.pa th, InStrRev(reques t.path,
"/") - 1)
end sub

End Class

End Namespace
*************** *************** *************** *************** *************** ***
Where I have "Imports System.Web.HTTP Context.Current ", I get 2 errors:

C:\Inetpub\wwwr oot\staffingwor kshop\emailold3 .vb(2) : error BC30466:
Namespace or type 'Current' for the Imports
'System.Web.HTT PContext.Curren t' cannot be found.

Imports System.Web.HTTP Context.Current

and

C:\Inetpub\wwwr oot\staffingwor kshop\emailold3 .vb(10) : error BC30469:
Reference to a non-shared member requires an object reference.

dim URLPath As String = Left(request.pa th,
InStrRev(reques t.path, "/") - 1)

You, and the error, say I need to have an object reference. But when I
create an aspx page (where I am using code inside), I don't need this. I
can reference request (and MapPath) directly.

I understood that the difference between code-inside and code-behind was
that you had to explicitly do the imports in a code-behind file). But in
this case, it is even more than that.

That is where I am confused.

Thanks,

Tom

hope that helps..

Karl

--
MY ASP.Net tutorials
http://www.openmymind.net/ - New and Improved (yes, the popup is
annoying)
http://www.openmymind.net/faq.aspx - unofficial newsgroup FAQ (more to
come!)
"tshad" <ts**********@f tsolutions.com> wrote in message
news:u0******** ********@TK2MSF TNGP15.phx.gbl. ..
"Karl Seguin" <karl REMOVE @ REMOVE openmymind REMOVEMETOO . ANDME net>
wrote in message news:O%******** ********@tk2msf tngp13.phx.gbl. ..
> You would create an instance class with instance members if you wanted
> to create an Email object, set it's properties and have a Send()
> method, ala:
>
> dim email as new Email("some subject")
> email.Body = "xxx"
> email.Send()
>
>
> you would use a shared member if you wanted to pass everything in as
> parameters
>
> EmailHelp.Send( "some subject", "xxx")
>
> I personally prefer the syntax of the 2nd example...but if you wanted
> to keep a bunch of different emails, say you wanted to cache them or
> move them around between your layers, it'd be necessary to have
> distinct instances.

I prefer the 2nd example also.

But when you talk about caching or moving them, are you saying that you
want an instance so you could do something like:

sub somefunction (myEmail as Email)
...
myEmail.somemet hod()

end sub

Then using your 1st example:

dim email as new Email("some subject")
email.Body = "xxx"
email.Send()
...
somefunction(em ail) ' calling the above function
BTW, I took my email function and tried to compile it using:

C:\Inetpub\wwwr oot\staffingwor kshop>vbc /t:library email.vb
/r:system.web.dl l /r:system.data.d ll /r:system.dll
/r:Microsoft.Vis ualBasic.dll

and I get the following errors:

C:\Inetpub\wwwr oot\staffingwor kshop\email.vb( 49) : error BC30469:
Reference to a non-shared member requires an object reference.

I am getting this for request.path and for MapPath.

My file looks like:
*************** *************** *************** *************** *************** *******
Imports System
Imports System.Web
Imports System.IO
Imports System.Web.UI
Imports System.Web.Sess ionState
Imports System.Web.Mail
Imports System.Data
Imports System.Data.Sql Client
Imports System.Web.Http Cookie
Imports System.Web.Http CookieCollectio n
Imports System.Web.Http Response
Imports System.Web.Http Request
Imports System.Web.Http Application
Imports System.Web.Http ApplicationStat e
Imports Microsoft.Visua lBasic

NameSpace MyFunctions

Public Class Email

Public Shared sub sendEmail ( )
dim webMasterEmail As String
dim emailSubject As String
Dim mailServer As String
Dim contactEmail As String
Dim screenTestSubje ct As String

Dim emailReader As SqlDataReader

Dim ConnectionStrin g as String
=System.Configu ration.Configur ationSettings.A ppSettings("MM_ CONNECTION_STRI NG_ftsolutions" )
Dim objConn as New SqlConnection (ConnectionStri ng)
Dim CommandText as String = "Select
MailServer,WebM asterEmail,Cont actEmail,Screen TestSubject from
emailResponse where ClientID = '1234'"
Dim objCmd as New SqlCommand(Comm andText,objConn )

objConn.Open()

emailReader = objCmd.ExecuteR eader

if emailReader.Rea d then
mailServer = emailReader("Ma ilServer")
webMasterEmail = emailReader("We bMasterEmail")
contactEmail = emailReader("Co ntactEmail")
screenTestSubje ct = emailReader("Sc reenTestSubject ")
end If

objConn.close()

dim URLPath As String = _
Left(request.pa th, InStrRev(reques t.path, "/") - 1)

Dim objStreamReader as StreamReader
Dim strInput As String
Dim strBuffer As String

If File.exists(Map Path("..\..\aut omail\new_accou nt_automail.htm "))
then
objStreamReader =
File.OpenText(M apPath("..\..\a utomail\new_acc ount_automail.h tm"))
strInput = objStreamReader .ReadLine()
while strInput <> nothing
strBuffer = strBuffer & strInput
strInput = objStreamReader .ReadLine()
end while
objStreamReader .Close
end if

Dim Message As New MailMessage()
message.To = contactEmail
message.From = webMasterEmail
message.Subject = screenTestSubje ct
message.Body = "This is line 1<br><br>"
message.Body = message.Body & "This is line 2<br><br>"
strInput = strBuffer.repla ce("#MESSAGE#", message.Body)
strInput = strInput.replac e("#MAILTITLE#" ,"Screen Test Confirmation")
message.Body = strInput
message.BodyFor mat = MailFormat.Html
SmtpMail.SmtpSe rver = mailServer
smtpMail.Send(m essage)
end sub

End Class

End Namespace
*************** *************** *************** *************** *************** *********

This happens whether emailSend is Shared or not.

Thanks,

Tom

>
> Trust your gut feeling.
>
> Karl
>
> --
> MY ASP.Net tutorials
> http://www.openmymind.net/ - New and Improved (yes, the popup is
> annoying)
> http://www.openmymind.net/faq.aspx - unofficial newsgroup FAQ (more to
> come!)
> "tshad" <ts**********@f tsolutions.com> wrote in message
> news:%2******** ********@TK2MSF TNGP09.phx.gbl. ..
>> "Karl Seguin" <karl REMOVE @ REMOVE openmymind REMOVEMETOO . ANDME
>> net> wrote in message news:e5******** ******@TK2MSFTN GP12.phx.gbl...
>>> Tom:
>>> Is the function manipulating instance data? Looking at your
>>> functions, they look like they need to be shared.
>>>
>>> Think of it this way.
>>>
>>> You have a class called Car, which has a property named
>>> AirbagDeployed as boolean
>>>
>>> if you have a function named DeployAirbag() it would need to be an
>>> instance (non-shared) method. Why? Because you would have create a
>>> new car instance and would want to deploy that particular car's
>>> airbag. in other words, instnace methods behave against a particular
>>> instance. Your BitHandling class looks like a helper function for
>>> dealing with bit information. You wouldn't create separate instance
>>> of them as you don't need to represent different bithandling (as you
>>> would differnent cars)...ergo your function don't behave against
>>> instances.
>>>
>>> A case where you might have instances is if your BitHandling was
>>> culture-specific. In which case you might have different bithandling
>>> instances per culture. In this case you'd need to create a new
>>> BitHandling class (specifying the culture) and then your functions
>>> would behave against that particular instance. (As an aside, an
>>> alternative would be to pass the culture information to each shared
>>> function so you wouldn't need to create culture-specific instances
>>> which works fine for a single parameter, but becomes messy when
>>> you're talking about more..)
>>
>> That's what gets confusing. Trying to figure out the instances bit
>> (no pun intended) and if it is needed. Here is the other function
>> that I am creating to put in my MyFunctions Namespace. I would give
>> is a class of email, I suppose.
>>
>> This is just my prototype email program that I am putting together to
>> make a more generalized function from.
>>
>> It, in essence:
>> gets the connection to Sql
>> gets the email record to get the subject and from/to addresses
>> reads a text file to put into the body of the message
>> adds a few things to the email
>> sends the email
>>
>> I would probably change the function to something like:
>>
>> public shared sendEmail(filen ame as string, subject as string)
>>
>> *************** *************** *************** *************** *************** ************
>> sub sendEmail ( )
>> dim webMasterEmail As String
>> dim emailSubject As String
>> Dim mailServer As String
>> Dim contactEmail As String
>> Dim screenTestSubje ct As String
>>
>> Dim emailReader As SqlDataReader
>>
>> Dim ConnectionStrin g as String
>> =System.Configu ration.Configur ationSettings.A ppSettings("MM_ CONNECTION_STRI NG_solutions")
>> Dim objConn as New SqlConnection (ConnectionStri ng)
>> Dim CommandText as String = "Select
>> MailServer,WebM asterEmail,Cont actEmail,Screen TestSubject from
>> emailResponse where ClientID = '1234'"
>> Dim objCmd as New SqlCommand(Comm andText,objConn )
>>
>> objConn.Open()
>>
>> emailReader = objCmd.ExecuteR eader
>>
>> if emailReader.Rea d then
>> mailServer = emailReader("Ma ilServer")
>> webMasterEmail = emailReader("We bMasterEmail")
>> contactEmail = emailReader("Co ntactEmail")
>> screenTestSubje ct = emailReader("Sc reenTestSubject ")
>> end If
>>
>> objConn.close()
>>
>> dim URLPath As String = _
>> Left(request.pa th, InStrRev(reques t.path, "/") - 1)
>>
>> Dim objStreamReader as StreamReader
>> Dim strInput As String
>> Dim strBuffer As String
>>
>> If File.exists(Map Path("\new_acco unt_automail.ht m")) then
>> objStreamReader =
>> File.OpenText(M apPath("\new_ac count_automail. htm"))
>> strInput = objStreamReader .ReadLine()
>> while strInput <> nothing
>> strBuffer = strBuffer & strInput
>> strInput = objStreamReader .ReadLine()
>> end while
>> objStreamReader .Close
>> end if
>>
>> Dim Message As New MailMessage()
>> message.To = contactEmail
>> message.From = webMasterEmail
>> message.Subject = screenTestSubje ct
>> message.Body = "This is line 1<br><br>"
>> message.Body = message.Body & "This is line 2<br><br>"
>> strInput = strBuffer.repla ce("#MESSAGE#", message.Body)
>> strInput = strInput.replac e("#MAILTITLE#" ,"Screen Test Confirmation")
>> message.Body = strInput
>> message.BodyFor mat = MailFormat.Html
>> SmtpMail.SmtpSe rver = mailServer
>> smtpMail.Send(m essage)
>> end sub
>> *************** *************** *************** *************** *************** **
>>
>> Would this work as a shared function, or would I need to make this an
>> instance?
>>
>> Thanks,
>>
>> Tom
>>>
>>> Karl
>>>
>>>
>>>
>>> --
>>> MY ASP.Net tutorials
>>> http://www.openmymind.net/ - New and Improved (yes, the popup is
>>> annoying)
>>> http://www.openmymind.net/faq.aspx - unofficial newsgroup FAQ (more
>>> to
>>> come!)
>>> "tshad" <ts**********@f tsolutions.com> wrote in message
>>> news:uB******** ******@tk2msftn gp13.phx.gbl...
>>>>I am setting up some of my functions in a class called MyFunctions.
>>>>
>>>> I am not clear as to the best time to set a function as Shared and
>>>> when not to. For example, I have the following bit manipulation
>>>> routines in my Class:
>>>>
>>>> *************** *************** *************** *************** *************** ****
>>>> imports System
>>>>
>>>> NameSpace MyFunctions
>>>>
>>>> Public Class BitHandling
>>>>
>>>> '*----------------------------------------------------------*
>>>> '* Name : BitSet *
>>>> '*----------------------------------------------------------*
>>>> '* Purpose : Sets a given Bit in Number *
>>>> '*----------------------------------------------------------*
>>>> Public Shared Function BitSet(Number As Integer, _
>>>> ByVal Bit As Integer) As Long
>>>> If Bit = 31 Then
>>>> Number = &H80000000 Or Number
>>>> Else
>>>> Number = (2 ^ Bit) Or Number
>>>> End If
>>>> BitSet = Number
>>>> End Function
>>>>
>>>> '*----------------------------------------------------------*
>>>> '* Name : BitClear *
>>>> '*----------------------------------------------------------*
>>>> '* Purpose : Clears a given Bit in Number *
>>>> '*----------------------------------------------------------*
>>>> Public Shared Function BitClear(Number As Integer, _
>>>> ByVal Bit As Integer) As Long
>>>> If Bit = 31 Then
>>>> Number = &H7FFFFFFF And Number
>>>> Else
>>>> Number = ((2 ^ Bit) Xor &HFFFFFFFF) And Number
>>>> End If
>>>>
>>>> BitClear = Number
>>>> End Function
>>>>
>>>> '*----------------------------------------------------------*
>>>> '* Name : BitIsSet *
>>>> '*----------------------------------------------------------*
>>>> '* Purpose : Test if bit 0 to bit 31 is set *
>>>> '*----------------------------------------------------------*
>>>> Public Shared Function BitIsSet(ByVal Number As Integer, _
>>>> ByVal Bit As Integer) As Boolean
>>>> BitIsSet = False
>>>>
>>>> If Bit = 31 Then
>>>> If Number And &H80000000 Then BitIsSet = True
>>>> Else
>>>> If Number And (2 ^ Bit) Then BitIsSet = True
>>>> End If
>>>> End Function
>>>>
>>>> End Class
>>>>
>>>> End Namespace
>>>>
>>>> *************** *************** *************** *************** *************** *****
>>>>
>>>> Now I have these set up as shared so I don't have to create an
>>>> instance of the class:
>>>>
>>>> temp = BitHandling.Bit Set(temp,3)
>>>>
>>>> vs.
>>>>
>>>> dim MyBits as new BitHandling
>>>> temp = MyBits.BitSet(t emp,3)
>>>>
>>>> I am also setting up my function to send out various emails which
>>>> entails reading an Sql Record and reading a text file from disk, as
>>>> well as sending the email:
>>>>
>>>> SmtpMail.SmtpSe rver = mailServer
>>>> smtpMail.Send(m essage)
>>>>
>>>> What would tell me that I need to make this a non-shared function
>>>> vs a shared one?
>>>>
>>>> Thanks,
>>>>
>>>> Tom
>>>>
>>>
>>>
>>
>>
>
>