473,574 Members | 18,329 Online
Bytes | Software Development & Data Engineering Community
+ Post

Home Posts Topics Members FAQ

cast to non-const reference of a function's return object

hi,

recently i discovered a memory leak in our code; after some investigation i
could reduce it to the following problem:
return objects of functions are handled as temporary objects, hence their
dtor is called immediately and not at the end of the function. to be able to
use return objects (to avoid copying) i often assign them to a const
reference.
now, casting a const return object from a function to a non-const reference
to this return object calls immediately the dtor of the return object
anyway, any further operation deals with a non-valid object then. if i do
this in two steps - first holding a const reference to the return object and
then const_casting it, everything works like i expected it.

does anybody know whether the compiler behaves correctly?
i use the following short example to illustrate my question:

const string getastring()
{
return string();
}

void funcWmemleak()
{
string& str = const_cast<stri ng&>(getastring ());
str = "test"; // this is already an invalid object because the dtor was
called before (and won't ever be called again of course)
}

void funcWOmemleak()
{
const string& str1 = getastring();
string& str = const_cast<stri ng&>(str1);
str = "test";
}

int main()
{
funcWmemleak();
funcWOmemleak() ;
}

--
klaus triendl
Jul 22 '05 #1
5 3731
On Wed, 02 Jun 2004 08:09:01 GMT, "klaus triendl" <tr********@mbo x.at>
wrote:
hi,

recently i discovered a memory leak in our code;
I think you mean "use of a dangling reference" rather than "memory
leak".

after some investigation icould reduce it to the following problem:
return objects of functions are handled as temporary objects, hence their
dtor is called immediately and not at the end of the function. to be able to
use return objects (to avoid copying) i often assign them to a const
reference.
now, casting a const return object from a function to a non-const reference
to this return object calls immediately the dtor of the return object
anyway, any further operation deals with a non-valid object then. if i do
this in two steps - first holding a const reference to the return object and
then const_casting it, everything works like i expected it.

does anybody know whether the compiler behaves correctly?


Yes, binding a temporary directly to a const reference extends the
lifetime of the temporary to match that of the reference. You can't
bind a temporary to a non-const reference, so there's no way of doing
the lifetime extension using a non-const ref.

Note, since you return a const string, using the returned string as a
non-const string results in undefined behaviour. You can only safely
use an object that has had const cast away as a non-const object if it
wasn't originally declared const.

Tom
--
C++ FAQ: http://www.parashift.com/c++-faq-lite/
C FAQ: http://www.eskimo.com/~scs/C-faq/top.html
Jul 22 '05 #2
"tom_usenet " <to********@hot mail.com> wrote in message
news:<a2******* *************** **********@4ax. com>...
On Wed, 02 Jun 2004 08:09:01 GMT, "klaus triendl" <tr********@mbo x.at>
wrote:
hi,

recently i discovered a memory leak in our code;
I think you mean "use of a dangling reference" rather than "memory
leak".

in our code the returned object is a reference counting pointer and the
string "test" is a new object which is not freed causing a memory leak
(reported by the debugger as such).
after some investigation i
could reduce it to the following problem:
return objects of functions are handled as temporary objects, hence their
dtor is called immediately and not at the end of the function. to be able touse return objects (to avoid copying) i often assign them to a const
reference.
now, casting a const return object from a function to a non-const referenceto this return object calls immediately the dtor of the return object
anyway, any further operation deals with a non-valid object then. if i do
this in two steps - first holding a const reference to the return object andthen const_casting it, everything works like i expected it.

does anybody know whether the compiler behaves correctly?
Yes, binding a temporary directly to a const reference extends the
lifetime of the temporary to match that of the reference. You can't
bind a temporary to a non-const reference, so there's no way of doing
the lifetime extension using a non-const ref.

if the temporary is non-const i can bind it to a non-const reference. at
least with vc++7 it is possible.
Note, since you return a const string, using the returned string as a
non-const string results in undefined behaviour. You can only safely
use an object that has had const cast away as a non-const object if it
wasn't originally declared const.

well, that's an argument; and i can easily solve that problem.
but my question still remains whether the const_cast in the function
"funcWmemle ak" is a good reason that the non-const reference is a non-valid
object after the assignment or not.

--
klaus triendl
Jul 22 '05 #3
On Wed, 02 Jun 2004 14:07:20 GMT, "klaus triendl" <tr********@mbo x.at>
wrote:
Yes, binding a temporary directly to a const reference extends the
lifetime of the temporary to match that of the reference. You can't
bind a temporary to a non-const reference, so there's no way of doing
the lifetime extension using a non-const ref.if the temporary is non-const i can bind it to a non-const reference. at
least with vc++7 it is possible.


This is a non-conforming compiler extension. On VC7.1 I get a warning,
and compiling with /Za (ISO mode) I get an error.
Note, since you return a const string, using the returned string as a
non-const string results in undefined behaviour. You can only safely
use an object that has had const cast away as a non-const object if it
wasn't originally declared const.well, that's an argument; and i can easily solve that problem.


Indeed, that paragraph was just an aside.
but my question still remains whether the const_cast in the function
"funcWmemlea k" is a good reason that the non-const reference is a non-valid
object after the assignment or not.


If you perform the const_cast, then you are not directly binding the
reference to the temporary, and the lifetime will not be extended,
hence you have a "dangling reference" that you can't use. It is
synonymous to this conforming code that exhibits the same problem, and
doesn't use any Microsoft extensions:

#include <string>
#include <iostream>
using namespace std;

int main()
{
string const& s = static_cast<str ing const&>(string( "foo"));
cout << s << '\n';
}

Because s isn't bound directly to the temporary (it is bound to the
result of the static cast), it doesn't extend the temporary's lifetime
and the cout call has undefined behaviour since the temporary has
already been destroyed. Remove the static_cast and it's fine. See
12.2/5 in the C++ standard.

Clear?

Tom
--
C++ FAQ: http://www.parashift.com/c++-faq-lite/
C FAQ: http://www.eskimo.com/~scs/C-faq/top.html
Jul 22 '05 #4
"klaus triendl" <tr********@mbo x.at> wrote in message news:<sa******* ***********@new s.chello.at>...
after some investigation i
could reduce it to the following problem:
return objects of functions are handled as temporary objects, hence their
dtor is called immediately and not at the end of the function. to be able touse return objects (to avoid copying) i often assign them to a const
reference.
now, casting a const return object from a function to a non-const referenceto this return object calls immediately the dtor of the return object
anyway, any further operation deals with a non-valid object then. if i do
this in two steps - first holding a const reference to the return object andthen const_casting it, everything works like i expected it.

does anybody know whether the compiler behaves correctly?


Yes, binding a temporary directly to a const reference extends the
lifetime of the temporary to match that of the reference. You can't
bind a temporary to a non-const reference, so there's no way of doing
the lifetime extension using a non-const ref.

if the temporary is non-const i can bind it to a non-const reference. at
least with vc++7 it is possible.
Note, since you return a const string, using the returned string as a
non-const string results in undefined behaviour. You can only safely
use an object that has had const cast away as a non-const object if it
wasn't originally declared const.

well, that's an argument; and i can easily solve that problem.
but my question still remains whether the const_cast in the function
"funcWmemle ak" is a good reason that the non-const reference is a non-valid
object after the assignment or not.


Yes, it is a valid reference until the const reference that the
temporary was originally bound to is destroyed (i.e. goes out of
scope), provided that the destructor for the original object is not
called in the interim (which is highly unlikely given the context).

HTH, Dave Moore
Jul 22 '05 #5
> Because s isn't bound directly to the temporary (it is bound to the
result of the static cast), it doesn't extend the temporary's lifetime
and the cout call has undefined behaviour since the temporary has
already been destroyed. Remove the static_cast and it's fine. See
12.2/5 in the C++ standard.

Clear?


clear as glass :)
thx for the explanation. it's good to know that the compiler considers the
const_cast a function returning a result.

and thx to dave moore for your posting.
klaus
Jul 22 '05 #6

This thread has been closed and replies have been disabled. Please start a new discussion.

Similar topics

15
1705
by: Christopher Benson-Manica | last post by:
If you had an unsigned int that needed to be cast to a const myClass*, would you use const myClass* a=reinterpret_cast<const myClass*>(my_val); or const myClass* a=(const myClass*)myVal; ?
36
6656
by: MSG | last post by:
The answer is neither. Use macros. #define ALLOC(size, type) ((type) *) malloc((size) * sizeof(type)) #define NEW(type, name, size) (type) * (name) = ALLOC((size), (type)) They are both type-safe and concise. Compare: NEW(int, x, 1000);
12
1707
by: Martin | last post by:
Two questions relating to FAQ answer 12.42. (1) In the statement s.i16 |= (unsigned)(getc(fp) << 8); i16 is declared int. The reason for casting to (unsigned) is explained as guarding against sign extension. But left-shifting will always fill vacated bits with zero (assuming the right operand is nonnegative and less than the number of...
14
19290
by: google-newsgroups | last post by:
Hello, even (or because?) reading the standard (ISO/IEC 9899/1999) I do not understand some issues with volatile. The background is embedded programming where data is exchanged between main program flow and interrupts. At the organisation I work, instead of declaring a variable volatile, it is casted to volatile when necessary:
1
1888
by: Daniel | last post by:
HI, <asp:TableCell BackColor="#000066" ID="tblcell" Width='<%# DataBinder.Eval(Container.DataItem, "PRODUCT_ID") %>'/> code at the above is displaying the message Specified cast is not valid. How to cast the width's value into integer? i already out of ideas.
16
1536
by: the.duckman | last post by:
G'Day. Anybodey got an idea on this problem. Say I have a function object doCast(object obj, Type t); It's job is to cast the obect (obj) to a new type (t) and return it. Sounds so simple, but I cant seem to find a way to do it without some prety extravigant hacks.
9
2595
by: Joe | last post by:
I need to cast the correct way HMENU mymenu; int stuff; .... stuff=(int)(long)(HMENU)mymenu; ....
4
2532
by: Pavel Minaev | last post by:
There was an earlier discussion regarding which one is faster - a throwing cast - "(Foo)obj", or a non-throwing one - "obj as Foo", when both are available for a given type and value. The consensus was that, since a check has to be made by the compiler in either case, the speed should be equivalent in case object is indeed of a requested type....
15
2371
by: Lloyd Dupont | last post by:
Don't mistake generic type for what you would like them to be!! IFoo<Ahas nothing in common with IFoo<B>! They are completely different type create dynamically at runtime. What you ask is a bit akin to ask: "the System.Web.UI and System.Windows.Controls namespace both contains a Control class, could I use one in place of the other? common...
0
7817
marktang
by: marktang | last post by:
ONU (Optical Network Unit) is one of the key components for providing high-speed Internet services. Its primary function is to act as an endpoint device located at the user's premises. However, people are often confused as to whether an ONU can Work As a Router. In this blog post, we’ll explore What is ONU, What Is Router, ONU & Router’s main...
0
7738
by: Hystou | last post by:
Most computers default to English, but sometimes we require a different language, especially when relocating. Forgot to request a specific language before your computer shipped? No problem! You can effortlessly switch the default language on Windows 10 without reinstalling. I'll walk you through it. First, let's disable language...
0
8081
Oralloy
by: Oralloy | last post by:
Hello folks, I am unable to find appropriate documentation on the type promotion of bit-fields when using the generalised comparison operator "<=>". The problem is that using the GNU compilers, it seems that the internal comparison operator "<=>" tries to promote arguments from unsigned to signed. This is as boiled down as I can make it. ...
0
8119
tracyyun
by: tracyyun | last post by:
Dear forum friends, With the development of smart home technology, a variety of wireless communication protocols have appeared on the market, such as Zigbee, Z-Wave, Wi-Fi, Bluetooth, etc. Each protocol has its own unique characteristics and advantages, but as a user who is planning to build a smart home system, I am a bit confused by the...
0
6482
agi2029
by: agi2029 | last post by:
Let's talk about the concept of autonomous AI software engineers and no-code agents. These AIs are designed to manage the entire lifecycle of a software development project—planning, coding, testing, and deployment—without human intervention. Imagine an AI that can take a project description, break it down, write the code, debug it, and then...
1
5635
isladogs
by: isladogs | last post by:
The next Access Europe User Group meeting will be on Wednesday 1 May 2024 starting at 18:00 UK time (6PM UTC+1) and finishing by 19:30 (7.30PM). In this session, we are pleased to welcome a new presenter, Adolph Dupré who will be discussing some powerful techniques for using class modules. He will explain when you may want to use classes...
0
3759
by: TSSRALBI | last post by:
Hello I'm a network technician in training and I need your help. I am currently learning how to create and manage the different types of VPNs and I have a question about LAN-to-LAN VPNs. The last exercise I practiced was to create a LAN-to-LAN VPN between two Pfsense firewalls, by using IPSEC protocols. I succeeded, with both firewalls in...
0
3771
by: adsilva | last post by:
A Windows Forms form does not have the event Unload, like VB6. What one acts like?
0
1082
bsmnconsultancy
by: bsmnconsultancy | last post by:
In today's digital era, a well-designed website is crucial for businesses looking to succeed. Whether you're a small business owner or a large corporation in Toronto, having a strong online presence can significantly impact your brand's success. BSMN Consultancy, a leader in Website Development in Toronto offers valuable insights into creating...

By using Bytes.com and it's services, you agree to our Privacy Policy and Terms of Use.

To disable or enable advertisements and analytics tracking please visit the manage ads & tracking page.