Help with asp website form

[Mike]

I'm used to unix/cgi scripts so im slightly out of my depth here.
Ive got an asp script for a website form which works fine.
What i want to do is also get the form to include the ip address of the
perosn sending the form ie
<input type=hidden name=env_report value=REMOTE_AD DR>
Anyone know how to apply this to this asp script below?:

<%
For Each x in request.form
sBody = sBody & x & " = " & request.form(x) & vbCrLf
Next
Set MailObject = Server.CreateOb ject("CDONTS.Ne wMail")
MailObject.From = "we*****@xxx.co m"
MailObject.To = "we*****@xxx.co m"
MailObject.Subj ect = "Form"
MailObject.Body = sBody & vbCrLf

MailObject.Send
Set MailObject = Nothing
' Now redirect
Response.Redire ct "http://www.xxx/thank_you.htm"
%>

[Ray at]

I really think that if you step back and look at everything, you'll be able
to piece it all together. I don't mean this in a snide way, but is your
intention to learn ASP or just get this script working and not care about
learning anything?

Ray at work

"Mike" <[e-mail] > wrote in message
news:10******** *******@nnrp-t71-02.news.uk.clar a.net...

I must be close! grrr.
Any pointers what is wrong?
<%@ Language=VBScri pt %>
<%
Option Explicit
Dim iMsg
For Each x in request.form
sBody = sBody & x & " = " & request.form(x) & vbCrLf
Next

Set iMsg = CreateObject("C DO.Message")
iMsg.To = mi**@xxx.com
iMsg.Subject = "This is the Subject"
iMsg.From = "Me mi**@xxx.com"
iMsg.TextBody = "This is the body of the message"
Request.ServerV ariables("REMOT E_ADDR")

iMsg.Send
Response.Redire ct "/thank_you.htm"
%>

[Mike]

"Ray at <%=sLocation% >" <myfirstname at lane34 dot com> wrote in message
news:Ol******** ******@TK2MSFTN GP12.phx.gbl...

I really think that if you step back and look at everything, you'll be able to piece it all together. I don't mean this in a snide way, but is your
intention to learn ASP or just get this script working and not care about
learning anything?

Ray at work

The best way i learn this basic stuff is by knowing the answer (ie seeing a
working script) so I can see
where its wrong and work backwards.
I appreciate what your saying, youve helped enough.

Can anyone else tell me what is wrong with this basic script?

many thanks

[Ray at]

"Mike" <[e-mail] > wrote in message
news:10******** ********@nnrp-t71-01.news.uk.clar a.net...

The best way i learn this basic stuff is by knowing the answer (ie seeing

a working script) so I can see
where its wrong and work backwards.
Fair enough. :]
Here:

<%@ Language=VBScri pt %>
<%
Option Explicit
Dim iMsg, sBody

'''sBody wasn't dimmed before. It must be dimmed
'''when using Option Explicit. (Using Option Explicit
'''is a GOOD habit. I suggest you continue using it.)

'''x was not dimmed either.
Dim x
For Each x in request.form
sBody = sBody & x & " = " & request.form(x) & vbCrLf
Next

'''You now have a variable that contains the form data separated by line
breaks.

'''Concatenate IP address:
sBody = sBody & Request.ServerV ariables("REMOT E_ADDR")

'''Now your body is ready, create your e-mail object

Set iMsg = CreateObject("C DO.Message")
iMsg.To = mi**@xxx.com
iMsg.Subject = "This is the Subject"
iMsg.From = "Me mi**@xxx.com"

'''For the body text, you want to use the variable from above
iMsg.TextBody = sBody

iMsg.Send

'Response.Redir ect "/thank_you.htm"
'Response.REdir ect is commented out. It's best not to redirect
'until you know everything's working well.
'
'For the sake of seeing what's going on, let's response.write the value
'of that sBody variable.

Response.Write sBody
'Note that vbCrLf is just a line break. Everything will appear
'on one line in the browser, but that's because a Web page would
'need <br> for line breaks. You don't care if it's displayed all
'in one line in the browser. A view-source will show it to you
'the same way that you will (hopefully) see it in an e-mail.
%>
Ray at work



I appreciate what your saying, youve helped enough.

Can anyone else tell me what is wrong with this basic script?

many thanks

[Mike]

Nope, no joy.
i think im going to have to scrap this particular script and try and find
downloadable working script that i can play around with.
Thanks for all your help Ray. I see what youre saying but can't
understand why it doesn't work then assuming everything is correct.
<%@ Language=VBScri pt %>
<%
Option Explicit
Dim iMsg, sBody
Dim x
For Each x in request.form
sBody = sBody & x & " = " & request.form(x) & vbCrLf
Next
sBody = sBody & Request.ServerV ariables("REMOT E_ADDR")
Set iMsg = CreateObject("C DO.Message")
iMsg.To = "mi**@xxx.c om"
iMsg.Subject = "This is the Subject"
iMsg.From = "Me <mi**@xxx.com >"
iMsg.TextBody = sBody
iMsg.Send
Response.Redire ct "/thank_you.htm"
%>

[Ray at]

What's no joy? Did you get an error? COMMENT OUT THE REDIRECT and maybe
you'll see something. What isn't working? There is nothing wrong with the
code below. Perhaps someone else can chime in to verify this.

Ray at work

"Mike" <[e-mail] > wrote in message
news:10******** ********@nnrp-t71-03.news.uk.clar a.net...

Nope, no joy.
i think im going to have to scrap this particular script and try and find
downloadable working script that i can play around with.
Thanks for all your help Ray. I see what youre saying but can't
understand why it doesn't work then assuming everything is correct.
<%@ Language=VBScri pt %>
<%
Option Explicit
Dim iMsg, sBody
Dim x
For Each x in request.form
sBody = sBody & x & " = " & request.form(x) & vbCrLf
Next
sBody = sBody & Request.ServerV ariables("REMOT E_ADDR")
Set iMsg = CreateObject("C DO.Message")
iMsg.To = "mi**@xxx.c om"
iMsg.Subject = "This is the Subject"
iMsg.From = "Me <mi**@xxx.com >"
iMsg.TextBody = sBody
iMsg.Send
Response.Redire ct "/thank_you.htm"
%>

[Mike]

"Ray at <%=sLocation% > [MVP]" <myfirstname at lane34 dot com> wrote in
message news:%2******** ********@TK2MSF TNGP11.phx.gbl. ..

What's no joy? Did you get an error? COMMENT OUT THE REDIRECT and maybe
you'll see something. What isn't working? There is nothing wrong with the code below. Perhaps someone else can chime in to verify this.

Ray at work

Just goes to a HTTP 500 error page. Wonder if it could be the host:
www.hostmysite.com

[Curt_C [MVP]]

500 page means you have IE configured to show "friendly" error messages most
likely....

Turn that off and try again

--
Curt Christianson
Owner/Lead Developer, DF-Software
www.Darkfalz.com
"Mike" <[e-mail] > wrote in message
news:10******** ********@nnrp-t71-02.news.uk.clar a.net...

"Ray at <%=sLocation% > [MVP]" <myfirstname at lane34 dot com> wrote in
message news:%2******** ********@TK2MSF TNGP11.phx.gbl. ..

What's no joy? Did you get an error? COMMENT OUT THE REDIRECT and maybe you'll see something. What isn't working? There is nothing wrong with

the

code below. Perhaps someone else can chime in to verify this.

Ray at work

Just goes to a HTTP 500 error page. Wonder if it could be the host:
www.hostmysite.com

[Ray at]

Okay, we're one inch closer now. The next step is to find out what the real
error is. Read this and change your setting and try again. You will see
the error.

www.aspfaq.com/2109

Ray at work

"Mike" <[e-mail] > wrote in message
news:10******** ********@nnrp-t71-02.news.uk.clar a.net...

"Ray at <%=sLocation% > [MVP]" <myfirstname at lane34 dot com> wrote in
message news:%2******** ********@TK2MSF TNGP11.phx.gbl. ..

What's no joy? Did you get an error? COMMENT OUT THE REDIRECT and maybe you'll see something. What isn't working? There is nothing wrong with

the

code below. Perhaps someone else can chime in to verify this.

Ray at work

Just goes to a HTTP 500 error page. Wonder if it could be the host:
www.hostmysite.com

[Mike]

Thanks Ray / Curt
Have come across that browser issue before, great to know theres a way to
get the real details back!

Microsoft VBScript runtime error '800a01f4'

Variable is undefined: 'x'

/asp/form.asp, line 5

=============== =============== ==

<%@ Language=VBScri pt %>
<%
Option Explicit
Dim iMsg
For Each x in request.form
sBody = sBody & x & " = " & request.form(x) & vbCrLf
Next

Set iMsg = CreateObject("C DO.Message")
iMsg.To = mi**@xxx.com
iMsg.Subject = "This is the Subject"
iMsg.From = "Me <mi**@xxx.com >"
iMsg.TextBody = "This is the body of the message"
Request.ServerV ariables("REMOT E_ADDR")

iMsg.Send
Response.Redire ct "/thank_you.htm"
%>

[Ray at]

Does this look familiar to you at all? It's from a few posts back:

'''sBody wasn't dimmed before. It must be dimmed
'''when using Option Explicit. (Using Option Explicit
'''is a GOOD habit. I suggest you continue using it.)

'''x was not dimmed either.

--

Ray at home
Microsoft ASP MVP

In news:10******** ********@demete r.uk.clara.net,
Mike <[e-mail] > typed:

Thanks Ray / Curt
Have come across that browser issue before, great to know theres a
way to get the real details back!

Microsoft VBScript runtime error '800a01f4'

Variable is undefined: 'x'

/asp/form.asp, line 5

=============== =============== ==

<%@ Language=VBScri pt %>
<%
Option Explicit
Dim iMsg
For Each x in request.form
sBody = sBody & x & " = " & request.form(x) & vbCrLf
Next

Set iMsg = CreateObject("C DO.Message")
iMsg.To = mi**@xxx.com
iMsg.Subject = "This is the Subject"
iMsg.From = "Me <mi**@xxx.com >"
iMsg.TextBody = "This is the body of the message"
Request.ServerV ariables("REMOT E_ADDR")

iMsg.Send
Response.Redire ct "/thank_you.htm"
%>