if then errors in vba. please help

[Lazareth]

Hi.

Please help. Still learning...

I am trying to write some code that will assign certain values to a variable based on values from a textbox.
So far I have the following but It doesn't seen to be working.

It should be that if my textbox is
0-3 then the expand value should be 0
4-6 then the expand value should be 1
6 and over then the expand value should be 2

This is the code I have

Dim lines As Double
Dim expand As Double

'reset expand value
expand = 0

'check line values and adjust expand values to suit
lines = txtLines.Text
If lines =>4 and <=6 Then
expand = 1
Else: If lines > 6 Then expand = 2
End If

[hariharanmca]

Hi.

Please help. Still learning...

I am trying to write some code that will assign certain values to a variable based on values from a textbox.
So far I have the following but It doesn't seen to be working.

It should be that if my textbox is
0-3 then the expand value should be 0
4-6 then the expand value should be 1
6 and over then the expand value should be 2

This is the code I have

Dim lines As Double
Dim expand As Double

'reset expand value
expand = 0

'check line values and adjust expand values to suit
lines = txtLines.Text
If lines =>4 and <=6 Then
expand = 1
Else: If lines > 6 Then expand = 2
End If

[PHP]
If lines < 4 Then
expand = 1
ElseIf lines >= 4 And lines <= 6 Then
expand = 1
ElseIf lines > 6 Then
expand = 2
End If[/PHP]

just try this.

hange

ElseIf lines >= 4 And <= 6 Then

to

ElseIf lines >= 4 And lines  <= 6 Then

[Lazareth]

thank you.

worked sweet.

[Killer42]

ElseIf lines >= 4 And <= 6 Then
ElseIf lines >= 4 And lines  <= 6 Then

Of course, you could just change it to

ElseIf lines <= 6 Then

for the same effect.

[hariharanmca]

Of course, you could just change it to

ElseIf lines <= 6 Then

for the same effect.

i cannot get what you mean

ElseIf lines >= 4 And <= 6 Then
ElseIf lines >= 4 And lines <= 6 Then

in the above code they miss 'lines' so i did it

[Killer42]

i cannot get what you mean ...

I'm aware of that. My point is that we already know the value is >= 4, so it's not actually necessary to check it again. So ElseIf lines <= 6 would work just as well.

[hariharanmca]

I'm aware of that. My point is that we already know the value is >= 4, so it's not actually necessary to check it again. So ElseIf lines <= 6 would work just as well.

You mean

If lines < 4 Then
    expand = 1
ElseIf lines <= 6 Then
    expand = 1
Else
    expand = 2
End If

Yha you are correct.

[Killer42]

Yeah, it was no big deal. Just pointing out a slightly shorter alternative coding.