Need help with Select Case

[nfenlon]

I'm new to VB express 2005 and am having some trouble with coding.

I'm using a CASE structure in my program and i'm wondering if anyone can help me. Instead of Saying "Case 1,2,3,4" is there a way of saying "1 to 4". I've tried everything and nothing works.
(TextBox1.Text >= 1) And (TextBox1.Text <= 4) didn't work either.

PS: the actual problem is a bit more complex than just 1,2,3,4

Thanks guys, hope you can help.

Select Case TextBox1.Text
            Case 1, 2, 3, 4
                Generator(TextBox1.Text)
                Exit Select
            Case Else
                MsgBox("Please enter numeric values between 1 to 150.", vbOKOnly, "Generate_1")
                TextBox1.Clear()
                TextBox1.Focus()
                Exit Select
End Select

[hariharanmca]

I'm new to VB express 2005 and am having some trouble with coding.

I'm using a CASE structure in my program and i'm wondering if anyone can help me. Instead of Saying "Case 1,2,3,4" is there a way of saying "1 to 4". I've tried everything and nothing works.
(TextBox1.Text >= 1) And (TextBox1.Text <= 4) didn't work either.

PS: the actual problem is a bit more complex than just 1,2,3,4

Thanks guys, hope you can help.

Select Case TextBox1.Text
Case 1, 2, 3, 4
Generator(TextB ox1.Text)
Exit Select
Case Else
MsgBox("Please enter numeric values between 1 to 150.", vbOKOnly, "Generate_1 ")
TextBox1.Clear( )
TextBox1.Focus( )
Exit Select
End Select

better you can use if condition.

Select Case val(TextBox1.Text)
            Case 1, 2, 3, 4
                Generator(TextBox1.Text)
            Case Else
                MsgBox("Please enter numeric values between 1 to 150.", vbOKOnly, "Generate_1")
                TextBox1.Clear()
                TextBox1.Focus()
End Select

just try this

[Killer42]

In VB6, you would say Case 1 To 4. Don't know about your version, though. What have you tried?

[hariharanmca]

In VB6, you would say Case 1 To 4. Don't know about your version, though. What have you tried?

I never tried any thing. Just suggested him to use ‘if’ condition

[Killer42]

...just try this

Try what? The IF statement?

Functionally, Select Case is about the same as an IF and a bunch of ELSEIFs. But one of the great things about Select Case has always been the way it allows you to write more easily readable code. It's much easier to interpret at a glance the meaning of something like "15 To 38" than "If blah >= 15 And blah <= 38 Then".

[Killer42]

I never tried any thing. Just suggested him to use ‘if’ condition

I wasn't asking you. That was a response to the original poster.

[nfenlon]

Thanks guys. I've tried "Case 1 To 4", I've tried a series of "If Else" statements, I've tried "B>=1 And B<=4" but none of these work.
The full code i'm using checks a textbox for Null, for values too great, for values too small and for characters in order to trap erroneous entries. The only case that calls my function in if the entry is between 1 to 150. I have it working at the moment but i still thing there's a bug because the "Case Else" condition is never met, event when you enter a character! I thought maybe it's due to the fact that i'm checking characters and numeric values????

Hope you can help, the code is below.
Thanks guys!

See what i mean. The code is untidy!!!

Private Sub Button1_Click(ByVal sender As Object, ByVal e As System.EventArgs) Handles Button1.Click
        '
        Select Case TextBox1.Text
            Case 1, 2, 3, 4, 5, 6, 7, 8, 9, 10, 11, 12, 13, 14, 15, 16, 17, 18, 19, 20, 21, 22, 23, 24, 25, 26, 27, 28, 29, 30, 31, 32, 33, 34, 35, 36, 37, 38, 39, 40, 41, 42, 43, 44, 45, 46, 47, 48, 49, 50, 51, 52, 53, 54, 55, 56, 57, 58, 59, 60, 61, 62, 63, 64, 65, 66, 67, 68, 69, 70, 71, 72, 73, 74, 75, 76, 77, 78, 79, 80, 81, 82, 83, 84, 85, 86, 87, 88, 89, 90, 91, 92, 93, 94, 95, 96, 97, 98, 99, 100, 101, 102, 103, 104, 105, 106, 107, 108, 109, 110, 111, 112, 113, 114, 115, 116, 117, 118, 119, 120, 121, 122, 123, 124, 125, 126, 127, 128, 129, 130, 131, 132, 133, 134, 135, 136, 137, 138, 139, 140, 141, 142, 143, 144, 145, 146, 147, 148, 149, 150 
                Generator(TextBox1.Text)
                Exit Select
            Case Is = ""
                MsgBox("Please enter numeric values between 1 to 150.", vbOKOnly, "Generate_1")
                TextBox1.Clear()
                TextBox1.Focus()
                Exit Select
            Case Is > 150
                MsgBox("Please enter numeric values between 1 to 150.", vbOKOnly, "Generate_2")
                TextBox1.Clear()
                TextBox1.Focus()
                Exit Select
            Case Is < 1
                MsgBox("Please enter numeric values between 1 to 150.", vbOKOnly, "Generate_3")
                TextBox1.Clear()
                TextBox1.Focus()
                Exit Select
            Case Else
                MsgBox("Please enter numeric values between 1 to 150.", vbOKOnly, "Generate_4")
                TextBox1.Clear()
                TextBox1.Focus()
                Exit Select
        End Select
        '
    End Sub

[hariharanmca]

Try what? The IF statement?

Functionally, Select Case is about the same as an IF and a bunch of ELSEIFs. But one of the great things about Select Case has always been the way it allows you to write more easily readable code. It's much easier to interpret at a glance the meaning of something like "15 To 38" than "If blah >= 15 And blah <= 38 Then".

i said for only this case. because, that was very few.

[cyberdaemon]

Thanks guys. I've tried "Case 1 To 4", I've tried a series of "If Else" statements, I've tried "B>=1 And B<=4" but none of these work.
The full code i'm using checks a textbox for Null, for values too great, for values too small and for characters in order to trap erroneous entries. The only case that calls my function in if the entry is between 1 to 150. I have it working at the moment but i still thing there's a bug because the "Case Else" condition is never met, event when you enter a character! I thought maybe it's due to the fact that i'm checking characters and numeric values????

Hope you can help, the code is below.
Thanks guys!

See what i mean. The code is untidy!!!

Private Sub Button1_Click(B yVal sender As Object, ByVal e As System.EventArg s) Handles Button1.Click
'
Select Case TextBox1.Text
Case 1, 2, 3, 4, 5, 6, 7, 8, 9, 10, 11, 12, 13, 14, 15, 16, 17, 18, 19, 20, 21, 22, 23, 24, 25, 26, 27, 28, 29, 30, 31, 32, 33, 34, 35, 36, 37, 38, 39, 40, 41, 42, 43, 44, 45, 46, 47, 48, 49, 50, 51, 52, 53, 54, 55, 56, 57, 58, 59, 60, 61, 62, 63, 64, 65, 66, 67, 68, 69, 70, 71, 72, 73, 74, 75, 76, 77, 78, 79, 80, 81, 82, 83, 84, 85, 86, 87, 88, 89, 90, 91, 92, 93, 94, 95, 96, 97, 98, 99, 100, 101, 102, 103, 104, 105, 106, 107, 108, 109, 110, 111, 112, 113, 114, 115, 116, 117, 118, 119, 120, 121, 122, 123, 124, 125, 126, 127, 128, 129, 130, 131, 132, 133, 134, 135, 136, 137, 138, 139, 140, 141, 142, 143, 144, 145, 146, 147, 148, 149, 150
Generator(TextB ox1.Text)
Exit Select
Case Is = ""
MsgBox("Please enter numeric values between 1 to 150.", vbOKOnly, "Generate_1 ")
TextBox1.Clear( )
TextBox1.Focus( )
Exit Select
Case Is > 150
MsgBox("Please enter numeric values between 1 to 150.", vbOKOnly, "Generate_2 ")
TextBox1.Clear( )
TextBox1.Focus( )
Exit Select
Case Is < 1
MsgBox("Please enter numeric values between 1 to 150.", vbOKOnly, "Generate_3 ")
TextBox1.Clear( )
TextBox1.Focus( )
Exit Select
Case Else
MsgBox("Please enter numeric values between 1 to 150.", vbOKOnly, "Generate_4 ")
TextBox1.Clear( )
TextBox1.Focus( )
Exit Select
End Select
'
End Sub

You are converting TextBox1.text to integer and (integer <> string) this is why it does not work.

try

select case ctype(textbox1. text, integer)
...


or

select case textbox1.text
case "1", "2", "3", "4", ... , "148", "149", "150"
...



the ... in the case is me not writing every number, hopefully this helps you. Good luck and happy coding

Cyberdaemon

[Killer42]

You are converting TextBox1.text to integer and (integer <> string) this is why it does not work.

I wouldn't be too certain about that. VB would probably have to do the same string-to-number conversion when it compares them, so the test may work.

Personally, I feel that if the To clause no longer works (thanks a heap, M$) then ELSEIF is the way to go. It allows something much easier to read. For example (I don't know VB.Net, so my syntax is probably messed up)...

Dim TheNumber As Single
TheNumber = TextBox1.Text ' You can use Val() or CSng() if you like.
 
If TextBox1.Text = "" Then
  MsgBox("Please enter numeric values between 1 to 150.", vbOKOnly, "Generate_1")
  TextBox1.Clear()
  TextBox1.Focus()
ElseIf TheNumber > 150 Then
  MsgBox("Please enter numeric values between 1 to 150.", vbOKOnly, "Generate_2")
  TextBox1.Clear()
  TextBox1.Focus()
ElseIf TheNumber < 1 Then
  MsgBox("Please enter numeric values between 1 to 150.", vbOKOnly, "Generate_3")
  TextBox1.Clear()
  TextBox1.Focus()
ElseIf TheNumber <> Int(TheNumber) Then
  ' Not a whole number.
  MsgBox("Please enter numeric values between 1 to 150.", vbOKOnly, "Generate_4")
  TextBox1.Clear()
  TextBox1.Focus()
Else
  Generator(TextBox1.Text)
End If