TripleDES class - Suggestions Requested.

[d4v3y0rk]

i have a class i found/wrote (meaning i found it originally and
tinkered with it to make it mine) and i would like some suggestions on
how to make it better. i am looking for things i need to add,
weaknesses, whatnot. Thanks in advance.

-----------------------------------------------------------------------------------------------------------------

Imports System.Security .Cryptography
Imports System.Security
Imports System.Text
Imports System.IO

Public Class encoder

Private m_des As New TripleDESCrypto ServiceProvider
Private m_utf8 As New UTF8Encoding
Private m_key() As Byte
Private m_iv() As Byte = {8, 7, 6, 5, 4, 3, 2, 1}

Public Function Encrypt(ByVal text As String, ByVal strPassword As
String) As String
m_key =
System.Text.Enc oding.UTF8.GetB ytes(strPasswor d.PadRight(24, "&"))
Dim input() As Byte = m_utf8.GetBytes (text)
Dim output() As Byte = Transform(input ,
m_des.CreateEnc ryptor(m_key, m_iv))
Return Convert.ToBase6 4String(output)
End Function

Public Function Decrypt(ByVal text As String, ByVal strPassword As
String) As String
m_key =
System.Text.Enc oding.UTF8.GetB ytes(strPasswor d.PadRight(24, "&"))
Dim input() As Byte = Convert.FromBas e64String(text)
Dim output() As Byte = Transform(input ,
m_des.CreateDec ryptor(m_key, m_iv))
Return m_utf8.GetStrin g(output)
End Function

Private Function Transform(ByVal input() As Byte, ByVal
CryptoTransform As ICryptoTransfor m) As Byte()
Dim memStream As MemoryStream = New MemoryStream
Dim cryptStream As CryptoStream = New CryptoStream(me mStream,
CryptoTransform , CryptoStreamMod e.Write)
cryptStream.Wri te(input, 0, input.Length)
cryptStream.Flu shFinalBlock()
memStream.Posit ion = 0
Dim result(CType(me mStream.Length - 1, System.Int32)) As Byte
memStream.Read( result, 0, CType(result.Le ngth, System.Int32))
memStream.Close ()
cryptStream.Clo se()
Return result
End Function

End Class

-----------------------------------------------------------------------------------------------------------------

[TrtnJohn]

Make it more general purpose. For example:

1) Create a constructor that can set the key data up
2) Don't hard your Encrypt and Decrypt to only work for your specific need
today. Make these types of functions general.
3) If you want to add an Encrypt/Decrypt Password function make them
seperate functions or possibly a derived class.

BTW. You do know there is an easier way to encrypt passwords? Have you
ever tried using SHA256 instead of 3DES. If you use SHA you don't need to
keep a key around somewhere.

"d4******@gmail .com" wrote:

i have a class i found/wrote (meaning i found it originally and
tinkered with it to make it mine) and i would like some suggestions on
how to make it better. i am looking for things i need to add,
weaknesses, whatnot. Thanks in advance.

-----------------------------------------------------------------------------------------------------------------

Imports System.Security .Cryptography
Imports System.Security
Imports System.Text
Imports System.IO

Public Class encoder

Private m_des As New TripleDESCrypto ServiceProvider
Private m_utf8 As New UTF8Encoding
Private m_key() As Byte
Private m_iv() As Byte = {8, 7, 6, 5, 4, 3, 2, 1}

Public Function Encrypt(ByVal text As String, ByVal strPassword As
String) As String
m_key =
System.Text.Enc oding.UTF8.GetB ytes(strPasswor d.PadRight(24, "&"))
Dim input() As Byte = m_utf8.GetBytes (text)
Dim output() As Byte = Transform(input ,
m_des.CreateEnc ryptor(m_key, m_iv))
Return Convert.ToBase6 4String(output)
End Function

Public Function Decrypt(ByVal text As String, ByVal strPassword As
String) As String
m_key =
System.Text.Enc oding.UTF8.GetB ytes(strPasswor d.PadRight(24, "&"))
Dim input() As Byte = Convert.FromBas e64String(text)
Dim output() As Byte = Transform(input ,
m_des.CreateDec ryptor(m_key, m_iv))
Return m_utf8.GetStrin g(output)
End Function

Private Function Transform(ByVal input() As Byte, ByVal
CryptoTransform As ICryptoTransfor m) As Byte()
Dim memStream As MemoryStream = New MemoryStream
Dim cryptStream As CryptoStream = New CryptoStream(me mStream,
CryptoTransform , CryptoStreamMod e.Write)
cryptStream.Wri te(input, 0, input.Length)
cryptStream.Flu shFinalBlock()
memStream.Posit ion = 0
Dim result(CType(me mStream.Length - 1, System.Int32)) As Byte
memStream.Read( result, 0, CType(result.Le ngth, System.Int32))
memStream.Close ()
cryptStream.Clo se()
Return result
End Function

End Class

-----------------------------------------------------------------------------------------------------------------