Attached is my code. Which I know there is a better way of writing however
this is what I came up with and it works until the value is null or not = to
the <> value.
'Do While rdrSQL.Read()
'While rdrSQL.Read()
' Dim result As String
' result = Trim(rdrSQL.Get String(0))
' Do While result <> Me.txtUserID.Te xt
' Loop
' If result = Me.txtUserID.Te xt Then
' MsgBox("Authent icated")
' Dim frm As New Form1
' frm.Show()
' Me.Hide()
' Else
' Me.Close()
' End If
'End While 5 2783
Hi Mike,
Did not check it all, but in this code I saw some things 'Do While rdrSQL.Read()
delete that row I think wthat ill be better
'While rdrSQL.Read() ' Dim result As String ' result = Trim(rdrSQL.Get String(0)) ' Do While result <> Me.txtUserID.Te xt
I think you want here
If resul = Me.txtUserId.te xt then exit while
' Loop
change it to end while ' If result = Me.txtUserID.Te xt Then ' MsgBox("Authent icated")
And please do us a favor, paste your code the next time first in a notepad
and copy it that back before to paste it in the message, makes it more
readable and people will mostly faster help you.
I hope this helps a little bit?
Cor
Um.. perhpas these two lines are your problem:
' Do While result <> Me.txtUserID.Te xt
' Loop
that, my friend, is an endless loop. You don't change the result
variable inside the loop and so the loop goes on forever.
---
Regards,
Roy Osherove www.iserializable.com
On Wed, 5 Nov 2003 16:04:19 -0500, "Mike D" <di****@hotmail .com>
wrote: ' Do While result <> Me.txtUserID.Te xt
' Loop
>> Proudly fixed.<<
I worked most of the night thinking this out and today walked in wit a
result..
Here is the final code that actually works
Private Sub Button1_Click(B yVal sender As System.Object, ByVal e As
System.EventArg s) Handles Button1.Click
cnSQL.Open()
Dim strsql As String
strsql = "Select username FROM tblSecurity"
Dim cmd As New SqlCommand(strs ql, cnSQL)
Dim daSQL As New SqlDataAdapter( strsql, cnSQL)
Dim rdrSQL As SqlDataReader = cmd.ExecuteRead er()
Do While rdrSQL.Read()
result = Trim(rdrSQL.Get String(0))
If result = Me.txtUserID.Te xt Then
MsgBox("Authent icated")
Dim frm As New Form1
frm.Show()
Me.Hide()
Exit Do
End If
Loop
If result <> Me.txtUserID.Te xt Then
MsgBox("You are not Authorized on the system!")
cnSQL.Close()
rdrSQL.Close()
Me.Close()
End If
cnSQL.Close()
rdrSQL.Close()
Me.Close()
End Sub
"Roy Osherove" <ro**@iserializ able.com> wrote in message
news:92******** *************** *********@4ax.c om... Um.. perhpas these two lines are your problem:
' Do While result <> Me.txtUserID.Te xt
' Loop
that, my friend, is an endless loop. You don't change the result variable inside the loop and so the loop goes on forever. --- Regards,
Roy Osherove www.iserializable.com
On Wed, 5 Nov 2003 16:04:19 -0500, "Mike D" <di****@hotmail .com> wrote:
' Do While result <> Me.txtUserID.Te xt
' Loop
"Mike D" <di****@hotmail .com> wrote... Here is the final code that actually works
Mike... congrats on getting it "to work" now :you just have to fix it :-) I
don't mean to cause you grief but now that you have the basics figured out
consider how much stuff is going on in an event handler. Not only a ton of
code (unreusable except for cut-and-paste) but you are declaring (and
displaying) a form within it.
You are referencing the txtUserID textbox "directly" rather than passing in
a string, you have cnSQL.Close() and rdrSQL.Close() and Me.Close() in there
twice. The trouble with this kind of thing is that it can only get worse as
more of the app gets completed. Code doesn't get cleaner, it only decays
over time and gets harder to follow as a result.
You can ignore me of course, it works... but think about it at least.
Tom
Hi Mike,
I did not want to give some critique on your code, you did sound so proud.
And there is nothing wrong to start with doing things even if it is not the
best way. But now that Tom did it a little bit, I give you the advice to
change this. strsql = "Select username FROM tblSecurity"
If you put in here a where clause (there is a nicer way to do it, but this
shows it fine)
strsql = "Select username from tblSecurity WHERE username = '" & trim(txt)
& "'"
Then your system has only to do one read. and if it exist in the first read
you have it.
What Tom said was more efficiency in coding, it does not give you any
advantage in your program itself. With this it goes a lot faster (except
when you have 1 user than it is slower) :-).
I now can see that it is not, but your approach looks like the webform old
ASP style, but that will soon also change in the way Tom said I think.
But it is good you did found it yourself, it is the same as what I did tell
in my message with the difference you use the do while and I was telling you
the while. The do while you use is more from this time, but I did not wanted
to change your basic code to much then.
I hope this helps a little bit.
Cor This thread has been closed and replies have been disabled. Please start a new discussion. Similar topics |
by: Dave |
last post by:
After following Microsofts admonition to reformat my system before doing a
final compilation of my app I got many warnings/errors upon compiling an rtf
file created in word. I used the Help Workshop program: hcw.exe that's
included with Visual Basic. This exact same file compiled perfectly with no
notes, warnings or errors prior to reformatting my system. Prior to the
reformatting, I copied the help.rtf file onto a CD and checked the box to...
|
by: Tom |
last post by:
A question for gui application programmers. . .
I 've got some GUI programs, written in Python/wxPython, and I've got
a help button and a help menu item. Also, I've got a compiled file
made with the microsoft HTML workshop utility, lets call it
c:\path\help.chm. My question is how do you launch it from the GUI?
What logic do I put behind the "help" button, in other words.
I thought it would be
os.spawnv(os.P_DETACH,...
|
by: Sarir Khamsi |
last post by:
Is there a way to get help the way you get it from the Python
interpreter (eg, 'help(dir)' gives help on the 'dir' command) in the
module cmd.Cmd? I know how to add commands and help text to cmd.Cmd
but I would also like to get the man-page-like help for classes and
functions. Does anyone know how to do that? Thanks.
Sarir
|
by: wukexin |
last post by:
Help me, good men. I find mang books that introduce bit "mang header
files",they talk too bit,in fact it is my too fool, I don't learn it, I have
do a test program, but I have no correct doing result in any way. Who can
help me, I thank you very very much.
list.cpp(main program)
//--------------------------------------------------------------------------
-
#pragma hdrstop
#pragma argsused
|
by: Colin J. Williams |
last post by:
Python advertises some basic service:
C:\Python24>python
Python 2.4.1 (#65, Mar 30 2005, 09:13:57) on
win32
Type "help", "copyright", "credits" or "license" for more information.
>>>
With numarray, help gives unhelpful responses:
| |
by: Corepaul |
last post by:
Missing Help Files
When I enter "recordset" as the keyword and search the Visual Basic Help index,
I get many topics of interest in the resulting list. But there isn't any
information available from clicking on many of the available topics (mostly
methods but some properties are also unavailable). This same problem occurs
with many, if not most, keywords.
Is there any way I can activate these "missing" help topics? HELP!
|
by: Steve |
last post by:
I have written a help file (chm) for a DLL and referenced it using Help.ShowHelp
My expectation is that a developer using my DLL would be able to access this help file during his development time using "F1" help within the VB IDE. Is this expectation achievable
In trying to test my help file in the IDE, I have a solution with 2 projects: the DLL and a tester. VB does not look for my help file; instead, it looks for path to my source code...
|
by: Mark |
last post by:
I have loaded Visual Studio .net on my home computer and my laptop, but my
home computer has an abbreviated help screen not 2% of the help on my laptop.
All the settings look the same on both including search the internet for
help, but the help is worthless. Any ideas?
|
by: JonathanOrlev |
last post by:
Hello everybody,
I wrote this comment in another message of mine, but decided to post it
again as a standalone message.
I think that Microsoft's Office 2003 help system is horrible, probably
the worst I
ever seen.
I almost cannot find anything I need, including things I
|
by: hitencontractor |
last post by:
I am working on .NET Version 2003 making an SDI application that calls MS Excel 2003.
I added a menu item called "MyApp Help" in the end of the menu bar to show Help-> About.
The application calls MS Excel, so the scenario is that I am supposed to see the Excel Menu bar,
FILE EDIT VIEW INSERT ... HELP.
I am able to see the menu bar, but in case of Help, I see the Help of Excel and help of my application, both as a submenu of help.
...
|
by: Oralloy |
last post by:
Hello folks,
I am unable to find appropriate documentation on the type promotion of bit-fields when using the generalised comparison operator "<=>".
The problem is that using the GNU compilers, it seems that the internal comparison operator "<=>" tries to promote arguments from unsigned to signed.
This is as boiled down as I can make it.
Here is my compilation command:
g++-12 -std=c++20 -Wnarrowing bit_field.cpp
Here is the code in...
| |
by: jinu1996 |
last post by:
In today's digital age, having a compelling online presence is paramount for businesses aiming to thrive in a competitive landscape. At the heart of this digital strategy lies an intricately woven tapestry of website design and digital marketing. It's not merely about having a website; it's about crafting an immersive digital experience that captivates audiences and drives business growth.
The Art of Business Website Design
Your website is...
|
by: Hystou |
last post by:
Overview:
Windows 11 and 10 have less user interface control over operating system update behaviour than previous versions of Windows. In Windows 11 and 10, there is no way to turn off the Windows Update option using the Control Panel or Settings app; it automatically checks for updates and installs any it finds, whether you like it or not. For most users, this new feature is actually very convenient. If you want to control the update process,...
|
by: tracyyun |
last post by:
Dear forum friends,
With the development of smart home technology, a variety of wireless communication protocols have appeared on the market, such as Zigbee, Z-Wave, Wi-Fi, Bluetooth, etc. Each protocol has its own unique characteristics and advantages, but as a user who is planning to build a smart home system, I am a bit confused by the choice of these technologies. I'm particularly interested in Zigbee because I've heard it does some...
|
by: conductexam |
last post by:
I have .net C# application in which I am extracting data from word file and save it in database particularly. To store word all data as it is I am converting the whole word file firstly in HTML and then checking html paragraph one by one.
At the time of converting from word file to html my equations which are in the word document file was convert into image.
Globals.ThisAddIn.Application.ActiveDocument.Select();...
|
by: TSSRALBI |
last post by:
Hello
I'm a network technician in training and I need your help.
I am currently learning how to create and manage the different types of VPNs and I have a question about LAN-to-LAN VPNs.
The last exercise I practiced was to create a LAN-to-LAN VPN between two Pfsense firewalls, by using IPSEC protocols.
I succeeded, with both firewalls in the same network. But I'm wondering if it's possible to do the same thing, with 2 Pfsense firewalls...
|
by: 6302768590 |
last post by:
Hai team
i want code for transfer the data from one system to another through IP address by using C# our system has to for every 5mins then we have to update the data what the data is updated we have to send another system
| |
by: muto222 |
last post by:
How can i add a mobile payment intergratation into php mysql website.
|
by: bsmnconsultancy |
last post by:
In today's digital era, a well-designed website is crucial for businesses looking to succeed. Whether you're a small business owner or a large corporation in Toronto, having a strong online presence can significantly impact your brand's success. BSMN Consultancy, a leader in Website Development in Toronto offers valuable insights into creating effective websites that not only look great but also perform exceptionally well. In this comprehensive...
| |