Filling a lookup field with a data reader

[Woody Splawn]

I have some code that I put in the Before_Dropdown event of a combobox field
on a winform. It works but only because I am making use of a public
boolean variable called IveFilledCompan ys. The code follows:

If IveFilledCompan ys = False Then
SqlConnection1. Open()
Dim SqlReader As System.Data.Sql Client.SqlDataR eader
SqlReader = SqlCommand1.Exe cuteReader()
While SqlReader.Read
cboCompanys.Ite ms.Add(SqlReade r.Item("Company "))
End While
SqlReader.Close ()
SqlConnection1. Close()
IveFilledCompan ys = True
End If

I would like to keep the use of public variables to a minimum. I wonder if
there is another way to write this code without the variable. Basically, I
would like the code (upon arrival on the combobox field) to fill the
combobox with data if it has not already been filled. I thought perhaps
something like the following would work, again, this is in the
BeforeDropDown event.

Dim iCount As Integer = cboCompanys.Dat aBindings.Count ()
If iCount <= 1 Then
... fill the table code
Else
MsgBox("It's already been filled. Do nothing")
End If

However, I find that when running my code iCount never equals anything but
1.

Anyone have any ideas on how I can accomplish what I want?

[Richard Brown]

New here, but why dont you just change your code to read:

If cboCompany.Item s.Count = 0 Then
SqlConnection1. Open()
Dim SqlReader As System.Data.Sql Client.SqlDataR eader
SqlReader = SqlCommand1.Exe cuteReader()
While SqlReader.Read
cboCompanys.Ite ms.Add(SqlReade r.Item("Company "))
End While
SqlReader.Close ()
SqlConnection1. Close()
IveFilledCompan ys = True
End If
"Woody Splawn" <wo***@splawns. com> wrote in message
news:eH******** ******@TK2MSFTN GP12.phx.gbl... I have some code that I put in the Before_Dropdown event of a combobox field on a winform. It works but only because I am making use of a public
boolean variable called IveFilledCompan ys. The code follows:

If IveFilledCompan ys = False Then
SqlConnection1. Open()
Dim SqlReader As System.Data.Sql Client.SqlDataR eader
SqlReader = SqlCommand1.Exe cuteReader()
While SqlReader.Read
cboCompanys.Ite ms.Add(SqlReade r.Item("Company "))
End While
SqlReader.Close ()
SqlConnection1. Close()
IveFilledCompan ys = True
End If

I would like to keep the use of public variables to a minimum. I wonder if there is another way to write this code without the variable. Basically, I would like the code (upon arrival on the combobox field) to fill the
combobox with data if it has not already been filled. I thought perhaps
something like the following would work, again, this is in the
BeforeDropDown event.

Dim iCount As Integer = cboCompanys.Dat aBindings.Count ()
If iCount <= 1 Then
... fill the table code
Else
MsgBox("It's already been filled. Do nothing")
End If

However, I find that when running my code iCount never equals anything but
1.

Anyone have any ideas on how I can accomplish what I want?

[Woody Splawn]

>New here, but why dont you just change your code to read

That was a good suggestion. Thank you.

[Kevin Yu]

Hi Woody,

The iCount never changes because you didn't add any Databindings to the
ComboBox. The DataBindings.Co unt property increases only when you use
DataBindings.Ad d() method to add a binding to a data source. When you
called cboCompanys.Ite ms.Add(), you didn't make any changes to the
DataBindings property. Please try to use iCount = cboCompanys.Ite ms.Count,
and check if iCount >0 before adding items to it.

If anything is unclear, please feel free to reply to the post.

Kevin Yu
=======
"This posting is provided "AS IS" with no warranties, and confers no
rights."